Bug Report

• import path of package in question, e.g. .../services/compute/mgmt/2018-06-01/compute "github.com/Azure/azure-sdk-for-go/services/recoveryservices/mgmt/2016-06-01/backup"

• SDK version e.g. master, latest, 18.1.0

{
			"checksumSHA1": "XiQW2U5GBOhOfPTwFlFeM2thDCs=",
			"path": "github.com/Azure/azure-sdk-for-go/services/recoveryservices/mgmt/2016-06-01/backup",
			"revision": "2935c0241c74bd8549b843978dd6fc1be6f48b4a",
			"revisionTime": "2018-08-31T14:25:13Z",
			"version": "=v20.1.0",
			"versionExact": "v20.1.0"
		},

• output of go version go version go1.10.3 darwin/amd64

• What happened? I am trying to update a recovery service policy retention days via this new terraform resource. Creating the policy works just fine for all configurations, however updating from daily -> weekly, or changing the retention days for monthly or yearly gives a vague error:

* azurerm_recovery_services_protection_policy_vm.test: Error creating/updating Recovery Service Protection Policy "acctest-7026298197833106544" (Resource Group "acctestRG-7026298197833106544"): backup.ProtectionPoliciesClient#CreateOrUpdate: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="BMSUserErrorInvalidPolicyInput" Message="Input for create or update policy is not in proper format\r\nPlease check format of parameters like schedule time, schedule days, retention time and retention days "

The error message does not help, and I cannot see why this would create just fine, yet fail to update. Other values will update just fine.

• What did you expect or want to happen? the policy be updated or a more detailed error message describing what is actually wrong.

• How can we reproduce it? run the updateDailyToWeekly test in that PR.

• Anything we should know about your environment.

Further to the discussion #27 this pull request converts the Azure SDK to having a stateful client, allowing multiple subscriptions to be operated on in one process. It also makes the package name compliant with the go standards (removing the need to alias it) and flattens the hierarchy of packages from one-per-client down to just one.

Given the size of this refactor I fully expect there to be discussion etc around whether this will be accepted into this project or whether the API changes are too vast and it needs to become something different. As far as I can tell the tests all pass, though ultimately Travis will be the arbiter of that!

Make it so we don't need to create and destroy SPs for local dev box testing and it'll work just fine in CI since the environment credential is included.

This SDK has Redis functionality - but the docs are no where to be found on the MSDN documentation site

https://msdn.microsoft.com/en-us/library/mt420159.aspx

Paul

Feature Request

Azure Cosmos DB supports queries with parameters.

However, ContainerClient.NewQueryItemsPager in azcosmos only supports a query string without accompanying parameters.

It would be handy to be able supply parameters to mitigate SQL injection.

I've observed two things regarding usages of the azure-sdk-for-go:

1. Creation of an interface that covers the surface of the various clients exposed. (For testing/mocking purposes)
2. Implementation of a faked out implementation of those interfaces.

I'm wondering if those could be auto-generated for the user?

(If someone can send me a DL for the SDK team I can forward an internal link to a PR that demonstrates the couple of things that could potentially be auto-generated)

I've tested with this quite a lot to be sure everything still works as expected and I can confirm it does (added and removed multiple VM's, VNET's, subnets, endpoints and NSGs).

Next to it seeming a bit odd (unless very specific reason to do so) to have a pointer to a referenced type, removing the pointers for slices makes working with the package a lot nicer and more intuitive.

Lots of renames and changes based on the API reviews:

Admin API:

• All Response structs have been broken down into Response+Result
• QueueName, TopicName, SubscriptionName are no longer present in the Properties structs as that doesn't reflect the API itself.
• Exists functions have been removed
• Missing fields have been added (UserMetadata, etc..)

Sender and Receiver API:

• SendMessages removed in favor of making SendMessageBatch more intuitive (by simplfying the .AddMessage API)
• Several renames suggested in review
• ReceiveMessages has been tuned to match the .NET limits (which has worked well in practice). This is partly addressing #15963, as our default limit was far higher than needed.

Missing:

• AuthorizationRules, SubscriptionRules (coming in a future PR but requires a bit more thought)

Feature Request

Please support API version "2020-02-02-preview" for Application Insights. There's a major new feature supported in this version, the workspace-based Application Insights resource. It allows integrating AI into a Log Analytics workspace, meaning that the Log Analytics workspace is the data back end for Application Insights. I noticed the lack of this feature as I started implementing support for this feature in Terraform.

Thanks and kind regards.

This can lead to a series of retries that will not work. It'd be nice to be able to pass in an error handling strategy per RPC call so we can provide better error handling when we know what the context of the call is and just fail early.

The underlying error is:

Code: 404 Description: "The messaging entity 'sb://.servicebus.windows.net/samples' could not be found. To know more visit https://aka.ms/sbResourceMgrExceptions. TrackingId:888b355f-038e-42e1-ab5d-cf1d0bfa20d1_G53, SystemTracker:riparkdev2.servicebus.windows.net:samples, Timestamp:2021-11-04T17:42:29"

NetworkProfile.PodCidr is required even if "azure" network is specified in the NetworkProfile.NetworkPlugin field. As far as I know this is only a mandatory field when kubenet is used.

We allow configuring Prefetch for PartitionClient instances created from ConsumerClient. We should add this option to the Processor as well since it creates PartitionClient instances on the user's behalf.

This PR adds support to list/query databases within an account and containers within a database, including support for parametrized querying:

queryPager := client.NewQueryDatabasesPager("select * from dbs d", nil)

opt := &azcosmos.QueryDatabasesOptions{
		QueryParameters: []azcosmos.QueryParameter{
			{"@id", "the_id"},
		},
	}

queryPager := client.NewQueryDatabasesPager("select * from dbs d where d.id = @id", opt)

queryPager := database.NewQueryContainersPager("select * from colls c", nil)

opt := &azcosmos.QueryContainersOptions{
		QueryParameters: []azcosmos.QueryParameter{
			{"@id", "the_id"},
		},
	}

queryPager := database.NewQueryContainersPager("select * from colls c where c.id = @id", opt)

APIView

https://apiview.dev/Assemblies/Review/b128254cd7ac437390ea6c0c6ef4a5de/7294484ab73e4677bc962c0137b42104?diffRevisionId=1f3ba5313df24d4c9800d33af3254c9c&doc=False&diffOnly=True

• [x] The purpose of this PR is explained in this or a referenced issue.
• [x] The PR does not update generated files.
• [x] Tests are included and/or updated for code changes.
• [x] Updates to [CHANGELOG.md][] are included.
• [x] MIT license headers are included in each file.

Closes https://github.com/Azure/azure-sdk-for-go/issues/19749

Hello @gracewilcox,

Happy new year. Hope you are doing well.

Does this azure golang sdk support azure workload identity. We are planning to migrate from AAD pod identity to Azure workload identity in Azure kubernetes.

Any updates on this integration?

Thank you. Have a nice day.

Kind Regards, Tanul