Bug Description

ValidateRequired doesn't produce error even though required field is empty

Steps to reproduce

https://play.golang.org/p/9soJDMn9B8t

Expected result

ch.Errors() should be [ktp_direksi is required, tdp is required, sk_domisili is required, akta_pendirian is required, akta_perubahan is required]

Actual result

ch.Errors() is [] (empty)

Possible root cause

• For this to happen, we need to set some fields in the entity. If some fields in the entity has been set to non empty value, ch.zero will be false.
• If the required field is not in the changeset and ch.zero is false, it will check if the required field exists in ch.values
• Required fields exists in ch.values, but it only checks for empty string and nil value.
• Since the required fields (e.g sk_domisili) has fichaURL as its type, it will check for nil value. Since it's not nil, it will continue and skip the loop without adding error to the changeset https://github.com/Fs02/grimoire/blob/master/changeset/validate_required.go#L27

Possible solution

• Change nil check to zero value check with IsZero https://github.com/Fs02/grimoire/blob/master/changeset/validate_required.go#L27

Thanks guys for sharing this package, very intuitive api in most cases with exception for relationships...

More of the question than issue I hope:

So I have relationship one to many:

Tests Table:

CREATE TABLE tests (
    id INT UNSIGNED AUTO_INCREMENT PRIMARY KEY,
    title TEXT NOT NULL,
    created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
    updated_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP
);

Tags Table:

CREATE TABLE tags (
    id INT UNSIGNED AUTO_INCREMENT PRIMARY KEY,
    test_id INT UNSIGNED,
    title TEXT NOT NULL,
    created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
    updated_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
    FOREIGN KEY (test_id)
        REFERENCES tests(id)
        ON DELETE CASCADE
);

Here are the structs:

type Test struct {
	ID        int
	Title     string
	Tags      []Tag `references:"ID" foreign_key:"TestID"`
	CreatedAt string
	UpdatedAt string
}

type Tag struct {
	ID        int
	TestID    int
	Title     string
	CreatedAt string
	UpdatedAt string
}

My question is how do I query all the tests with all assosiated tags. I tried all posibilities and I can not figure it out how to query relationships. Always geting null for the tags... Any help would be appriciated.

{
"status": "OK",
"data": [
{
"ID": 1,
"Title": "test 1",
"Tags": null,
"CreatedAt": "2019-08-19 23:18:24",
"UpdatedAt": "2019-08-19 23:18:24"
},
{
"ID": 1,
"Title": "test 1",
"Tags": null,
"CreatedAt": "2019-08-19 23:18:24",
"UpdatedAt": "2019-08-19 23:18:24"
},
{
"ID": 1,
"Title": "test 1",
"Tags": null,
"CreatedAt": "2019-08-19 23:18:24",
"UpdatedAt": "2019-08-19 23:18:24"
},
etc.

Bumps github.com/tidwall/gjson from 1.1.3 to 1.6.5.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Hello,

I would like to say thank you for helping out last time. Unfortunetly I got stuck again.

I am trying to query many to many realtionship.

1. Post table

id title

2. Pivot Table

id post_id tag_id

3. Tag Table id title

Tables in the db are named as: posts, post_tag and tags. As far, this naming convention was working great for preloading has many, has one or belongs to. Can't figure it out how do I query posts with all the tags. Tried joins with preload but always get a panic mentioning that PostID or TagID field is not found...

Your FOSSA integration was successful! Attached in this PR is a badge and license report to track scan status in your README.

Below are docs for integrating FOSSA license checks into your CI:

• CircleCI
• TravisCI
• Jenkins
• Other

Bumps github.com/tidwall/gjson from 1.6.5 to 1.9.3.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Issue: The validation is still running when setting a field with empty values using changeset.EmptyValues(..) options, giving a validation error.

This is an issue when a field is intentionally set to an empty value.

There's an issue in ValidateRequired when using changeset with default value. See the example here: https://play.golang.org/p/IFXG3A6s9ey

Since it checks changeset.changes with isZero, some_bool field is considered empty because its value is false.

The solution is to revert zero value check with isZero. To compare with default value, implement isZeroer interface instead.

note: This changes has been tested in papyrus repository and all tests pass.

After https://github.com/Fs02/grimoire/pull/57 has merged, I found that there's still an mishandled case in put default, which is when the existing value is zero and the input for that field is also zero value. (Ex: A field that hasn't been filled previously and want to be filled with a zero value)

That field gets a default value put into it, when the input parameters tell it to fill it with zero

Update PutDefault Method Put default value only if there's no change and no existing value.

Problem:

• changeset.Cast will give empty changes when given input with same value as existing value, triggering the PutDefault

• Cache some functions that use reflection.
• Ability to avoid reflection on some cases by implementing inferfaces:

// Defines fields in a struct, used mainly in changeset.
type fields interface {
	Fields() map[string]int
}

// Defines type of fields in a struct, used mainly in changeset.
type types interface {
	fields
	Types() []reflect.Type
}

// Defines values of fields in a struct, used mainly in changeset.
type values interface {
	fields
	Values() []interface{}
}

// Defines database scanners, used when scanning result from database rows.
type scanners interface {
	Scanners([]string) []interface{}
}