As per documention:

If the module is released at major version 2 or higher, the module path must end with a major version suffix

Since go-steam has go.mod file at git tag v2.0.0 it must have module github.com/Philipp15b/go-steam/v2 in go.mod and not module github.com/Philipp15b/go-steam.

Because of that it cannot be shown in htttps://pkg.go.dev/ for example.

autho.go atomic.StoreUint64(&a.client.steamId, uint64(steamid.New(0, 1, int32(EUniverse_Public), EAccountType_Individual)))

then I change the code as:

uuu := uint64(steamid.New(0, 1, int32(EUniverse_Public), EAccountType_Individual))

fmt.Printf("a=%p,a.client=%p,a.client.steamId=%d\n",a,a.client,a.clien.steamId)

atomic.StoreUint64(&(a.client.steamId), uuu)

Printf: a has valid address, a.client also has valid address, and a.client.steamId=0

but atomic.StoreUint64(&(a.client.steamId), uuu) still painc nil pointer

When I call

	myLoginInfo := new(steam.LogOnDetails)
	myLoginInfo.Username = "user"
	myLoginInfo.Password = "pass"

	client := steam.NewClient()
	client.Connect()

Sometimes it works but then I get this error:

 Error reading from the connection: EOF

or sometimes is throws an error on client.Connect():

Connect failed: dial tcp 162.254.196.43:27020: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

How can I solve this?

fixes https://github.com/Philipp15b/go-steam/issues/118

Hello,

this is my first PR on here, I never used go-steam yet, I wanted to but came across the issue #118

this was a tough one I didn't test yet, the generator generate the files without errors

Sample of code:

case *steam.WebLoggedOnEvent:
            log.Print("Successfully logged on web")

            token := "awajV_Bp"

            TOClient := tradeoffer.NewClient(SteamAPIKey, client.Web.SessionId, client.Web.SteamLogin, client.Web.SteamLoginSecure)
            Offers, _ := TOClient.GetOffers()

            for _, TOffer := range Offers.Received {
                if (TOffer.State == 2) {
                    log.Println("Starting processing TOffer")

                    myItems := make([]tradeoffer.TradeItem, len(TOffer.ToReceive))
                    theirItems := make([]tradeoffer.TradeItem, 0)
                    for k, Asset := range TOffer.ToReceive {
                        myItems[k] = tradeoffer.TradeItem{
                            AppId: uint32(Asset.AppId),
                            ContextId: uint64(Asset.ContextId),
                            Amount: uint(Asset.Amount),
                            AssetId: uint64(Asset.AssetId),
                        }
                    }

                    log.Println(TOClient.Accept(TOffer.TradeOfferId))
                    log.Println(TOClient.Create(TOffer.OtherAccountId, &token, myItems, theirItems, nil, ""))
                }
            }

And github.com/Philipp15b/tradeoffer/tradeoffer.go

// If we failed, error out
    if resp.StatusCode != 200 {
        return nil, errors.New("create error: status code not 200")
    }

replaced to (just for check body of result page)

// If we failed, error out
    if resp.StatusCode != 200 {
        data, _ := ioutil.ReadAll(resp.Body)
        fmt.Println(string(data))
        return nil, errors.New("create error: status code not 200")
    }

Result: http://i.imgur.com/fzEYOk3.png (Checked on Windows and Mac)

tradeoffer.Accept working good, but tradeoffer.Create doesn't work

Hi, I am trying to get the VDF data on apps and packages. The app proto CMsgClientPICSProductInfoResponse_AppInfo seems to always return okay but trying to get the VDF data from a package CMsgClientPICSProductInfoResponse_PackageInfo always returns binary VDF. Is there a helper somewhere to convert to text? Thanks.

I am trying to update to a new SteamKit version now, but the build fails:

$ go run generator.go clean proto steamlang
# Cleaning
# Building Steam Language
# Building Protobufs
> [libprotobuf WARNING google/protobuf/compiler/parser.cc:564] No syntax specified for the proto file: steammessages_parental.steamclient.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
> [libprotobuf WARNING google/protobuf/compiler/parser.cc:564] No syntax specified for the proto file: steammessages_unified_base.steamclient.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
> [libprotobuf WARNING google/protobuf/compiler/parser.cc:564] No syntax specified for the proto file: google/protobuf/descriptor.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
> panic: runtime error: index out of range

goroutine 1 [running]:
main.cutAllSubmatch(0xc0000ce090, 0xc000176000, 0xeac0, 0xecc0, 0x1, 0x2, 0xc000024080, 0x0)
        /home/nuc/go/src/github.com/Philipp15b/go-steam/generator/generator.go:227 +0xe2
main.fixProto(0xc0000aa180, 0x2b)
        /home/nuc/go/src/github.com/Philipp15b/go-steam/generator/generator.go:196 +0x530
main.buildProtoMap(0x5301a6, 0xb, 0xc000096270, 0x531a8d, 0x14)
        /home/nuc/go/src/github.com/Philipp15b/go-steam/generator/generator.go:92 +0x195
main.buildProto()
        /home/nuc/go/src/github.com/Philipp15b/go-steam/generator/generator.go:82 +0xfd
main.main()
        /home/nuc/go/src/github.com/Philipp15b/go-steam/generator/generator.go:37 +0x20e
exit status 2

Btw it might help that https://github.com/faceit/go-steam has some commits for newer SteamKit versions.

Revised import statements across the whole project. Guidelines: https://github.com/golang/go/wiki/CodeReviewComments#import-dot

The dot imports have rendered this project completely unreadable. Excessive verbosity has to be solved by other means of refactoring/restructuring/renaming. Dot imports are not a good solution.

This change adds to clarity and separation of namespaces.

Hi there,

Excuse me if I'm blatantly incorrect - this endeavour was my first time writing any Go.

I've got a source file which is simply a Hello World, but loads in go-steam as my first ask after Hello World is going to be logging into a Steam account.

package mmstats_provider

import (
    "fmt"
    "github.com/Philipp15b/go-steam"
    "github.com/Philipp15b/go-steam/internal/steamlang"
    "io/ioutil"
    "log"
)

func main() {
    fmt.Println("Hello World")
}

When attempting to build this little bit of code, I got the following error:

../../Philipp15b/go-steam/auth.go:50: cannot use steamlang.EAccountType_Individual (type steamlang.EAccountType) as type int32 in argument to steamid.NewIdAdv

If I understand correctly, this is because EAccountType_Individual is of type EAccountType (which is based upon int32, but I guess Go is pretty strict about it's types), whereas steamid.NewIdAdv is expecting a regular int32 for a user's account type. I can workaround this for now by casting EAccountType_Individual to int32, but I think the correct solution is to change NewIdAdv to accept an EAccountType value for accountType instead of int32 - and at present I don't know how to do that (importing steamlang errored out because of circular imports).

Thanks,

Steam have two type of connection , UDP and TCP according to steamRE connection.cs

Do you wish to upgrade go-steam to include it as well ? some code needed to be changed mainly on

client.go

• read / write loop handling should be handle by connection.go

connection.go

• connection interface to handle UDP and TCP

API provided by client.go should not be changed ( at least not to my knowledge )

what do you think ?

Closes #108. Code used in PR is originally made by https://github.com/fortis and is used in https://github.com/fortis/go-steam-totp. Code is tested and works well.

There were 2 variables next. One is local to the loop and another in the outer scope. On every iteration, starting from the second, latest would become equal to the outer next (which was always nil) and fail immediately.

Hey!

I really enjoy working with your library. However, with the new protobuf library from Google, I am running into the following issue:

panic: proto: file "steammessages_base.proto" has a name conflict over CMsgProtoBufHeader
        previously from: "github.com/Philipp15b/go-steam/v3/csgo/protocol/protobuf"
        currently from:  "github.com/Philipp15b/go-steam/v3/protocol/protobuf"
See https://developers.google.com/protocol-buffers/docs/reference/go/faq#namespace-conflict

This seems to be caused by the default init in the protobuf packages. Since both the csgo/protocol/protobuf and the protocol/protobuf package declare the same base protobufs, there seems to be a conflict.

I am only importing github.com/Philipp15b/go-steam/v3/csgo/protocol/protobuf in my code. But I would guess that the other package is being imported automatically by a package in the background.

Does anyone have a idea how to fix that issue? Merging the protobufs into one directory would be a solution, but not the prettiest solution.

Update: I guess that a fix could be implemented in this projects generator. We should try to use the same base protobufs and not duplicate the definitions.

I use Steam Guard 2FA and I can't solve this one.

Right now, the sentry file is ignored on subsequent login attempts, and I'm always asked for the 2FA. Here are some observations on the code.

An observation on the gsbot's Auth type HandleEvent method:

func (a *Auth) HandleEvent(event interface{}) {
	switch e := event.(type) {
	case *steam.MachineAuthUpdateEvent:
		a.machineAuthHash = e.Hash
		err := ioutil.WriteFile(a.sentryPath, e.Hash, 0666)
		if err != nil {
			panic(err)
		}
	}
}

It never informs Steam servers of accepting the Sentry file.

An observation on SteamKit's MachineAuthUpdateEvent:

        static void OnMachineAuth( SteamUser.UpdateMachineAuthCallback callback )
        {
            Console.WriteLine( "Updating sentryfile..." );

            // write out our sentry file
            // ideally we'd want to write to the filename specified in the callback
            // but then this sample would require more code to find the correct sentry file to read during logon
            // for the sake of simplicity, we'll just use "sentry.bin"

            int fileSize;
            byte[] sentryHash;
            using ( var fs = File.Open( "sentry.bin", FileMode.OpenOrCreate, FileAccess.ReadWrite ) )
            {
                fs.Seek( callback.Offset, SeekOrigin.Begin );
                fs.Write( callback.Data, 0, callback.BytesToWrite );
                fileSize = ( int )fs.Length;

                fs.Seek( 0, SeekOrigin.Begin );
                using ( var sha = SHA1.Create() )
                {
                    sentryHash = sha.ComputeHash( fs );
                }
            }

            // inform the steam servers that we're accepting this sentry file
            steamUser.SendMachineAuthResponse( new SteamUser.MachineAuthDetails
            {
                JobID = callback.JobID,

                FileName = callback.FileName,

                BytesWritten = callback.BytesToWrite,
                FileSize = fileSize,
                Offset = callback.Offset,

                Result = EResult.OK,
                LastError = 0,

                OneTimePassword = callback.OneTimePassword,

                SentryFileHash = sentryHash,
            } );

            Console.WriteLine( "Done!" );
        }

It informs Steam servers of accepting the sentry file. Source: SteamKit SteamGuard example