Hi :)

Depending on which env i run it, it can result on:

$ ascii-image-converter ./my_image.png

panic: runtime error: index out of range [0] with length 0
goroutine 1 [running]:
github.com/TheZoraiz/ascii-image-converter/image_manipulation.ConvertToBrailleChars(0x0, 0x0, 0x0, 0x100, 0xff, 0xff, 0xff, 0x32, 0x0, 0x0, ...)
	/home/zozu/Stuff/Projects/ascii-image-converter/image_manipulation/ascii_conversions.go:180 +0xa6c
github.com/TheZoraiz/ascii-image-converter/aic_package.pathIsImage(0x7ffeae218883, 0xa, 0x0, 0x0, 0xc00000c300, 0x0, 0x0, 0x0, 0xc000010128, 0xc0000304f8, ...)
	/home/zozu/Stuff/Projects/ascii-image-converter/aic_package/convert_image.go:54 +0x2ee
github.com/TheZoraiz/ascii-image-converter/aic_package.Convert(0x7ffeae218883, 0xa, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/home/zozu/Stuff/Projects/ascii-image-converter/aic_package/convert_root.go:157 +0x668
github.com/TheZoraiz/ascii-image-converter/cmd.glob..func1(0xd26560, 0xc0000a48c0, 0x1, 0x5)
	/home/zozu/Stuff/Projects/ascii-image-converter/cmd/root.go:97 +0x379
github.com/spf13/cobra.(*Command).execute(0xd26560, 0xc000020250, 0x5, 0x5, 0xd26560, 0xc000020250)
	/home/zozu/go/pkg/mod/github.com/spf13/[email protected]/command.go:856 +0x2c2
github.com/spf13/cobra.(*Command).ExecuteC(0xd26560, 0xc000000180, 0x200000003, 0xc000000180)
	/home/zozu/go/pkg/mod/github.com/spf13/[email protected]/command.go:960 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
	/home/zozu/go/pkg/mod/github.com/spf13/[email protected]/command.go:897
github.com/TheZoraiz/ascii-image-converter/cmd.Execute()
	/home/zozu/Stuff/Projects/ascii-image-converter/cmd/root.go:118 +0x31
main.main()
	/home/zozu/Stuff/Projects/ascii-image-converter/main.go:22 +0x25

In this example, i launch it on a docker ubuntu 18 running inside a linux gitlab runner. Any idea ?

when dragging and drop the image path on windows, it always gives out an error message, but when running cmd in admin mode, drag and drop simply won't work.

👋 , first of all, thanks for this tool, it's awesome :)

I was wondering why you don't include a macOS version.

I was able to build ascii-image-converter locally (on Big Sur) without problems and since you are using goreleaser, it shouldn't take more than including darwin in the target goos.

So, if there is no particular reason against it, i'd love to have a release for mac. I have little experience with go, but I'm happy to send an initial PR to get this going. Let me know!

It would be useful to be able quickly convert an image from stdin, like this:

curl -sSL https:/foo.bar/baz.qux | ascii-image-converter

or

curl -sSL https:/foo.bar/baz.qux | ascii-image-converter -

and can allow some more mixups like:

curl -sSL https:/foo.bar/baz.qux | magick convert - png:- | ascii-image-converter

or

curl -sSL https:/foo.bar/baz.qux | magick convert - png:- | ascii-image-converter -

I personally prefer doing it by default, but either one is fine by me 🤷

When I use the command to save the ascii art in a txt file, it not displays properly, I think it's because the spaces or line breaks that the script don't do.

When I use the "-C" to display the output, the result is wired. The image saved using "--save-img" seems to be fine.

the output displayed in the terminal.

the saved result

Is there a way to save the output as an ansi text file? If I try to redirect output, it barfs during terminal size detection. If I also specify the output size with -d, it complains the terminal is too small.

Update: I was able to capture the output using script but it would certainly be nice to have a proper save-as-ansi option.

Gettings this error from brew:

Warning: Calling bottle :unneeded is deprecated! There is no replacement.
Please report this issue to the thezoraiz/ascii-image-converter tap (not Homebrew/brew or Homebrew/core):
  /opt/homebrew/Library/Taps/thezoraiz/homebrew-ascii-image-converter/ascii-image-converter.rb:10

Hello !

First of all, i would like to congratulate you on your work ! Your tool is very funny !

I propose you to use RGBA instead of RGB for --save-bg flag. With my modifications, i can generate images (png) with a transparent background ( r, b, g, 0 ).

Thank you !

1. When characters in the row have the same color, will be better print escape code only once: \e[38;5;20mw\e[38;5;20mm -> \e[38;5;20mwm
2. Use only space as invisible character, when background and text have same color: \e[38;5;0m<char> -> \e[38;5;0m

Also, will be cool mixing --color and --color-bg. Maybe, in form --color=(fg|bg|both)

Just going through and trying a little bit of refactoring to get a feel for the project. I did not see tests or lint rules but I did test manually for a bit, if there are concerns of specific flags or circumstances let me know.

When using --color-bg the saved image doesn't not have the background filled

This is the output in the terminal.

This is the image saved. image-ascii-art.png

Original image: https://thesungod.xyz/V8mITZeX.jpeg

I'm using version v1.11.0, installed via apt.

Hi,

ascii-image-converter just created the perfect startup banner for our spring boot application. Thanks a bunch!

As already noted, packaging is not trivial. A docker image for ascii-image-converter would make usage easier without the need for any local installation.

I am attaching a Dockerfile that created a well usable image for me. Dockerfile.ascii-image-converter.txt

(Usage: place in a working directory, such as an empty dir or the local git repo, execute docker build -t ascii-image-converter -f Dockerfile.ascii-image-converter.txt .. Usage of resulting image: docker run --rm -it ascii-image-converter <url>, or docker run -v $(pwd):/data --rm -it ascii-image-converter /data/<localfile>).

Would you be interested in providing an "official" image on docker hub?

If you prefer the file as a pull request, just give me a note.

I found this...

https://www.reddit.com/r/golang/comments/o2ztb9/how_do_i_make_a_launchpad_ppa_for_a_go/

...and was wondering if you were still interested in making that work.