Im pretty noob at this point, so if its not a bug - sorry. Well, i rewrite my app to use v3 instead of v2 and after 3 days of using i realized that in every deaths, in every name with "space", instead of normal spaces, there is everywhere non-breaking spaces what literally fucked up everything in my case (for example i cant search for character name, becouse "xxx xxx" its not the same as "xxx\u00a0xxx") well... i got 10k deaths in my db with that bullshit spaces... i belive that in v2 there are normal spaces, becouse i never had that problem before the problem is with "reasons" and also with all the names separately at deathlist... ofc i can fix it by my side while adding everything to db, but im pretty sure it should be changed at api side

This data could be scraped from https://www.tibia.com/library/?subtopic=creatures and https://www.tibia.com/library/?subtopic=boostablebosses, respectively, or in a single request by visiting most pages on tibia.com e.g. https://www.tibia.com/news/?subtopic=latestnews where the HTML contains something like:

<img id="Pedestal" src="https://static.tibia.com/images/global/header/pedestal.gif" alt="Monster Pedestal Box" /><br><img id="Monster" title="Today's boosted creature: Gozzler" src="https://static.tibia.com/images/global/header/monsters/gozzler.gif" onClick="window.location = 'https://www.tibia.com/library/?subtopic=creatures';" alt="Boosted Creature" /><img id="Boss" title="Today's boosted boss: Srezz Yellow Eyes" src="https://static.tibia.com/images/global/header/monsters/srezz.gif" onClick="window.location = 'https://www.tibia.com/library/?subtopic=boostablebosses';" alt="Boosted Boss" />

We were importing a few libs just because of a single constant value, instead, why not use the value directly?

From https://pkg.go.dev/golang.org/x/net/html/atom Br = 0x202

This happens to normal monsters who have ' of ' in their name and prefixed with 'a' or 'an' in the death message which causes them to match against summonRegex. A few examples would be sight of surrender, spark of destruction and the X of the cult family. A simple solution at a glance seems to be moving the get summon block inside TibiaDataParseKiller into the already existing if player conditional branch, and I don't believe this would affect deaths by summons of monsters since as far as I know they're always listed separately from their owner.

ONLY OCCURS DURING SERVER SAVE (10:00 CEST).

If any house in the list includes "finished", the API will respond with a blank page, or 404. Requests towards the API will get 500 back.

Example links: https://api.tibiadata.com/v3/houses/Antica/Ankrahmun https://api.tibiadata.com/v3/houses/Nadora/Liberty%20Bay

Ok, this is a massive PR and also a rewrite of good chunks of the code. I splitted it into a few commits to make it easier to follow. I'll also try to summarize it as much as I can here.

Reasoning: the webserver was already running on prod and was panicking on pretty much every error, which is not good. Besides that, invalid inputs (for example: 123456 as a char name) would return an "empty" json instead of an error.

Changes:

1: Static package

I created a static package and moved all test files inside it (without any changes to the test files). The reason was to be able to embed the files. Since I created "nested" packages, this helps a lot with dealing with file paths.

2: Tibia mapping package

Created a separate package to fetch data from assets.tibiadata.com. This was mainly to organize the code.

3: Validation package

This is one of the biggest changes. This is where all the validation is happening. I even moved some validation that was being handled in the main package into here.

This is how this package works: I implemented a bunch of error codes (errors.go), this makes it easier to debug code and also give users a more reasonable error response when making a request. I then made all handlers funcs validate their input (when needed), this reduces the amount of API calls made to tibia.com, but, most importantly, it gives us great control as to what error to return to the user. For example: instead of only responding with "character not found" we can give the user an error that exists in the input (name too small or too big for example). This package also has the limits.go file which are constants from tibia.com

~4: Env Vars funcs logic fix~

~This is a small change, isEnvExist and getEnv were simplified and had their logics fixed.~ (#91)

~5: Consistency changes~

~I changed all Tibiadata names to TibiaData, just for consistency.~ (#90) ~Stoped using ioutil as it is deprecated.~ (#92)

6: Debug endpoint

I created a /debug endpoint that shows some useful info about the validation package.

7: Error Handling

This is the biggest change on this PR. Here's what was done: All "Impl" funcs now return a pointer to their respective response and an error. This is how go handle errors. Before this, we were panicking on every error. Now we just return the error to the user.

I changed a few ".Each" funcs to ".EachWithBreak", this is to be able to break the loop if an error occurs.

Character not found, creature not found, spell not found, etc are now properly handled.

Added a Status struct to the Information struct, this is returned on every request for consistency and contains these fields: HTTPCode, Error, Message. Error is the int value of the error, and Message is a readable message from the error.

Created the TibiaDataErrorHandler that should be used everytime we want to return an error. TibiaDataAPIHandleResponse does not handle errors anymore and should not be called in case of an error.

Bumps golang.org/x/text from 0.5.0 to 0.6.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps github.com/gin-gonic/gin from 1.8.1 to 1.8.2.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps golang from 1.19.3 to 1.19.4.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps golang.org/x/text from 0.4.0 to 0.5.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps github.com/stretchr/testify from 1.8.0 to 1.8.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Adds two new endpoints to application so that kubernetes can monitor it.

• GET /healthz
• GET /readyz

The current /health endpoints changes status from UP to OK. The /health endpoint will be removed in a later update as well.

fix #146

Creature "spark of destruction" is getting parsed wrong.

List of various creatures: https://pastebin.com/9m4He1pq

URL that has an error: https://api.tibiadata.com/v3/character/Lupi%20Lucky

{
	"time": "2022-05-08T00:26:31Z",
	"level": 537,
	"killers": [{
		"name": "destruction",
		"player": false,
		"traded": false,
		"summon": "a spark"
	}],
	"assists": [],
	"reason": "Died at Level 537 by a spark of destruction."
}

We need to respond with proper error codes and messages.

Example scenarios:

• 404 if the resource is not found (e.g. faulty character name)
• 429 if the request is being throttled (tibia code is actually 403)
• 503 if there was some upstream issue
• and also something when tibia is having maintenance.

Section that needs to be rewritten/enhanced: https://github.com/TibiaData/tibiadata-api-go/blob/ce26e500e9e611886573ec790eeb4644b6657aa9/src/webserver.go#L679-L691

This should then also be added to the documentation annotation, so that docs get automatic update too.