• Use "sort.Slice" for sorting.

No need to write you own algorithm (unless you want to write tests for it too)

• TableDriven test instead of random generator.

Testing randomly generated slice by iterating over its elements is a strange idea. You will obviously get the expected result - you can't suddenly find something that wasn't already there or miss something that was.

• Formatted Error message.

You should provide some usefull info about the error. And "Fatal" has a different use case.

You need to make the top level of the repo a Go package in order to make it go get-able. Otherwise, it returns an error:

package github.com/floyernick/Data-Structures-and-Algorithms: no Go files in /Users/philip/src/github.com/floyernick/Data-Structures-and-Algorithms

It can as simple as a package declaration and it will work, i.e. in new file dsa.go at the top level of the package, just have a single line of package dsa and you're good to go.

https://github.com/floyernick/Data-Structures-and-Algorithms/blob/6ae8c0f2e09c371f47f2a3c76f3b73989e4f3c45/BinarySearch/BinarySearch_test.go#L21

• This line could generate the number 0 in which case it would pass without making any verifications. suggest you add 10 to get some numbers.

make it faster than before

Benchmark_MergeSort_new-12 10 102711316 ns/op Benchmark_MergeSort_new-12 10 102242814 ns/op Benchmark_MergeSort_new-12 10 104988258 ns/op Benchmark_MergeSort_old-12 3 338513872 ns/op Benchmark_MergeSort_old-12 4 334441485 ns/op Benchmark_MergeSort_old-12 3 334280000 ns/op

This version reslices the left and right arrays instead of passing around array indices. This feels like more idiomatic Go to me, but it might not follow the textbook version of mergesort as closely as the old version.

Data Structures and Algorithms

Clean and simple implementation in Go

Implementation

There are several data structures and algorithms implemented in this project. The list will be replenished with time.

Data structures

• Circular Buffer

#18 It Make MergeSort faster than before and I Commit a pull request. ———————————————————————————————————— Benchmark_MergeSort_new Benchmark_MergeSort_new-12 10 101394033 ns/op 209956300 B/op 1000041 allocs/op Benchmark_MergeSort_new-12 10 103156080 ns/op 209956320 B/op 1000041 allocs/op Benchmark_MergeSort_new-12 10 105631558 ns/op 209956272 B/op 1000041 allocs/op Benchmark_MergeSort_old Benchmark_MergeSort_old-12 4 322263281 ns/op 582174710 B/op 4052123 allocs/op Benchmark_MergeSort_old-12 3 333629871 ns/op 582175192 B/op 4052124 allocs/op Benchmark_MergeSort_old-12 3 350259903 ns/op 582174706 B/op 4052122 allocs/op

The GetLast() function traverses through the entire LL to get to the last pointer, when there's already a tail node. The fix gets rid of the traversal and returns the tail node value.

func (list *LinkedList) GetLast() (int, bool) {
	if list.head == nil {
		return 0, false
	}
	return list.tail.data, true
}