• Dockerfile changes

  • Added .dockerignore so unneded files aren't copied over
  • Smaller docker image using scratch image
  • Binaries are statically linked and build with cgo so that they can run on a scratch image.
  • docker image does run as root (could be a security issue) this could be easily changed but may also be harder to setup for some

• Releases

  • When a tag is created github actions will create a release and upload binaries.
  • Binaries for linux and windows are statically linked and built with cgo, so they should have no dependencies.
  • Built with -extldflags -s -w flags for a smaller binary this strips dwarf tables used in debuggers and doesn't affect stack traces.
    • Release Targets:
      • linux-amd64 (tested)
      • linux-arm64 (untested)
      • linux-armv7 (untested)
      • win-amd64 (tested)
      • darwin-amd64 (untested)
  • Docker files will be created and uploaded to docker hub.
  • Tagged latest and with tag
    • linux-amd64 (tested)
    • linux-arm64 (untested)
    • linux-armv7 (untested)

• Continous Integration

  • uses v1.x for latest version of golang
  • added go vet in linting stage
  • go build is run for all release targets as well(maintainers will have access to build artifacts).
  • added docker build and upload to docker hub for push to master, images tagged with commit sha1.

• A go-shiori account will need to be made on docker hub

• A personal access token will need to be created on docker hub

• The following gihub actions secrets will need to be set in github

  • DOCKER_HUB_USERNAME
  • DOCKER_HUB_ACCESS_TOKEN

-Examples: https://github.com/n8225/shiori/actions https://github.com/n8225/shiori/releases https://hub.docker.com/r/nrew225/shiori

Related Issues: #263 #260

Closes #254 #267 #238 #273

I'm trying to host shiori on port 7777 and then proxy pass https://localhost/shiori/ to that port, but when I do using this nginx config:

  location /shiori/ {
    rewrite ^/shiori/(.*)$ /$1 break;
    proxy_pass http://localhost:7777;
    proxy_redirect http://localhost:7777/ $scheme://$host/shiori/;
  }

I get this result:

This page isn’t working

And the URL shows:

https://localhost/login

Any ideas? Seems like shiori redirects to / (root).

Manually going to localhost/shiori/login brings up a broken login page, seemingly without both css, images, etc (can't click on anything).

How can I install in a Raspberry Pi? I've tried building from source using Go. No luck. I also tried building the dockerfile provided, as well as this modification by 5hay. Neither worked.

Does anyone know how to install it on Raspbian?

Hello,

I upgraded shiori from 1.0-1 to 1.5.0-2 on my computer on Arch Linux. I couldn't login with my previous credentials so I logged in with the default as described here. However, the list of bookmarks was empty. I recreated an account with the same username, but a different password and still no bookmarks were listed.

When I check the file at ~/.local/share/shiori/shiori.db I see the data is still here. I did a backup and then tried to add a new bookmark with the new account. The file at ~/.local/share/shiori/shiori.db has not been modified, but the new bookmark seems to be saved somewhere.

It looks like the storage location has changed, but if I read the documentation, the default data directory seems to be this.

Do you have an idea of the reason of the lost bookmarks?

I run:

./shiori --portable serve

And I see a zero size file shiori.db in the shiori-data directory:

ls -l shiori-data
-rw-r--r-- 1 user users 0 aug 23 21:57 shiori.db

Open in browser, try to login shiori/gopher and see:

failed to fetch accounts: SQL logic error: no such table: account (1) (500)

It works only if before the first start run:

./shiori --portable migrate

I use shiori v1.5.3.

Shiori Docker with Postgresql database, on Ubuntu Server 19.10.

My compose:

shiori:
    image: radhifadlillah/shiori
    container_name: shiori
    depends_on:
      - shioridb
    restart: unless-stopped
    ports:
      - "8989:8080"
    volumes:
     - ${USERDIR}/docker/shiori:~/.local/share/shiori
    environment:
      - PUID=${PUID}
      - PGID=${PGID}
      - TZ=${TZ}
      # - SHIORI_DIR=${USERDIR}/docker/shiori
      - SHIORI_DBMS=postgresql
      - SHIORI_PG_USER=shiori
      - SHIORI_PG_PASS=shioripass
      - SHIORI_PG_NAME=shioridb
      - SHIORI_PG_HOST=shioridb
      - SHIORI_PG_PORT=5432
  shioridb:
    image: postgres:12-alpine
    container_name: shioridb
    restart: always
    environment:
      - POSTGRES_USER=shiori
      - POSTGRES_PASSWORD=shioripass
      - POSTGRES_DB=shioridb
    volumes:
      - ${USERDIR}/docker/shiori/db:/var/lib/postgresql/data

It was working fine at first but now, while trying to add bookmarks through gui I'm getting this error:

failed to save bookmark: pq: current transaction is aborted, commands ignored until end of transaction block (500)

I'm also seeing this in the shioridb logs:

2019-11-22 12:52:27.773 UTC [589] ERROR:  insert or update on table "bookmark_tag" violates foreign key constraint "bookmark_tag_bookmark_id_fk"


2019-11-22 12:52:27.773 UTC [589] DETAIL:  Key (bookmark_id)=(5) is not present in table "bookmark".


2019-11-22 12:52:27.773 UTC [589] STATEMENT:  INSERT INTO bookmark_tag


			(tag_id, bookmark_id) VALUES ($1, $2) ON CONFLICT DO NOTHING


2019-11-22 13:15:00.325 UTC [589] ERROR:  insert or update on table "bookmark_tag" violates foreign key constraint "bookmark_tag_bookmark_id_fk"


2019-11-22 13:15:00.325 UTC [589] DETAIL:  Key (bookmark_id)=(15) is not present in table "bookmark".


2019-11-22 13:15:00.325 UTC [589] STATEMENT:  INSERT INTO bookmark_tag


			(tag_id, bookmark_id) VALUES ($1, $2) ON CONFLICT DO NOTHING


2019-11-22 13:15:00.326 UTC [589] ERROR:  current transaction is aborted, commands ignored until end of transaction block


2019-11-22 13:15:00.326 UTC [589] STATEMENT:  SELECT id FROM tag WHERE name = $1


2019-11-22 13:17:25.315 UTC [589] ERROR:  insert or update on table "bookmark_tag" violates foreign key constraint "bookmark_tag_bookmark_id_fk"


2019-11-22 13:17:25.315 UTC [589] DETAIL:  Key (bookmark_id)=(22) is not present in table "bookmark".


2019-11-22 13:17:25.315 UTC [589] STATEMENT:  INSERT INTO bookmark_tag


			(tag_id, bookmark_id) VALUES ($1, $2) ON CONFLICT DO NOTHING


2019-11-22 13:17:25.316 UTC [589] ERROR:  current transaction is aborted, commands ignored until end of transaction block


2019-11-22 13:17:25.316 UTC [589] STATEMENT:  SELECT id FROM tag WHERE name = $1


2019-11-22 13:18:19.518 UTC [589] ERROR:  insert or update on table "bookmark_tag" violates foreign key constraint "bookmark_tag_bookmark_id_fk"


2019-11-22 13:18:19.518 UTC [589] DETAIL:  Key (bookmark_id)=(23) is not present in table "bookmark".


2019-11-22 13:18:19.518 UTC [589] STATEMENT:  INSERT INTO bookmark_tag


			(tag_id, bookmark_id) VALUES ($1, $2) ON CONFLICT DO NOTHING


2019-11-22 13:18:19.519 UTC [589] ERROR:  current transaction is aborted, commands ignored until end of transaction block


2019-11-22 13:18:19.519 UTC [589] STATEMENT:  SELECT id FROM tag WHERE name = $1


2019-11-22 13:19:51.411 UTC [589] ERROR:  insert or update on table "bookmark_tag" violates foreign key constraint "bookmark_tag_bookmark_id_fk"


2019-11-22 13:19:51.411 UTC [589] DETAIL:  Key (bookmark_id)=(24) is not present in table "bookmark".


2019-11-22 13:19:51.411 UTC [589] STATEMENT:  INSERT INTO bookmark_tag


			(tag_id, bookmark_id) VALUES ($1, $2) ON CONFLICT DO NOTHING


2019-11-22 13:19:51.412 UTC [589] ERROR:  current transaction is aborted, commands ignored until end of transaction block


2019-11-22 13:19:51.412 UTC [589] STATEMENT:  SELECT id FROM tag WHERE name = $1

What am I doing wrong?

The last issue I see about finding the bookmarklet is #100 . Since then the UI has changed and the about screen is no longer shown. Where is the bookmarklet now or has it been superseded by the chrome extension?

Hello,

Here a new PR for ldap authentication on your latest branch and without the config part.

All settings are given via environment vars.

I also added a docker-compose as an example with all env vars and a postgresql.

Regards,

Hello,

I would like to contribute to add ldap auth support in your project.

@RadhiFadlillah do you plan to merge soon your ramadhan branch, if not I'll do a PR into this branch ?

I'll need to add a some config options (ldap server, port, tls, search string, ...) I think a shiori.toml file should be a fine solution.

Regards

I've created my own systemd service file with the following security settings in the [service] section:

CapabilityBoundingSet=CAP_NET_BIND_SERVICE
RestrictNamespaces=true
NoNewPrivileges=true
PrivateTmp=true
ProtectClock=true
ProtectKernelModules=true
ProtectProc=noaccess
ProtectHostname=true
RestrictRealtime=true
SystemCallArchitectures=native

SystemCallFilter=~@clock
SystemCallFilter=~@debug
SystemCallFilter=~@module
SystemCallFilter=~@mount
SystemCallFilter=~@raw-io
SystemCallFilter=~@reboot
SystemCallFilter=~@privileged
SystemCallFilter=~@resources

SystemCallFilter=~@cpu-emulation
SystemCallFilter=~@obsolete

LockPersonality=true

MemoryDenyWriteExecute=true

UMask=0077

PrivateDevices=true
ProtectControlGroups=true
ProtectKernelTunables=true
ProtectSystem=full
RestrictSUIDSGID=true

I'm using the binary directly (so no docker). I am also not using --portable (not on purpose, just forgot to add it).

I think when using --portable, ProtectHome=true can be added as well.

I did not found a .service file in the code, just a snippet in the wiki. I created this issue, because I didn't want to add any changes in the wiki without prior discussion.

I just tried adding a bookmark for a Medium article and noticed the images were imported into Shiori at an atrocious quality:

I'm guessing this is because Medium will lazy-load the higher-resolution copies with JS, but the Shiori importer doesn't wait around for that. That's my best guess anyways. Inspecting the Medium page source, I see that the images have a noscript tag near 'em with he full-quality version of the image... perhaps that could be useful when importing?

Think this is fixable?

Bumps goreleaser/goreleaser-action from 3 to 4.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Starting shiori like shiori serve -a 127.0.0.1 --log true i can specify what is logged but not which level (info,warn,debug....) It would be nice to reduce the loglevel to eg. warn by having a possibility like shiori serve -a 127.0.0.1 --log true --loglevel warn

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps github.com/go-sql-driver/mysql from 1.6.0 to 1.7.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Shiori 1.5.3 on Windows 7 x64.

At present the app uses custom font with Latin script support only. To be specific: /css/fonts/source-sans-pro-v13-latin-700.woff2 And what do others see when they use letters out of Latin scope? The eyesore.

Either use font with wide scripts support (e.g. Noto Sans) or let system/user decide.