I found that in a bad network environment, sendReceive lost the packet and did not respond, which caused the "http.Transport" process to permanently block in "Dial". So I set the default timeout for sendReceive.

In addition, support for authentication has been added.

For some reason code got freeze on method

func readAll(conn net.Conn) (resp []byte, err error)

I tested my proxy, and also bunch of others - same result. Here is my code:

package main

import (
    "h12.me/socks"
    "log"
)

func main() {
    server := "x.x.x.x:9999"
    proxyServer := "x.x.x.x:8888" // TinyProxy, Socks5

    f := socks.DialSocksProxy(socks.SOCKS5, proxyServer)

    conn, err := f("tcp", server)

    if err != nil {
        log.Println("err", err)
    }
    conn.Write([]byte("Hello")) # This line is never reached
    defer conn.Close()
}

Any ideas? Thanks.

Hello, I've faced with an issue when timeout param doesn't work with fasthttp client. Here is my func which i pass as an field Dial to the fasthttp.Client

func(addr string) (net.Conn, error) {
			dialer := socks.Dial(proxyAddr + "?timeout=4s")
			return dialer("tcp", addr)
		}

and prepare the client:

fasthttp.Client{
		Dial: prepareProxy(proxy),
	}

I must admit that with a valid proxy it works

Hello,

Please consider supporting Go Modules, the new packaging standard that will be adopted fully in Go 1.12. Experimental support is in Go 1.11 and the go.mod file is supported in Go 1.9.7+ and Go 1.10.3+ in a read-only manner for backwards compatibility with all supported versions of Go.

Because this library has no external dependencies and is still below version 2, the go.mod file is fairly simple. The only other thing that would need to be done is to create a semver compatible tag after this patch is merged (eg. v1.0.1) to allow other things to pin to that version without having to use the special commit-based version string.

Thank you for your consideration.

hi. root@wh:~/go/gopath# go get -u -v github.com/h12w/socks github.com/h12w/socks (download) package github.com/h12w/socks: code in directory /root/go/gopath/src/github.com/h12w/socks expects import "h12.io/socks" root@wh:~/go/gopath#

how to fix it?

guru@dirtydeeds:~$ go get -u h12.me/socks# cd .; git clone https://h12.me/socks /home/guru/workspace/go/src/h12.me/socks
Cloning into '/home/guru/workspace/go/src/h12.me/socks'...
fatal: unable to access 'https://h12.me/socks/': gnutls_handshake() failed: Handshake failed
package h12.me/socks: exit status 128

Fix for error index out of bounds.

panic: runtime error: index out of range

goroutine 46 [running]: h12.me/socks.dialSocks4(0x0, 0x187f68e0, 0x10, 0x187f6b20, 0x10, 0xb6b91588, 0x1880e080, 0xb6b8c018, 0x1880e188) /root/go/src/h12.me/socks/socks.go:161 +0x982 h12.me/socks.DialSocksProxy.func2(0x8379b4c, 0x3, 0x187f6b20, 0x10, 0x0, 0x0, 0x0, 0x0) /root/go/src/h12.me/socks/socks.go:69 +0x60 net/http.(_Transport).dial(0x187598f0, 0x8379b4c, 0x3, 0x187f6b20, 0x10, 0x0, 0x0, 0x0, 0x0) /usr/lib/go/src/net/http/transport.go:499 +0x68 net/http.(_Transport).dialConn(0x187598f0, 0x0, 0x83b0f20, 0x4, 0x187f6b20, 0x10, 0x0, 0x0, 0x0) /usr/lib/go/src/net/http/transport.go:596 +0x1619 net/http.(_Transport).getConn.func4(0x187598f0, 0x0, 0x83b0f20, 0x4, 0x187f6b20, 0x10, 0x187fc140) /usr/lib/go/src/net/http/transport.go:549 +0x4d created by net/http.(_Transport).getConn /usr/lib/go/src/net/http/transport.go:551 +0x20d

replaces the buggy https://github.com/hailiang/socks/pull/3

import "magic" comment goes next to the package declaration: package socks // import "h12.me/socks"

import comment as described in https://golang.org/s/go14customimport

This would be consistent with README.md https://github.com/hailiang/socks#import-the-package declaring that the import path is "h12.me/socks" (and not "github.com/hailiang/socks"). The change will help to avoid confusion regarding under which import path the package should be included and potentially the package being linked under two different import paths (through transitive dependencies, etc.)

This will break builds of clients still using "github.com/hailiang/socks" but on the other hand will inform them about the canonical import path for the package.

https://github.com/h12w/socks/blob/4d67a7057a35e9e22aba15c7716a673c00e62339/net.go#L46

func lookupIP(host string) (net.IP, error) {
	ips, err := net.LookupIP(host)
	if err != nil {
		return nil, err
	}
	if len(ips) == 0 {
		return nil, fmt.Errorf("cannot resolve host: %s", host)
	}

	for _, ip := range ips {
		ip4 := ip.To4()
		if len(ip4) != net.IPv4len {
			continue
		}
		return ip4, nil
	}

	return nil, fmt.Errorf("no ipv4 address found for host: %s", host)
}

2020/06/20 13:36:12 Get "https://www.google.com": net/http: Transport.Dial hook returned (nil, nil) 2020/06/20 13:36:55 Get "https://www.google.com": EOF

Worker proxies, sample code used

dialSocksProxy := socks.Dial("socks4://45.129.201.209:4145") tr := &http.Transport{Dial: dialSocksProxy} httpClient := &http.Client{Transport: tr} resp, err := httpClient.Get("https://www.google.com") if err != nil { log.Fatal(err) } defer resp.Body.Close() if resp.StatusCode != http.StatusOK { log.Fatal(resp.StatusCode) } buf, err := ioutil.ReadAll(resp.Body) if err != nil { log.Fatal(err) } fmt.Println(string(buf))

https://datatracker.ietf.org/doc/html/rfc1928

I think it makes sense to implement a UDP association to be able to proxy UDP packets

If you do not plan to add this feature, I can later add a pull request with my implementation