Added conform of maps of string types in the same manner as slices of string types are handled. Respective unit tests were added to cover the new code.

I was exploring the solution can help to redact sensitive data from a struct. I realize to use conform as a generic solution probably the best. This addition is simply to transform field to REDACTED if it has the tag. Check the example in _test.go file :)

Hi There,

I've noticed that when conforming names with apostrophes, not only will the apostrophe be stripped, but the rest of the name.

Expected: D'Addario

Got: D

@gislik in https://github.com/leebenson/conform/pull/17 wrote:

Since no object is instantiated the code is not type-safe, i.e. two thread may try to add sanitizers at the same time resulting in a corrupt state.

Can we instantiate an object?

Can we use it like:

func main() {
  sanitizer := conform.New()
  conform.AddSanitizer(customOne)

  sanitizer.String(...)
}

Why not?

We're using dependency injection everywhere...

Hi,

Look likes conform won t apply on array of strings, unless i did wrong.

type NewInput struct {
    Tags        []string `form:"tags[]" validate:"dive,min=1" conform:"trim"`
}
func (e EndPoints) HandleForm(c *gin.Context) {

  var input NewInput

  c.Bind(&input)

  conform.Strings(&input)

  fmt.Printf("%q\n", input)
  fmt.Printf("%q\n", input.Tags)
}

curl -D - -d "tags[]=1&tags[]=  " http://localhost:8080/form

yields

{["1" "  "]}
["1" "  "]

Anyways to make that happen ?

It seems like non-string slices are trying to be conformed. I am on version 1.2.2

type Test struct {
	Title      string                `json:"test" conform:"trim"`
	Statuses []int64 `json:"statuses"`
}

I am getting: reflect.Value.Convert: value of type string cannot be converted to int64

I made the minimum amount of changes needed to implement custom sanitizers.

Since no object is instantiated the code is not type-safe, i.e. two thread may try to add sanitizers at the same time resulting in a corrupt state.

Conform was choking on a field in a struct which has a type of []byte.

The problem was in the recursive Strings method in which reflection is used to figure out the number of fields in a struct. In this edge case the []byte was passed in a recursive walk of the struct which resulted in a panic when calling ift.NumFields().

This is documented here:

NumField returns the number of fields in the struct v. It panics if v's Kind is not Struct.

My solution is to return early in case the reflected variable is not a struct.

Thank you for your work!

The local part must preserve case, the domain part is lowercased. When supplied with a string containing multiple @s, treat the last @ as the local part/domain part separator.

The conformatiy for email is wrong as just does an lower(). Because the email addresses [email protected], [email protected], and [email protected] are three different email address according to the RFC and as implemented by many email servers. While case in the domain part does not matter, case in the name part does matter. Also spaces and all weired stuff is allowed if it is escaped or quoted.

The README stated:

Trims and lowercases the string. Example: "[email protected] " -> "[email protected]"

But it actually only lowercase the domain part.. which means it actually become [email protected] instead of [email protected]

I wonder what is the correct behaviour...

Add a length check when reading "conform" tags, if length == 0 (<=0) then just ignore the field. This minor change should be enough to fix the problem. Also this is consistent with the original design concept

Password  string    `schema:"password"`    // <-- no tag? no change

I always get a panic when my struct has the similar structure as below, here's a minimal example

package main

import (
	"github.com/leebenson/conform"
	"log"
)

type Child struct {
	ChildName string `conform:"trim"`
	Numbers   []uint64
}

type Parent struct {
	Child *Child
}

func main() {
	child := Child{
		ChildName: "   child   ",
		Numbers:   []uint64{1, 2, 3},
	}
	parent := Parent{
		Child: &child,
	}
	if err := conform.Strings(&parent); err != nil {
		log.Println(err)
	} else {
		log.Println(*parent.Child)
	}
}

output:

panic: reflect.Value.Convert: value of type string cannot be converted to type uint64

possible fix

conform.go:243

if elType.ConvertibleTo(reflect.TypeOf(str)) || elType.ConvertibleTo(reflect.TypeOf(&str)) {

change to

if elType == reflect.TypeOf(str) || elType == reflect.TypeOf(&str) {

output:

2022/12/06 22:11:56 {child [1 2 3]}

I might try to make a pr to fix it later, any help or explanation is appreciated, thanks in advance!

hi, i got a problem when pass a struct which have an slice of int member, here is the test code below: `package main

import ( "github.com/leebenson/conform" )

type UserForm struct { Age []int }

func main() { input := UserForm{ Age: []int{1}, } conform.Strings(&input) // panic } ` and below is panic info:

Hello guys,

Im trying to implement your code but I have some issues with it.

In the case I have substruct or slice of substruct, the lib is not working.

type Request struct {
    SeveralSubRequests []*struct {
	Foo  string `json:"foo" conform:"trim"`
	Bar  string `json:"bar" conform:"trim"`
    } `json:"several_sub_requests"`
}

type Request struct {
    SubRequest *struct {
        Foo  string `json:"foo" conform:"trim"`
        Bar  string `json:"bar" conform:"trim"`
    } `json:"sub_request"`
}