Just tried to run aminal-linux-amd64 from releases, and got:

1.543406135031648e+09 info aminal/main.go:28 Allocating pty... 1.5434061350458617e+09 info aminal/main.go:56 Creating terminal... 1.5434061356787918e+09 fatal aminal/main.go:64 Render error: Failed to create window: Failed to create window: VersionUnavailable: GLX: Failed to create context: GLXBadFBConfig main.main /go/src/github.com/liamg/aminal/main.go:64 runtime.main /usr/local/go/src/runtime/proc.go:201

On Fedora 29, xorg+radeon. Is something wrong with my system?

Thank you.

Is your feature request related to a problem? Please describe. Every user will have their own keybinding wants and needs.

Describe the solution you'd like Minimum: ability to configure key bindings in a config file, using AutoHotKey's syntax would be familiar to some of this. Would be nice to configure these through a GUI, PyCharm and the other JetBrains editors have done this really nicely and if we could mimic their methods, that would be fantastic.

Describe alternatives you've considered I'd use AutoHotKey to work around stuff, but that becomes trickier if the keybindings Aminal has chosen don't line up with those of other Windows apps that I'm working around.

Additional context See the following tickets that rely on keybindings which would need to be configurable: https://github.com/liamg/aminal/issues/196 https://github.com/liamg/aminal/issues/217 https://github.com/liamg/aminal/issues/195

Description

This PR adds a vertical scrollbar to the Aminal window. Also, there is a new configuration parameter, show_vertical_scrollbar, which is true by default. The scrollbar supports common functions:

• clicking on top and bottom arrows scrolls one line up or down, correspondingly
• clicking on space between the thumb and top or bottom arrows scrolls one page up or down, correspondingly
• dragging the thumb with the left mouse button scrolls the screen

Notes

• On hi-res displays it should scale accordingly (but needs to test because I don't have one).
• Also this PR changes Travis settings so that now gofmt checks are performed for Go1.11.x (most recent version) builds.

Fixes #89 and #154

Type of change

• [X] New feature (non-breaking change which adds functionality)

Describe the bug On running aminal, i recieve the following error:

1.540306868124171e+09   error   terminal/output.go:96   Error handling escape sequence: Unknown OSC control sequence: 1;../liamg/aminal
github.com/liamg/aminal/terminal.(*Terminal).processInput

To Reproduce Steps to reproduce the behavior:

1. run ./aminal
2. See error

Expected behavior There should be no errors on running

Environment (please complete the following information):

• macOS Mojave 10.14
• go version go1.11 darwin/amd64

Describe the bug ctrl+C often does not interrupt a long running command that produces output

To Reproduce Steps to reproduce the behavior:

1. SSH to a box. Boxes that are further away (e.g. across an Ocean, ~100ms) will make this more obvious
2. Run a command that generates a lot of output (ls -l a directory with many files, cat a file, etc.)
3. Type Ctrl+C
4. Observe that it does not quickly stop printing output. (Compare with something like putty)

Expected behavior Pressing ctrl+C should interrupt the output

Is your feature request related to a problem? Please describe. A really valuable feature for me on macOS Terminal is using Apple-k to clear the terminal and its scrollback buffer. This is particularly helpful for repeated runs of commands that generate a lot of output, to avoid getting confused between the output of two or more runs.

Describe the solution you'd like Windows-k (but configurably bound) to totally clear the window and buffer and leave me with a fresh prompt.

Describe alternatives you've considered

None, really.

Additional context

None.

Describe the bug

Backspace doesn't work when zsh is in use.

To Reproduce Steps to reproduce the behavior:

1. Run aminal with the shell set to zsh.
2. Type some text.
3. Hit backspace.
4. Text is not removed.
5. Close aminal.
6. Run aminal with the shell set to bash.
7. Type some text.
8. Hit backspace.
9. Text is removed.

Backspace in zsh works fine with gnome-terminal on the same machine.

Expected behavior

Text to should be removed when backspace is used with zsh.

Environment (please complete the following information):

• OS + Version: Ubuntu 16.04
• Go Version - 1.11.5
• Shell - zsh 5.1.1

Logs

aminal --debug produces logs but there are no logs generated when backspace is pressed.

Pull Request Template

Description

As for me it's much better then moving window at one pixel

(Based on the https://github.com/Noofbiz/glfwMojaveFix)

Fixes #108

Type of change

Please delete options that are not relevant.

• [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• [x] Run aminal look at window content it should be appeared istead of black screen

Test Configuration:

• OS: macOS
• OS version: 10.14.1
• Go version: 1.11.2

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [ ] Any dependent changes have been merged and published in downstream modules

Description

Prevents data races and does better cursor rendering on fast input (#223)

Fixes # 230

Type of change

• [ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Go's race detector will show the races in question. Run go test -race -v . in the root of the project source. There should be no data races.

Test Configuration:

• OS: Ubuntu
• OS version: 18.04
• Go version: 1.10.4

Pull Request Template

Description

Correctly handles most of the screens of vttest test 1

Fixes #120

Type of change

Please delete options that are not relevant.

• [ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Run vttest. Run test 1 (cursor movements)

Test Configuration:

• OS: Ubuntu
• OS version: 18.04
• Go version: 1.11

Checklist:

• [ ] My code follows the style guidelines of this project
• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes

Description

Pressing 'Alt' would make the selection region rectangular

Fixes # 217

Type of change

• [ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Start selection with mouse. Press left 'Alt'. The selection region becomes rectangular

Test Configuration:

• OS: Windows
• OS version: 1809
• Go version: 1.10.4

When attempting to update darktile from 0.0.10 to 0.0.11, I discovered that it could no longer be built on 32 bit architectures. You can see the build failures in this PR: https://github.com/void-linux/void-packages/pull/37096. I couldn't actually determine where the error is coming from, and none of the code changes in between the versions seem like they'd cause the failure.

They Pos1 and End keys are not working. I would expect them to jump to the beginning and end of the line as any other terminal. Also common key combinations like Ctrl+d are missing

As reported by @dankamongmen here: https://nvd.nist.gov/vuln/detail/CVE-2022-24130 , a large repeat count within a sixel sequence can cause a crash, either from buffer under/overflow or out of memory. darktile version 0.0.10 instantly hangs trying to allocate memory until the oomkiller steps in.

https://www.openwall.com/lists/oss-security/2022/01/30/3 has a nice test script:

#!/bin/bash
printf "\ePq"
printf "#%hhu;2;%hhu;%hhu;%hhu" 0x41 100 100 100
printf "#%hhu!%u@" 0x41 0x7fffffff
printf "#%hhu!%u@" 0x41 0x7fffffff
printf "\e\\"

Some additional discussion with other terminals is here: https://gitlab.com/klamonte/jexer/-/issues/105

On the 0.0.10 release binary, cat'ing https://jexer.sourceforge.io/sixel/sixel_6x13.cap caused darktile to crash. There are a few sixel tests on that page at different resolutions, and also some sixels with transparency if you would like to test that.

I also saw a pegged CPU and unresponsive output when trying an animation. I loaded up flame.gif, it ran for a bit, but then CPU started spiking and I eventually had to kill it from another terminal. Here is what it was supposed to behave like.