I know this is a design decision, but I feel that it should be more like go. It seems less intuitive to have something written in go, for go, that looks like ruby simply because it was inspired by a ruby tool.

Hi @mattn

I noticed that using go1.6, gom install places all vendor packages in a vendor folder (rather than _vendor), which I understand it's now the Go1.6 default location.

Within the vendor folder, gom places my all the vendor modules outside the src directory, which is not created anymore. When I try to build my go project, an error is thrown since go expects my vendor modules to live in vendor/src/github.com/etc rather than vendor/github.com/etc

Is this an issue with gom, go1.6 or my current set up?

Thanks!

Hello. @mattun @h3poteto

Vendoring could not work in my project. I got this package(gom) and built my project today.

I think that this fix may be inappropriate. https://github.com/mattn/gom/pull/81

When did vendoring behavior change? I could not find this release note. If you can, I would like to teach me. https://blog.golang.org/go1.7

Sincerely,

-- detail Using version is 1.7.3

GOPATH setting

GOPATH=/path/to/project:/path/to/project/lib

Error sample

app/app.go:26:2: cannot find package "github.com/labstack/echo" in any of:
    /path/to/project/src/vendor/github.com/labstack/echo (vendor tree)
    /usr/local/go/src/github.com/labstack/echo (from $GOROOT)
    /path/to/project/src/github.com/labstack/echo (from $GOPATH)
    /path/to/project/lib/src/github.com/labstack/echo

--

英語だと説明不足感があるので日本語で補足します。 下記バージョンだと、Go1.7.3の環境においてvendor/でビルドできました。 https://github.com/mattn/gom/commit/393e714d663c35e121a47fec32964c44a630219b

プルリクエスト（#81）のエラーを見ていると、vendor treeに関するエラー表示がないため、 build/install時にvendorへの参照がおこなわれていないのではないかと思います。 （おそらくGOPATHにvendorが含まれている）

確認いただけると、助かります。 よろしくお願いします。

I think, there is bug in gom/gen.go

        if isDir(filepath.Join(p, ".git")) {
            vcs = git
        } 

Gomfile:

gom 'github.com/aws/aws-sdk-go/aws'
gom 'github.com/aws/aws-sdk-go/aws/awserr'
gom 'github.com/aws/aws-sdk-go/aws/awsutil'
gom 'github.com/aws/aws-sdk-go/aws/client'
gom 'github.com/aws/aws-sdk-go/aws/client/metadata'
gom 'github.com/aws/aws-sdk-go/aws/corehandlers'
gom 'github.com/aws/aws-sdk-go/aws/credentials'
gom 'github.com/aws/aws-sdk-go/aws/credentials/ec2rolecreds'
gom 'github.com/aws/aws-sdk-go/aws/defaults'
gom 'github.com/aws/aws-sdk-go/aws/ec2metadata'
gom 'github.com/aws/aws-sdk-go/aws/request'
gom 'github.com/aws/aws-sdk-go/aws/session'
gom 'github.com/aws/aws-sdk-go/private/endpoints'
gom 'github.com/aws/aws-sdk-go/private/protocol/query'
gom 'github.com/aws/aws-sdk-go/private/protocol/query/queryutil'
gom 'github.com/aws/aws-sdk-go/private/protocol/rest'
gom 'github.com/aws/aws-sdk-go/private/protocol/xml/xmlutil'
gom 'github.com/aws/aws-sdk-go/private/signer/v4'
gom 'github.com/aws/aws-sdk-go/service/sns'

but .git dir is only on level https://github.com/aws/aws-sdk-go/.

% go version
go version go1.6.3 linux/amd64
% echo $GO15VENDOREXPERIMENT
0
% gom install
downloading github.com/mattn/gover
downloading github.com/hashicorp/go-version
downloading github.com/daviddengcn/go-colortext
gom:  open /home/syohei/go/src/github.com/mattn/gom/_vendor/src: no such file or directory
% echo $?
1

https://github.com/mattn/gom/issues/66

Add ignore package

ignore ex)
github.com/hoge/fuga/examples
github.com/hoge/fuga/examples/hoga
github.com/foo/bar/_test
github.com/foo/bar/_test/baz

In node.js package manager npm, I can do

npm install --save koa
npm install --save-dev should.js

It will add dependencies to package.json automatically. It will be very cool if gom can install and then add dependencies to Gomfile.

gom install --save github.com/mattn/gom
gom install --save-dev  github.com/xxxx/testing/assert

go tools ignore filenames that start with _ (and .). With current name of vendor subdirectory command go test ./... if run in repository root would go inside vendor subdirectory, find packages there and launch tests, which is usually not desired. The same applies to gom test ./... of course, and things like go tool vet.

If vendor is renamed to _vendor, this should make ./... work as expected again.

I can submit pull request if it sounds ok. Probably this could be configured in Gomfile?

Hi,

I'm trying gom, but I found a weird error. If I have already installed a package with go install (for example github.com/jrallison/go-workers), and then I create a Gomfile with:

gom 'github.com/jrallison/go-workers', :commit => 'f9540adf4c3635a54663b9c55671b54de77d19fc'

If I run gom install, it fails with a weird error:

$ gom install
installing github.com/jrallison/go-workers
gom:  gom currently support git/hg for specifying tag/branch/commit

And vendor/ remains empty.

Greetings! I have a use case that would require using various groups in my Gomfile. The logic for environments and groups is very similar, but I need more than three options. For example, depending on os/go versions, Travis builds seem to fail if we try to fetch tools from the new urls (golang.org/x), but we don't want to overload "test" and "development" to specify these build differences.

This PR suggests a solution using custom group names in addition to the three environments. This would allow many new combinations of Goms by specifying one or more groups in the install command. e.g.

$ gom install -test -groups=test_golang_org

# fetches from golang.org
group :test_golang_org do
  gom 'golang.org/x/tools/cmd/vet'
  gom 'golang.org/x/tools/cmd/cover'
end

# fetches from code.google.com
group :test_google_com do
  gom 'code.google.com/p/go.tools/cmd/vet'
  gom 'code.google.com/p/go.tools/cmd/cover'
end

group :test do
  gom 'gopkg.in/check.v1'
  gom 'github.com/golang/lint/golint'
  gom 'github.com/onsi/ginkgo/ginkgo'
  gom 'github.com/onsi/gomega'
end

Please let me know what you think. Thanks!

@mattn Go 1.6 supports vendoring by default, so GO15VENDOREXPERIMENT env should not be required to use vendor/ directory.

Previously, gom uses _vendor/ directory even with Go version is 1.6+. See: http://akirachiku.com/2016/03/01/go16-development.html#vendoring (Japanese)

gom should use vendor/ directory with Go 1.6+ by default. But when GO15VENDOREXPERIMENT=0 is explicitly set with Go <= 1.6 && >1.7 , gom should use _vendor/ (or GOM_VENDOR_NAME when it's set) because vendoring is not supported by Go itself.

Quote from https://golang.org/doc/go1.6#go_command :

Go 1.5 introduced experimental support for vendoring, enabled by setting the GO15VENDOREXPERIMENT environment variable to 1. Go 1.6 keeps the vendoring support, no longer considered experimental, and enables it by default. It can be disabled explicitly by setting the GO15VENDOREXPERIMENT environment variable to 0. Go 1.7 will remove support for the environment variable.

When I run gom gen gomfile, it does not generate the dependencies of the subdirectories, while go get does download dependencies of them. No error was occurred.

Is it intended or a bug?

gom file:

gom 'git.xxx.com/xx/pfsdk', :command => 'git clone [email protected]:xx/pfsdk'

First time i exec gom install ,it works fine, but i exec it again ,it report an error: fatal: destination path '/path/to/_vendor/src/git.xxx.com/xx/pfsdk' already exists and is not an empty directory

I use gom mostly for use our mirrored repository. for example (since Iran's firewall blocked bitbucket.org for any reason that I don't know and can't understand) we mirror the goose repository in a locally installed gitlab repository (go get can not understand gitlab :/ ). now this line :

gom 'bitbucket.org/liamstask/goose/cmd/goose', :command => 'git clone http://example.com/mirrors/goose.git'

is not working. its clone the repo inside the src/bitbucket.org/liamstask/goose/cmd/goose which is not correct. Also this :

gom 'bitbucket.org/liamstask/goose', :command => 'git clone http://example.com/mirrors/goose.git'

Is failed. since there is no go file in root of this repository. (this repository is just an example, and we have this problem with some other repository too)

Is there anything I can do to fix this? any hack or even a feature that I can implement, please let me know.

Thanks.