Hello,

(upvote this https://github.com/microsoft/playwright/issues/6856 instead)

since I've joined @Microsoft we are considering moving this package over to the organisation. By that we would ensure that all features form the original Playwright project are integrate and bugs are fixed. Currently since it was a private project it got unfortunately not that much attention since my time was limited. For that we are currently evaluating what the use-cases are and how many people in which scenarios are using it.

Would be awesome if you could give us some feedback so you could help us with the decision. In more detail, answer the following questions:

• For what are you using Playwright for Go?
• Are you using it for personal use or in a company?
• Do you have any future plans to extend the usage in the future?
• Do you have any suggestions in terms of API design and if something should be changed for version 1.0?
• What other libraries did you consider instead of Playwright for Go?
• Where do you run it? e.g. Docker, Kubernetes, as a script etc.

Thank you!

(Thumbs up if you are interested in it)

This is issue might relates to #141

The following is an example to reproduce this bug.

package main

import (
	"fmt"
	"log"
	"time"

	"github.com/mxschmitt/playwright-go"
)

func main() {
	pw, err := playwright.Run()
	if err != nil {
		log.Fatalf("could not start playwright: %v", err)
	}
	browser, err := pw.Chromium.Launch(playwright.BrowserTypeLaunchOptions{Headless: playwright.Bool(false)})
	if err != nil {
		log.Fatalf("could not launch browser: %v", err)
	}
	page, err := browser.NewPage()
	if err != nil {
		log.Fatalf("could not create page: %v", err)
	}
	eventsChan := make(chan string)
	go func(eventsChan chan string) {
		for c := range eventsChan {
			fmt.Println(c)
		}
	}(eventsChan)
	page.On("response", func(response playwright.Response) {
		// the following code block causes the problem
		// body, err := response.Body()
		// if err != nil {
		// 	log.Fatalf("get body failed: %v", err)
		// }
		// fmt.Println("body len: ", len(body))

		eventsChan <- fmt.Sprintf("%d %s", response.Status(), response.URL())
	})
	if _, err = page.Goto("https://news.ycombinator.com"); err != nil {
		log.Fatalf("could not goto: %v", err)
	}

	time.Sleep(3 * time.Second)
	if err = browser.Close(); err != nil {
		log.Fatalf("could not close browser: %v", err)
	}
	if err = pw.Stop(); err != nil {
		log.Fatalf("could not stop Playwright: %v", err)
	}
}

Tested version go.mod

go 1.16

require github.com/mxschmitt/playwright-go v0.1100.0 // indirect

@kumaraditya303 Thanks for your great work and all your contributions to this repository. For your commit "roll to 1.14" that matches the latest version of Playwright, do you have any plan to version it or publish the release?

Hello, thanks for the lib It works great! I faced with some limitations:

• I would like to avoid downloading https://github.com/mxschmitt/playwright-go/blob/c9d1531e0354a7f267237b3ac55595a8f18170e4/run.go#L29 after every container start. I assumed that playwright is already installed on the official mcr.microsoft.com/playwright:bionic images.

• It looks like that playwright is installed from an external source https://github.com/mxschmitt/playwright-go/blob/c9d1531e0354a7f267237b3ac55595a8f18170e4/run.go#L15 not the official ones.

• How can I install a different playwright version? The current is 1.7

BrowserContext in this example: https://playwright.dev/docs/chrome-extensions/ (from JavaScript) supports "backgroundPages", a way to get handles on extensions.

Is this supported in Playwright? It isn't from what I can see at the moment from examining the "Generated structs".

Do you know if this will get added or if there are plans for it to be added?

Many thanks & appreciate your work, Neil

Hi, I can't see the type definition of the page errors. For example:

page, _ := browserContext.NewPage()
page.Once("pageerror", func(err ???) {
	c.Logger().Errorf("an error on the page was detected: %s", err)
})

I also recommend using custom function types e.g

type RequestFailedEventHandler = func(request *Request)

Hi,

We are getting a fatal panic when going to a specific site, that we didn't get on v0.1400.0 Release, and also a commit version after that specified below.

Latest commit tested that did not have this issue: 7e45483

All commits we test that are after this commit, we end up with a fatal panic, which did not happen on the same site prior to this. A big difference I can see is that you go from Playwright 1.14.1 -> 1.16.0-next.. So maybe the problem is there?

Here is the full panic message:

events.js:377
      throw er; // Unhandled 'error' event
      ^

Error: EPIPE: broken pipe, write
    at Socket._write (internal/net.js:55:25)
    at writeOrBuffer (internal/streams/writable.js:358:12)
    at Socket.Writable.write (internal/streams/writable.js:303:10)
    at Transport.send (C:\Users\osterman01\AppData\Local\ms-playwright-go\1.16.0-next-1631944242000\package\lib\protocol\transport.js:54:21)
    at DispatcherConnection.dispatcherConnection.onmessage (C:\Users\osterman01\AppData\Local\ms-playwright-go\1.16.0-next-1631944242000\package\lib\cli\driver.js:67:57)
    at DispatcherConnection.sendMessageToClient (C:\Users\osterman01\AppData\Local\ms-playwright-go\1.16.0-next-1631944242000\package\lib\dispatchers\dispatcher.js:186:10)
    at BrowserContextDispatcher._dispatchEvent (C:\Users\osterman01\AppData\Local\ms-playwright-go\1.16.0-next-1631944242000\package\lib\dispatchers\dispatcher.js:108:22)
    at CRBrowserContext.<anonymous> (C:\Users\osterman01\AppData\Local\ms-playwright-go\1.16.0-next-1631944242000\package\lib\dispatchers\browserContextDispatcher.js:102:81)
    at CRBrowserContext.emit (events.js:400:28)
    at FrameManager.requestReceivedResponse (C:\Users\osterman01\AppData\Local\ms-playwright-go\1.16.0-next-1631944242000\package\lib\server\frames.js:295:32)
Emitted 'error' event on Socket instance at:
    at emitErrorNT (internal/streams/destroy.js:106:8)
    at errorOrDestroy (internal/streams/destroy.js:168:7)
    at onwriteError (internal/streams/writable.js:391:3)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
    at runNextTicks (internal/process/task_queues.js:64:3)
    at processImmediate (internal/timers.js:437:9) {
  errno: -4047,
  syscall: 'write',
  code: 'EPIPE'
}

Debugger finished with the exit code 0

Current report (node scripts/validate-interfaces.js):

Missing API interface functions:

• [x] BrowserContext.SetHTTPCredentials
• [x] BrowserContext.StorageState
• [x] ElementHandle.WaitForElementState
• [x] ElementHandle.WaitForSelector

I noticed that in the current master branch it was always downloading the driver. I found the issue, in PlaywrightDriver.isUpToDateDriver It's checking the output of PW, for example:

/Users/sam/Library/Caches/ms-playwright-go/1.16.0-next-1634703014000/playwright.sh --version
Version 1.16.0-next

With the constant:

const playwrightCliVersion = "1.16.0-next-1634703014000"

Using:

	if bytes.Contains(output, []byte(d.Version)) {
		return true, nil
	}

The extra -1634703014000 on the constant is the issue. I've fixed it locally by adding this to the end of isUpToDateDriver:

	if strings.HasPrefix(string(output), "Version ") {
		// Get rid of trailing new line
		outputStr := strings.TrimSpace(string(output))
		if len(outputStr) > 8 && strings.Contains(d.Version, outputStr[8:]) {
			return true, nil
		}
	}

I'll submit a PR with the change.

If you have any suggestions for changes I'm happy to change.

• [ ] fix that there is XML in the doc comments -> it should not be there (was not correct since a few months)
• [x] fix that there are csharp examples in the generated_interfaces.go
• [x] Re-introduce EmulateMedia

Thanks for this great library and your hardwork to make it great.

From https://pkg.go.dev/github.com/mxschmitt/playwright-go#pkg-index, the methods show out if the type is struct(like Playwright):

type Playwright
    func Run(options ...*RunOptions) (*Playwright, error)
    func (c *Playwright) Dispose()
    func (p *Playwright) Stop() error

But No method shows out if the type is defined as interface(like Page), we need to go to the type definition to find the available methods.

type Page

Is it possible to define the Page as struct?

type Page struct {
    // non export fields
}

func (*Page) Click(selector string, options ...PageClickOptions) error
func (*Page) Fill(selector, text string, options ...FrameFillOptions) error
... ...

What do you think about it? Thanks.

Is there any way to make browser stay open after a test is finished? （Chromium MacOS ARM version） Even i use page.Pause() or other WaitFor method, browser still auto close after about 1 min.

Update: use local Chrome or Edge on MacOS ARM will NOT auto close. Also chromium works fine on Windows. it may some kind of bug on Chromium MacOS arm version.

I wirte an go function to waiting some api responsed and then to do something,here is my code

func waitResponse(dashboardIds []int, page playwright.Page) {
	responses := [5]playwright.Response{}
	wg := sync.WaitGroup{}
	baseUrl := "https://example.com"
	for index, v := range dashboardIds {
		wg.Add(1)
		url := fmt.Sprintf("%s/%d?dashboard_id=114", baseUrl, v)
		idx := index
		v := v
		go func() {
			log.Printf("start request %s\n", url) // 1
			response := page.WaitForResponse(url)
			log.Printf("goroutine get response from %s, index is %d\n", url,idx) // 2
			resBody, _ := response.Body()
			responses[idx] = response
			defer wg.Done()
		}()
		page.On("response", func(res playwright.Response) {
			if res.URL() == url {
				log.Printf("listen get response from %s", url) //3
			}
		})
	}
	wg.Wait()
	log.Printf("all url responded") // 4
}

after run this function,I find 1、3 print every time,but 2 is only print one time(idx is 0), is there something wrong in my code?pls help me,thinks!

I want comment 4 could print

trying to install the browsers and OS dependencies: % playwright install --with-deps
2022/11/28 16:08:57 could not download driver: could not check if driver is up2date: could not run driver: exit status 1

it seems the baseURL get 404. baseURL = "https://playwright.azureedge.net/builds/driver"

any idea?

Hi everyone,

Maybe this is a dumb question, but isn't audio supposed to be muted in browser instances launched by Playwright by default? Whenever video playback occurs during automation, I can still hear the audio channels for it.

Is there a special way to disable this audio, if it isn't done automatically for us?