📦 Package manager for CLI

If ~/.config/afx does not exist, afx warns. If ~/.config/afx is symlink, afx does not warn, but say that No packages to install.

$ exa -la ~/.config
drwxr-xr-x   - hibiki  1 Apr 09:16 .
drwxr-x---   - hibiki  1 Apr 10:13 ..
lrwxrwxrwx  32 hibiki  1 Apr 09:16 afx -> /home/hibiki/dotfiles/config/afx
$ exa -la ~/.config/afx
lrwxrwxrwx  32 hibiki  1 Apr 09:16 . -> /home/hibiki/dotfiles/config/afx
drwxr-xr-x   - hibiki 31 Mar 18:50 ..
.rw-r--r-- 438 hibiki  1 Apr 10:14 afx.yaml

afx.yaml is here:

main:
  shell: zsh
  filter_command: fzf --ansi --no-preview --height=40% --reverse

github:
- name: high-moctane/nextword-data
  description: Dataset for nextword.
  owner: high-moctane
  repo: nextword-data
  release:
    name: '*'
    tag: large
  command:
    env:
      NEXTWORD_DATA_PATH: $XDG_CACHE_HOME/nextword/nextword-data-large
    link:
    - from: nextword-data-large
      to: $XDG_CACHE_HOME/nextword/nextword-data-large

WHY

When executing afx install, panic occurs with the following error message and the installation fails.

$ afx install
? OK to install these packages? zsh-users/zsh-completions, zsh-users/zsh-autosuggestions, zdharma-continuum/fast-syntax-highlighting, ... (5 packages) Yes
✔ b4b4r07/enhancd
panic: assignment to entry in nil maprs/zsh-autosuggestions, zdharma-continuum/fast-syntax-highl...

goroutine 83 [running]:
github.com/b4b4r07/afx/pkg/state.add(...)
        /home/jshin/go/pkg/mod/github.com/b4b4r07/[email protected]/pkg/state/state.go:122
github.com/b4b4r07/afx/pkg/state.(*State).Add(0xc00038c140?, {0x7f96d535bf98?, 0xc00013ecf0?})
        /home/jshin/go/pkg/mod/github.com/b4b4r07/[email protected]/pkg/state/state.go:287 +0x1b3
github.com/b4b4r07/afx/cmd.(*installCmd).run.func2()
        /home/jshin/go/pkg/mod/github.com/b4b4r07/[email protected]/cmd/install.go:120 +0x1c5
golang.org/x/sync/errgroup.(*Group).Go.func1()
        /home/jshin/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:57 +0x67
created by golang.org/x/sync/errgroup.(*Group).Go
        /home/jshin/go/pkg/mod/golang.org/x/[email protected]/errgroup/errgroup.go:54 +0x8d

Environment

OS : Ubuntu 20.04.4 Go : 1.18 afx version : v0.1.19 yaml file

github:
  - name: zsh-users/zsh-completions
    owner: zsh-users
    repo: zsh-completions
    plugin:
      sources:
        - zsh-completions.plugin.zsh
  - name: zsh-users/zsh-autosuggestions
    owner: zsh-users
    repo: zsh-autosuggestions
    plugin:
      sources:
        - zsh-completions.plugin.zsh
  - name: zdharma-continuum/fast-syntax-highlighting
    owner: zdharma-continuum
    repo: fast-syntax-highlighting
    plugin:
      sources:
        - fast-syntax-highlighting.plugin.zsh
  - name: b4b4r07/enhancd
    owner: b4b4r07
    repo: enhancd
    plugin:
      sources:
        - init.sh
      env:
        ENHANCD_DISABLE_HOME: 1
  - name: tmux-plugins/tpm
    owner: tmux-plugins
    repo: tpm
    command:
      link:
      - from: .
        to: $HOME/.tmux/plugins/tpm

WHAT

If I take my currently functioning ~/.config/afx/* under the new environment, put the latest release of the afx binary in the path, and run afx install, I get an error that ~/.afx/state.json does not exist.

WHAT

Support an archive file having .gz file extension.

WHY

#45 (In this issue, having format field is suggested but it's fixed by supporting it in a fundamental way in this PR)

WHAT

After I run afx self-update, an error zsh: exec format error: afx arised. The version before the update was 1.21. I manually reinserted afx and it fixed, so it seems that the detection of OS or architecture is failing during self-update. I use Ubuntu20.04 on WSL2 and afx_linux_x86_64.tar.gz.

WHAT

Sometimes, as in this lazygit, the tag is v0.34 but the filename uses 0.34 instead of v0.34.

I can't use .Release.Tag in assets, what should I do?

WHAT

Run URL templating just after parsing YAML file and reuse it in all places in http package to get valid URL even if template variables are used in URL field

WHY

http package allows to use template variables in URL field but GetHome() is also referring c.URL but it's not templated so Installed() is failed

WHAT

Fix Installed() logic on plugin installation

WHY

plugin.Installed() behavior was still kept as old implementations was. So changed to use GetSources (it's considering glob) and add tilde consideration

ref: https://github.com/b4b4r07/afx/issues/32

WHAT

It is indeed installed and the commands are usable, but the result of afx init looks like this.

## package "junegunn/fzf" is not installed
## package "junegunn/fzf" is not installed

My github.yaml

github:
  - name: junegunn/fzf
    description: A command-line fuzzy finder
    owner: junegunn
    repo: fzf
    command:
      build:
        steps:
          - ./install --all
      link:
        - from: 'bin/fzf'
        - from: 'bin/fzf-tmux'
    plugin:
      sources:
        - ~/.fzf.zsh
      env:
        FZF_DEFAULT_COMMAND: fd --type f
        FZF_DEFAULT_OPTS: --height 50% --reverse
        FZF_CTRL_T_COMMAND: rg --files --hedden --follow --glob "!.git/*"
        FZF_CTRL_T_OPTS: --preview "bat --color=always --style=header,grid --line-range :100 {}"
        FZF_ALT_C_COMMAND: fd --type d

WHY

If it's a bug, that's the report. If there is something wrong with the settings, please let me know.

WHAT

• Use state.ID instead of state.Name
• Add state rm command
• Add annotation feature related to bump up version

WHY

Currently in state file, each state name is same as pkg name. But if using pkg.name as state.name, it may be problem:

• changing pkg.name in config file by users

this operation will be regarded as adding new package and removing that package.

so we need fixed string not depending on pkg.name

WHAT

Add a feature to ask it's ok to install/uninstall/update command.

$ afx install
? OK to iinstall these packages? b4b4r07/new-pkg-1, b4b4r07/new-pkg-2 (y/N)

WHY

Currently it's difficult to know what packages will be installed etc before doing actual operation.

WHAT

When updating a package that is already installed, there is an error that appears to be a problem with the timing of removing the past. When this happens, it is inconvenient because it requires re-entry of GITHUB_TOKEN.

❯ afx update
? OK to update these packages? cli/cli Yes
✖ cli/cli
[ERROR]: 1 error occurred:
        * 1 error occurred:
                * cli/cli: failed to get command.link: cli/cli: 2 files matched: []string{"/home/uga/.afx/github.com/cli/cli/gh_2.14.6_linux_amd64/bin/gh", "/home/uga/.afx/github.com/cli/cli/gh_2.14.4_linux_amd64/bin/gh"}

Here is an excerpt from my release.yaml.

- github:
  - name: cli/cli
    description: Github's official command line tool
    owner: cli
    repo: cli
    release:
      name: gh
      tag: v2.14.6
      asset:
        filename: '{{ .Release.Name }}_{{ replace .Release.Tag "v" "" }}_{{ .OS }}_{{ .Arch }}.tar.gz'
    command:
      link:
        - from: '**/gh'

WHY

Bug report.

WHAT

(Write what you need)

afx does not read symlink again.

The cause of the bug exists in between v0.1.21 and v0.1.22. (see https://github.com/b4b4r07/afx/compare/v0.1.21...v0.1.22)

My current afx.yaml is here.

Directory Structure

$ exa -al ~/.config
lrwxrwxrwx  32 hibiki  7 Jun 14:09 afx -> /home/hibiki/dotfiles/config/afx

$ exa -al ~/.config/afx
.rw-r--r-- 1.8k hibiki 12 Jun 11:31 afx.yaml

Debug Log

• v0.1.21

$ AFX_LOG_LEVEL=debug afx install
2022/06/12 12:01:43 [INFO] afx version: 0.1.21
2022/06/12 12:01:43 [INFO] Go runtime version: go1.16.1
2022/06/12 12:01:43 [INFO] Build tag/SHA: v0.1.21/054f74c
2022/06/12 12:01:43 [INFO] CLI args: []string{"/home/hibiki/.local/share/aquaproj-aqua/pkgs/github_release/github.com/b4b4r07/afx/v0.1.21/afx_linux_arm64.tar.gz/afx", "install"}
2022/06/12 12:01:43 [DEBUG] (goroutine): checking new updates...
2022/06/12 12:01:43 [INFO] Reading config /home/hibiki/dotfiles/config/afx/afx.yaml...
[ERROR]: failed to initialize afx: /home/hibiki/dotfiles/config/afx/afx.yaml: failed to read config: [23:9] unknown field "directory"
  20 |       - koron/cmigemo
  21 |     command:
  22 |       build:
> 23 |         directory: nkf-2.1.5
               ^
  24 |         steps:
  25 |           - make
  26 |           - make install prefix=~/.local
  27 |

• v0.1.22

$ AFX_LOG_LEVEL=debug afx install
2022/06/12 12:02:53 [INFO] afx version: 0.1.22
2022/06/12 12:02:53 [INFO] Go runtime version: go1.16.1
2022/06/12 12:02:53 [INFO] Build tag/SHA: v0.1.22/4b34e4c
2022/06/12 12:02:53 [INFO] CLI args: []string{"/home/hibiki/.local/share/aquaproj-aqua/pkgs/github_release/github.com/b4b4r07/afx/v0.1.22/afx_linux_arm64.tar.gz/afx", "install"}
2022/06/12 12:02:53 [WARN] /home/hibiki/.config/afx: found but cannot be loaded. yaml is only allowed
2022/06/12 12:02:53 [DEBUG] (goroutine): checking new updates...
2022/06/12 12:02:53 [DEBUG] mkdir /home/hibiki/.afx
2022/06/12 12:02:53 [DEBUG] mkdir /home/hibiki/bin
2022/06/12 12:02:53 [INFO] state additions: (0) []string(nil)
2022/06/12 12:02:53 [INFO] state deletions: (0) []string(nil)
2022/06/12 12:02:53 [INFO] state changes: (0) []string(nil)
2022/06/12 12:02:53 [INFO] state unchanges: (0) []string{...skip...}
No packages to install
2022/06/12 12:02:53 [DEBUG] checking updates on afx repo...
2022/06/12 12:02:53 [INFO] root command execution finished

WHY

(Write the background of this issue)

WHAT

if ~/.config/afx is a relative link, cannot execute the afx command

m ~/.config
❯ ls -la
total 20
drwxr-xr-x  5 m m 4096 May  3 20:29 .
drwxr-xr-x 22 m m 4096 May  3 20:29 ..
lrwxrwxrwx  1 m m   38 May  3 20:29 afx -> /home/m/projs/dotfiles/afx/.config/afx


m ~/.config
❯ afx
Package manager for CLI
...
...
Use "afx [command] --help" for more information about a command.

but, if ~/.config/afx is a relative link

❯ ls ~/.config/ -l
total 12
lrwxrwxrwx 1 m m   33 May  3 20:30 afx -> ../projs/dotfiles/afx/.config/afx

m ~/projs/dotfiles master ≡*+9 ~2 -1
❯ afx
[ERROR]: failed to initialize afx: /home/m/.config/afx: failed to walk dir: stat ../projs/dotfiles/afx/.config/afx: no such file or directory

WHY