Sorry but what does it mean? It's very first run.

Gocoin Wallet version 1.9.5
This program comes with ABSOLUTELY NO WARRANTY

GOCOIN_WALLET_CONFIG not set
Using config file wallet.cfg
Seed file .secret not found
Enter your wallet's seed password: ***
ERROR: open balance/unspent.txt: The system cannot find the path specified.

Am I supposed to make some thing prior to running wallet? Where can I see some documentation?

Hey can't build fetchbal.go tool

selivanov@vs01:~/go/src/github.com/piotrnar/gocoin/tools$ go build fetchbal.go
# command-line-arguments
./fetchbal.go:133: undefined: wallet.NewWallet

I get the following when trying to build the import tool.

#command-line-arguments .\importblocks.go:98: chain.Save undefined (type *chain.Chain has no field or method Save)

copy and past the following unit tests as "misc_tests.go". Into /lib/secp255k1

https://gist.github.com/haltingstate/cf84b5418ac889d192a5

For some valid private keys, the generated public key fails "pubkey2.IsValid()". SIPA's library works for those private keys. A valid public key is not generated for a valid seckey (even through the public key appears to be valid according to sipa's implementation).

About 1 in 1500 keys.

also, for func Multiply(xy, k, out []byte) bool {..}

Multiply(pubkey1, privatekey2) should equal Multiple(pubkey2, privatekey1), fails for these keys.

SIPA said you ported an early version of the library. I cleaned up the library and improved interface, but cannot find the source of these errors.

I just ran a full sync with the following options:

LastTrustedBlock:"00000000839a8e6886ab5951d76f411475428afc90947ee320161bbf18eb6048" AllBalances.AutoLoad:false UTXOSave.SecondsToTake:0

After the sync had completed, gocoin crashed with:

> panic: runtime error: integer divide by zero

goroutine 1652364922 [running]:
github.com/piotrnar/gocoin/lib/utxo.(*UnspentDB).save(0xc000c44480)
	/home/jameson/go/src/github.com/piotrnar/gocoin/lib/utxo/unspent_db.go:267 +0xc6e
created by github.com/piotrnar/gocoin/lib/utxo.(*UnspentDB).Save
	/home/jameson/go/src/github.com/piotrnar/gocoin/lib/utxo/unspent_db.go:446 +0x8e

Hi! I'm proposing some changes to addr handling in Bitcoin Core, and trying to ensure there will not be negative consequences for other clients on the network. For more information about the changes, please see my mailing list post. The crux is that, if the changes are accepted, bitcoin core would stop sending addr messages to inbound peers who don't "indicate interest" aka initiate an addr-related message (addr, addrv2, getaddr, or sendaddrv2).

I'd like to ensure that gocoin clients will initiate an addr related message to outbound peers. I've looked in the code and believe the software plays nice, and am looking for a +1 from someone more familiar with this project.

My understanding: in response to a version message, a gocoin node will self-advertise its address (link), and often initiate a getaddr message (link). If this is right, there should be no compatibility issues with my proposed changes. Can someone confirm this understanding?

Thanks in advance! Amiti

Panic seen:

> main panic recovered: runtime error: invalid memory address or nil pointer dereference
goroutine 1 [running]:
runtime/debug.Stack(0xd90dc0, 0xc000010018, 0xc1efef94b8)
        /usr/local/go/src/runtime/debug/stack.go:24 +0x9d
main.main.func1()
        /home/piotr/GOPATH/src/github.com/piotrnar/gocoin/client/main.go:282 +0x137
panic(0x7fda20, 0x10fa230)
        /usr/local/go/src/runtime/panic.go:522 +0x1b5
github.com/piotrnar/gocoin/client/network.LimitRejectedSize()
        /home/piotr/GOPATH/src/github.com/piotrnar/gocoin/client/network/txpool_sort.go:206 +0x135
github.com/piotrnar/gocoin/client/network.RejectTx(0xc1fb292120, 0xc000c325d5, 0xd5b1bb53dc3165ba)
        /home/piotr/GOPATH/src/github.com/piotrnar/gocoin/client/network/txpool_core.go:193 +0x11a
github.com/piotrnar/gocoin/client/network.(*OneTxToSend).Delete(0xc15a3a5ad0, 0xc12c1cd500)
        /home/piotr/GOPATH/src/github.com/piotrnar/gocoin/client/network/txpool_core.go:607 +0x271
github.com/piotrnar/gocoin/client/network.HandleNetTx(0xc0d4298300, 0x0, 0x1008e00)
        /home/piotr/GOPATH/src/github.com/piotrnar/gocoin/client/network/txpool_core.go:496 +0x1997
main.main()
        /home/piotr/GOPATH/src/github.com/piotrnar/gocoin/client/main.go:470 +0xb94

it would be helpful if there was a config parameter that makes it easy to set the trusted block to the genesis block. Something similar to Bitcoin Core's "assumevalid=0"

Hi, sorry for raise this issue, I just want to know how can I use gocoin to sign transaction and broadcast? especially when the account have muti utxos

HDWallet.Child is not guaranteed to always return 33-byte private key. Also your PR policy is absurd. You'd better but that disclaimer in bold on top of the readme, so no one will waste time on it.

Hi,

I'm trying to parse the blockchain using gocoin, but I got a panic: runtime error: invalid memory address or nil pointer dereference when I try to decode address for weird TxOut.

Here is my code (https://gist.github.com/tsileo/8008319), and here is the exception I'm getting:

2013/12/17 17:56:54 128233
2013/12/17 17:56:54 128234
2013/12/17 17:56:54 128235
2013/12/17 17:56:54 128236
2013/12/17 17:56:54 128237
2013/12/17 17:56:54 128238
2013/12/17 17:56:54 128239
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x50 pc=0x44796a]

goroutine 1 [running]:
github.com/piotrnar/gocoin/btc.(*BtcAddr).String(0x0, 0x1a, 0x1a)
    /work/opensource/blockchain_playground_golang/src/github.com/piotrnar/gocoin/btc/addr.go:134 +0x2a
main.main()
    /work/opensource/blockchain_playground_golang/dat2.go:75 +0x250e

goroutine 2 [syscall]:
exit status 2

It happens on weird TxOut, when it can't decode/compute address, I found some explanations here and here.

I see it at block:

• 71036
• 127630
• 128239
• I stopped at block 128239

Even blockchain.info can't handle these TxOuts, I think it's missing some error checking, maybe it should return nil ?

I just started learning Go, so let me know if I missed something,

Thanks!

Did you evaluate the possibility of requiring a signed CLA (Contributors License Agreement) for contributions? I think that way you could set the terms under which contributions can be made and include under which license everything falls and that you have the full rights to the contribution etc.

Many companies and foundations that maintain open source software require contributors to sign such CLAs, like the Eclipse Foundation, Canonical, Google, Microsoft and others.

I think most open source CLAs have the purpose that the maintainers can be sure that contributors grant rights to the end-user and also allow project sublicensing, but I assume that can be modified to your needs.

This might require some more research if you want to be on the safe side.

• Info: https://en.wikipedia.org/wiki/Contributor_License_Agreement
• Info: https://www.clahub.com/pages/why_cla
• CLA Generator: http://contributoragreements.org/agreement-chooser.html
• Service for managing CLAs for GitHub: https://www.clahub.com/
• Service for managing CLAs for GitHub: https://cla-assistant.io/

First of all: Amazing effort to write an independent Bitcoin implementation as an (as it seems) single contributor.

I stumbled upon this thanks to this Tweet, which points to the same author's blog article comparing different Bitcoin node implementations' performance.

I wanted to take a dive into the code, but realized that in many/most packages, for example github.com/piotrnar/gocoin/lib/btc, most exported types and functions don't have any Godoc comment. Some types/functions have comments, but don't adhere to the Godoc format (like beginning with the name of the type/function, as mentioned in this Go Blog article).

See the Godoc of that package here: https://godoc.org/github.com/piotrnar/gocoin/lib/btc

Examples of well documented packages:

• https://godoc.org/github.com/gorilla/websocket
• https://godoc.org/go.uber.org/zap

Proper Godoc comments might be helpful for

1. potential contributors who want to dive into and understand the code and
2. package users who want to use your exported packages as a library for their own applications.

To not export some packages at all you could use an internal directory, as explained in the Go 1.4 release notes.

As a side note, the recently announced official https://go.dev website, which offers an updated / extended version of Godoc, for example to support versioned Go modules, seems to not be able to understand your LICENSE and thus thinks it's not allowed to show your Godoc at all. See https://pkg.go.dev/github.com/piotrnar/gocoin/lib/btc?tab=doc.

“Doc” hidden due to license restrictions.