Hey! I'm trying to use the S4 website after downloading, but somehow after the page is downloaded (as webpage complete) some Javascript is not being activated.

See: https://ibb.co/7gXn6Hp

Hello,

I'm trying to use the s4 go library to encrypt and decrypt bytes. But when using import "github.com/simonfrey/s4" as written in the README, I get a strange error :

go: finding github.com/simonfrey/s4 latest go: downloading github.com/simonfrey/s4 v0.0.0-20210502093622-aa95753ec8f6 go: extracting github.com/simonfrey/s4 v0.0.0-20210502093622-aa95753ec8f6 go: test imports github.com/simonfrey/s4: github.com/simonfrey/[email protected]: parsing go.mod: module declares its path as: s4 but was required as: github.com/simonfrey/s4

I've tried the rewrite directive in my go.mod but it's only making things worse. How to correctly import this library ? Thanks !

First of all thanks for sharing this repo @simonfrey !

This PR is really heavy handed - no hard feelings if you don't want to go down this road.

It replaces the Vue dependency with a super-micro "framework" that you can see here in framework.js.

Each "component" manages its own state, and every "render" forces a re-render of all of it's children, so it's pretty 'dumb' but it gets the job done in just 60 lines of "framework code".

The render trees themselves are just using the el and append functions (also in framework.js) which are helpers for creating DOM elements, applying properties, and (recursively) appending children.

I tried to keep all the major functionality identical, but I did tweak it so that each form has its own "error" state and rendering. I also removed the ability to hide the errors because that doesn't play nicely with how I implemented "computed properties", which re-trigger the error that you just tried to clear.

Also ./buildFrontend.sh wasn't executable so that's also patched here :)

I think this will solve #20

When loaded locally, the javascript could execute before the DOM was parsed, leading to a situation where the decrypt inputs didn't have events attached to them.

Hello,

First thanks for this project :+1:

I'm currently using your tool and by looking at the source I've found your two open issues (#20, #21) and wanted to help. I fixed them and added a few extras along the way.

What's new :

• WASM binary is slightly smaller.
• The output is now a single HTML page, CSS and JS are packed inside at build time (thanks awk). I found it handy to move this tool around as one file only.
• I updated the JavaScript with a more contemporary syntax and hopefully made it more straightforward too.
• Textareas are cleared when pressing Ctrl+S to avoid storing secrets.
• Bulma CSS is no more, I wrote simple and modern CSS from scratch to make the project even more understandable. I kept the same look and feel.
• HTML is now even simpler.

I hope you like it, let me know what we can improve.

Have a nice day !

Vue.js is the biggest blog of not understandable code in this project. Would be nice if that could be replaced with a lower attack surface vanilla javascript code

The bulma.css (https://bulma.io/) we use is already quite small, but as we only use a quite low percentage of it, we could remove it to make the project even more understandable.

It would be desirable to get rid of this file: https://github.com/simonfrey/s4/blob/master/frontend/css/bulma.min.css

Please note that s4 is provided as it is and I do not take responsibility for any bugs. s4 is a tiny layer around sharedsecret and golang's AES encryption.

…h up with code change

https://github.com/simonfrey/s4/commit/c5934512c30db8030831bd293a3b291b2f9a8678 I think changes from github.com/posener/sharedsecret to github.com/hashicorp/vault ; this updates the text in the index.html to reflect that

As the hashi corp shamir secret sharing is used in a lot wider array of applications and hashi corp has a financial interest in keeping the library up to date and working I want to move away from the shared secret library to https://github.com/hashicorp/vault/blob/master/shamir/shamir.go

If merged, this pull request addresses the issue that func TestSecretSharingSameShares panics depending on what value is assigned to n.

Background: From the docs, rand.Intn(myInt int) returns a a non-negative pseudo-random number in [0,myInt). It panics if myInt <= 0.

Here if n is assigned 0, 1, or 2 then the line where k is defined panics.

Note: This test still fails. This PR addresses the random element of this test failing. The remaining element will be addressed in a different PR.

The WebAssembly JavaScript support file is currently included in the project. I think a better approach is using the file present in the Go root folder.

According to the WebAssembly documentation, wasm_exec.js can be retrieved from the local Go root folder using

cp "$(go env GOROOT)/misc/wasm/wasm_exec.js" .

Therefore in this commit:

• I have removed frontend/js/wasm_exec.js
• I have included this file to the .gitignore to avoid risking to commit it
• I have added the WebAssembly documentation command to the build script