Closes: #XXX

Description

This PR updates some stale code in Makefile and .github/workflows/deploy-contract.yml to make the CI works with performing solidity test on CI builds.

Some improvements:

1. use make test-solidity in Github Actions instead of make test-contract
2. Remove test-contract from Makefile. Contract & Solidity tests now can be run by make test-solidity.
3. Remove installing solcjs from Makefile. This is no longer needed. Truffle inside solidity tests will handle installation of solcjs
4. Add verbose logs parameter on yarn test to output ethermintd activities during CI test for better debugging

For contributor use:

• [x] Targeted PR against correct branch (see CONTRIBUTING.md)
• [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• [x] Code follows the module structure standards.
• [ ] Wrote unit and integration tests
• [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• [ ] Added relevant godoc comments.
• [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• [ ] Re-reviewed Files changed in the Github PR explorer

For admin use:

• [ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• [ ] Reviewers assigned
• [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Closes: #XXX

Description

For contributor use:

• [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
• [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• [ ] Code follows the module structure standards.
• [ ] Wrote unit and integration tests
• [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• [ ] Added relevant godoc comments.
• [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• [ ] Re-reviewed Files changed in the Github PR explorer

For admin use:

• [ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• [ ] Reviewers assigned
• [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

cannot change the state of the smart contract src: https://github.com/leejw51crypto/ethermint.git branch: etherjs folder: mytest/mytest

how to reproduce

env variable for testing

MYMNEMONICS <- your mnemonics

1. git clone https://github.com/leejw51crypto/ethermint.git
2. cd ethermint
3. git checkout etherjs
4. cd mytest/mytest
5. make

when run with ganache

BigNumber { _hex: '0x00', _isBigNumber: true }
{
  nonce: 17,
  gasPrice: BigNumber { _hex: '0x04a817c800', _isBigNumber: true },
  gasLimit: BigNumber { _hex: '0xa2ae', _isBigNumber: true },
  to: '0x2831Fb598Fb659EC881585557C3e36414BfC32e5',
  value: BigNumber { _hex: '0x00', _isBigNumber: true },
  data: '0x6057361d0000000000000000000000000000000000000000000000000000000000000015',
  chainId: 1337,
  v: 2709,
  r: '0x14ecfc5d6e69a89278ab8e2a4334898f25e2677cc38e0bd509791b5a07bdffaf',
  s: '0x6fca8a9e61a78efe115f9983b3f1b89a79e1eca0331dd84f52a3a06d9da210fc',
  from: '0x48b212A71eBbB202F7cfD1aACee3A36FdE2Fbc51',
  hash: '0xe0e6d9b1f4802245fa8a652bcdbe02c8dbf300d15491b590ff1c8c105d10617e',
  type: null,
  wait: [Function (anonymous)]
}
BigNumber { _hex: '0x15', _isBigNumber: true }

when run with ethermint

BigNumber { _hex: '0x00', _isBigNumber: true }
{
  nonce: 6,
  gasPrice: BigNumber { _hex: '0x14', _isBigNumber: true },
  gasLimit: BigNumber { _hex: '0x52d4', _isBigNumber: true },
  to: '0x5589184cE12715763c409b0e33ad6f8f075d0377',
  value: BigNumber { _hex: '0x00', _isBigNumber: true },
  data: '0x6057361d0000000000000000000000000000000000000000000000000000000000000015',
  chainId: 2,
  v: 39,
  r: '0x35db8a1ca2054e49c1d913ac3566f654a2c47072b71592926141af57afb93fed',
  s: '0x0ff0108bc624f304d329d78e6bb43c7da1ff60f436ae3626b47b7c33a24de54d',
  from: '0x48b212A71eBbB202F7cfD1aACee3A36FdE2Fbc51',
  hash: '0xac7a4efd5df15dd6b798b4f58bdc7f66e3e54eaf17f624e0525c539de57b14db',
  type: null,
  wait: [Function (anonymous)]
}
BigNumber { _hex: '0x00', _isBigNumber: true }

System info: ethermint main branch

Steps to reproduce:

1. start devnet
2. start new node with state sync enabled
3. query new node for the tx and states

Expected behavior: tx query succesfully

Actual behavior: tx not found

Additional info:

• chain state works fine though, for example, query contract state with eth_call works.

Closes: #1316, #1461

There are a set of tasks we probably want to hit simulateously to this upgrade.

• Move EVM Priority to its own custom Application side mempool
• #1231
• Move to dep injection and autocli.
• Anything else anyone can think of? @fedekunze @nddeluca @facs95 @yihuang

Description

WIP

For contributor use:

• [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
• [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• [ ] Code follows the module structure standards.
• [ ] Wrote unit and integration tests
• [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• [ ] Added relevant godoc comments.
• [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• [ ] Re-reviewed Files changed in the Github PR explorer

For admin use:

• [ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• [ ] Reviewers assigned
• [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

System info:

Max OS X
Main (d7c9656d7704e77ed0f71ea45755cadc25dbd979)

Steps to reproduce:

1. Deploy CreationCode with the code below, using remix or any tool you like (https://gist.github.com/FrancoCRO/b198c1dc6d63626e92cd00f7fedd9406)
2. Call CODE_HASH

Expected behavior: Returns code hash

Actual behavior: Ethermintd becomes unresponsive, and is crazy printing EVM stack logs for minutes, and you have to SIGKILL it

Additional info: This CreationCode method is used by Uniswap-family swaps The PancakePair contract code is obtained from here (https://bscscan.com/address/0x0eD7e52944161450477ee417DE9Cd3a859b14fD0#code) And is called from here (https://bscscan.com/address/0xcA143Ce32Fe78f1f7019d7d551a6402fC5350c73#code)

Closes #268

part of it is extracted into https://github.com/tharsis/ethermint/pull/276.

Description

For contributor use:

• [x] Targeted PR against correct branch (see CONTRIBUTING.md)
• [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• [x] Code follows the module structure standards.
• [ ] Wrote unit and integration tests
• [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• [ ] Added relevant godoc comments.
• [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• [ ] Re-reviewed Files changed in the Github PR explorer

For admin use:

• [ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• [ ] Reviewers assigned
• [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

This PR is huge, added some guide for review in the comment section below.

Description

Closes: #710

As profiled in the issue page, the bottleneck is the slowness of deep context stack, there's no easy way around it other than refactor the StateDB to use journal logs like what go-ethereum does, thus this big code refactoring.

What this PR does

• Implement a standalone statedb module in x/evm/statedb which implements vm.StateDB interface with the support of several keeper methods, the keeper interface is captured in statedb.Keeper.
• The StateDB implementation keep all the dirty states in memory, at the end of tx execution, commit all the dirty changes to keeper at once
• record all the modify operations in a list of journal logs, snapshot revert is done by undo part of the logs.
• x/evm/statedb/{journal.go, access_list.go, state_object.go} are directly adapted from go-ethereum itself.

Benchmark result

BenchmarkMessageCall (improved 310X)

Before

BenchmarkMessageCall-16    	       1	25846269634 ns/op
BenchmarkMessageCall-16    	       1	26773165908 ns/op
BenchmarkMessageCall-16    	       1	25786298762 ns/op

After

BenchmarkMessageCall-16    	      12	  91367037 ns/op
BenchmarkMessageCall-16    	      13	  82284757 ns/op
BenchmarkMessageCall-16    	      14	  83061467 ns/op

BenchmarkEmitLogs (improved 2.5X)

Before

BenchmarkEmitLogs-16    	      98	  12034965 ns/op
BenchmarkEmitLogs-16    	      98	  12146658 ns/op
BenchmarkEmitLogs-16    	      96	  12313053 ns/op

After

BenchmarkEmitLogs-16    	     225	   5288751 ns/op
BenchmarkEmitLogs-16    	     232	   5189175 ns/op
BenchmarkEmitLogs-16    	     222	   5191943 ns/op

For contributor use:

• [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
• [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• [ ] Code follows the module structure standards.
• [ ] Wrote unit and integration tests
• [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• [ ] Added relevant godoc comments.
• [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• [ ] Re-reviewed Files changed in the Github PR explorer

For admin use:

• [ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• [ ] Reviewers assigned
• [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Some RPC endpoints that need to be added/revised after merging #231:

• eth_resend
• eth_fillTransaction
• eth_feeHistory
• eth_maxPriorityFeePerGas
• personal_sendTransaction: updates
• debug_intermediateRoots
• personal_unpair
• personal_initializeWallet
• personal_listWallets

System info:

0.0.0-308-g7e1b45b

Steps to reproduce:

1. Make a out-of-gas eth_call

• Can use: yarn test --network ethermint proxy

2. The out-of-gas error occured. However the JSON-RPC message is in a different format compared to ganache

Expected behavior: [What you expected to happen]

 <   {
 <     "id": 1626419303744,
 <     "jsonrpc": "2.0",
 <     "error": {
 <       "message": "VM Exception while processing transaction: out of gas",
 <       "code": -32000,
 <       "data": {
 <         "0xf08cc2bfa30270de3f28f2d8349d2797e9e15251c0cd8c2555b581c8428f2904": {
 <           "error": "out of gas",
 <           "program_counter": 219,
 <           "return": "0x"
 <         },
 <         "name": "c"
 <       }
 <     }
 <   }

Actual behavior: [What actually happened]

 <   {
 <     "jsonrpc": "2.0",
 <     "id": 1626419644885,
 <     "error": {
 <       "code": -32000,
 <       "message": "out of gas"
 <     }
 <   }

Additional info: [Include gist of relevant config, logs, etc.]

Since the out-of-gas error is correctly occured. But the returned message can't be parsed by truffle framework, returned in a test failed.

Closes: #310

Description

• fix make target build-docker-local-ethermint
• fix make target localnet-start
  • add ip-addresses for localnet-setup generation
  • add localnet-setup folder to keep localnet-setup-artifacts
  • map localnet-setup-artifacts to containers
  • change start-docker.sh to pick up generated localnet-setup-artifacts

For contributor use:

• [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
• [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• [ ] Code follows the module structure standards.
• [ ] Wrote unit and integration tests
• [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• [ ] Added relevant godoc comments.
• [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• [ ] Re-reviewed Files changed in the Github PR explorer

For admin use:

• [ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• [ ] Reviewers assigned
• [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Bumps json-pointer from 0.6.1 to 0.6.2.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

System info: [main] branch

Steps to reproduce:

trace success tnx in testnet: curl --location --request POST 'http://localhost:8545' \ --header 'Content-Type: application/json' \ --data-raw '{ "jsonrpc": "2.0", "method": "debug_traceTransaction", "params": [ "0x91d9569bdc6e2a18dbda03601baa45b081307c7b8c07b772c7e7bf6f0892f8db" ], "id": 1 }'

Expected behavior: should get "failed": false, "gas": 135101, and when pass with callTracer should get { "from": "0x110a55949b11d263fdd26f4760446de44d216e14", "gas": "0x168e", "gasUsed": "0x0", "input": "0x", "output": "0x", "to": "0x6bad0fb0c38a52921915462865275964f62ec9e9", "type": "CALL", "value": "0x12590b98808435f" } refund value without error

Actual behavior: get "failed": true, "gas": 163914, and when pass with callTracer get "out of gas" error

Additional info:

1. balance change from tendermint events: 69667484395521009792-819570000000000000-14252689574316697128+82631294701814623+144065000000000000=54821921115906127287 aligned with 69667484395521009792-14252689574316697128-135101*5000000000000+82631294701814623=54821921115906127287

Question: do we treat stack out of gas when refund amount is more the leftoverGas?

The sdk v0.46.7 release notes recommend that users bump ics23 to v0.9.0 and discontinue the usage of the replace statement in go.mod that has been used since the dragonberry patch.

• https://github.com/evmos/ethermint/pull/1580
• https://github.com/evmos/evmos/issues/1200
• https://github.com/cosmos/cosmos-sdk/releases/tag/v0.46.7

Please note that #1580 is targeting the release/v0.20.0 branch specifically.

This is also patched in #1575, which targets main.

System info: commit, MacOS 12.2.1. Installed ethermintd using make install

Steps to reproduce:

1. ethermintd testnet init-files --v 1 -o singlenode/test --keyring-backend test

Expected behavior: This command should create gentxs and node0 directories inside singlenode/test folder. node0 should contain ethermintd folder with all config and genesis files.

Actual behavior: It generates evmosd directory inside node0

Closes: #XXX

Description

This PR lints the ethermint tests.

note: along the way, I found somewhat of a bug. The .proto files referenced types.Int, which should be cosmossdk.io/math.Int.

I fixed it, please let me know if it should be separated.

For contributor use:

• [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
• [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• [ ] Code follows the module structure standards.
• [ ] Wrote unit and integration tests
• [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• [ ] Added relevant godoc comments.
• [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• [ ] Re-reviewed Files changed in the Github PR explorer

For admin use:

• [ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• [ ] Reviewers assigned
• [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Bumps github.com/rs/cors from 1.8.2 to 1.8.3.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.