Purpose

Update header levels and immediate spacing around them.

Why

As I read through the book I noticed that formatting was off in places, often when code ran up against headers or other blocks of content. I also noticed that some header levels appeared "off".

This PR is focused specifically on the header levels with follow-up PRs for other indirectly related formatting issues.

fixes #105

Hi @brudgers I missed out on your comment on my HN post, and now there is no way to contact you. The editorial theme I have mentioned in the readme document here, is there more information required on that?

What prompted writing this book:

While learning web dev with Go it was very difficult to understand real life examples, most of all the tutorials/books I read gave some ridiculously simple examples and then somehow expect the total newbie to understand all the complicated logic that goes with an actual real life webapp.

Also PRs are welcome!

Seems like this code in the templates example is just reproducing the ParseGlob method:

Reading template:

        templates, err = template.ParseFiles(allFiles...)
        
Where allFiles is populated as below:

        var allFiles []string
        templatesDir := "./public/templates/"
        files, err := ioutil.ReadDir(templatesDir)
        if err != nil {
            fmt.Println("Error reading template dir")
        }
        for _, file := range files {
            filename := file.Name()
            if strings.HasSuffix(filename, ".html") {
                allFiles = append(allFiles, templatesDir+filename)
            }
        }
        

For example, in my program this is the exact code:

var tmplDir = "/home/ben/projects/bagapp2/tmpl/"

var templates = template.Must(template.ParseGlob(tmplDir + "*.html"))

Some headers jump sequence, others have inconsistent spacing around them which (I vaguely recall) interferes with some rendering.

Going to reference this issue for an upcoming PR, potential further discussion.

I couldn't find where the examples code is, as I am interested to contribute the code and tests too. So maybe you should add a subdirectory named examples so all the examples code can be there.

or if you have it somewhere else please let know.

PS: I was about to write a book in my local language( swahili, I'm from tanzania), now I don't think it is necessary. Will instead contribute to this one so maybe in the future I will just need to translate this.

First of all, many thanks for providing both the book and the source files used to produce the book. I'm a newbie to Go and have found the book very helpful as a companion to some other books I'm working through, though it is without a doubt very useful all on its own.

As I work through the material, I've found some minor issues, several of which have been reported and fixed by Pull Requests submitted by others (e.g., #92). I've got some others that I wish to submit, but I'd like to test the changes by generating fresh ebooks for comparison, either before submitting PRs or just after to proof the work.

I suspect that perhaps you're using pandoc, but wanted to touch base and confirm before I went in that direction.

Thanks in advance for your help.

In chapter: 2.0implementationBasics.md,

We take a sub string of the URL and remove the /delete/ part and we have the ID of the task.

but the code above we strip the /tasks/ actually, is this a typo?

Hi, The write up about Go curly brackets syntax and indentation wars might need changes in https://github.com/thewhitetulip/web-dev-golang-anti-textbook/blob/master/content/02.1.md

The fact that go cannot have opening curly bracket at the beginning of the line is an "unintended consequence" of doing away with semicolons

see Rob Pike's talk about braces here https://youtu.be/VoS7DsT1rdM?t=1353

Example from a preview PDF copy:

I'm proposing that we remove these sections if they don't contain any external "See also" style external links (e.g., those intended to provide more information/context).

@thewhitetulip

As an example, if there are header level changes, typos and spacing adjustments, do you want them combined into fewer PRs or more focused on a specific type of change?

If combined, would you find it helpful to have multiple commits per PR (e.g., one file per commit with all changes to that file) or squashed to one commit containing all changes?

I've got some notes from going through the text (only the first pass at reading as I have much to learn from your book) and would like to begin compiling the changes into acceptable PRs. I figure I would touch base and confirm some details before investing too much work into the effort just yet.

Thanks.

I noticed that while reading the epub version the level 2 header for Constants was rendered as ## Constants, literally within the text instead of a formatted header as intended. I double-checked and the 2018-06-09 version available from leanup has the same issue in the PDF format also.

Attaching a screenshot for illustration.

I briefly looked over the source Markdown file, but I can't tell for sure if the issue has been addressed since the 2018-06-09 version was released.

Error msg: go install github.com/mohamedmehdigara/hello@latest: no matching versions for query "latest"

because this command: go install github.com/mohamedmehdigara/hello

gave the following error msg: go install: version is required when current directory is not in a module Try 'go install github.com/mohamedmehdigara/hello@latest' to install the latest version

If we look at Parameterised routing, within the Basic web application section. I believe this comment is misleading. While it may be used later to retrieve the task id and delete, this is not the case here.

While this might well be the shortest way you found to demonstrate the output you wanted, training users toward this function stands a good chance of them trying to use it to solve early problems it is not suitable for.