Extracted from review on https://github.com/umee-network/umee/pull/1654

maybe we can have a helper function:

type balances struct {
  balance, collateral, utokenSupply, exchangeRate, borrowed
}
func getBalances(ctx, addr) balances
And use it across test functions :

before := getBalances(...)
...
after := getBalances(...)
Will make the code easier to read (and much shorter)

let's create a helper function:

check := func(err, expectedDec, p) {...}
...
check(err, "0.5", p)

let's create a helper function ucoin which will do the "u/"+, and panic if denom is already a utoken,

please provide more meaningful name for [each test case]

[add comments for test cases that might be confusing in why they should fail/pass]

--- tcs := []testCase{
+++ tcs := []struct {
same for other test cases, makes it easier to read if we have type definition right next to the values.

Description

evaluating 2 docker images for e2e tests: dynamic build and static builds, and optimizing e2e docker building.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

• [ ] included the correct type prefix in the PR title
• [ ] added ! to the type prefix if API or client breaking change
• [ ] added appropriate labels to the PR
• [ ] targeted the correct branch (see PR Targeting)
• [ ] provided a link to the relevant issue or specification
• [ ] added a changelog entry to CHANGELOG.md
• [ ] included comments for documenting Go code
• [ ] updated the relevant documentation or specification
• [ ] reviewed "Files changed" and left comments if necessary
• [ ] confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

• [ ] confirmed the correct type prefix in the PR title
• [ ] confirmed all author checklist items have been addressed
• [ ] reviewed state machine logic
• [ ] reviewed API design and naming
• [ ] reviewed documentation is accurate
• [ ] reviewed tests and test coverage
• [ ] manually tested (if applicable)

Summary

Problem Definition

e2e tests require app in Docker image. It takes ~5min to build that image.

Proposal

We already build binaries (price-feeder and umeed) in few other jobs. Instead, let's try to reuse it, and change the process of creating a docker by just copying the binaries and libwasmvm into docker ,without downloading all build dependencies etc...

Summary

There was some confusion about if the denom used is symbol or base denom: "For historacle MedianOfHistoricMedians(ctx, denom, numStamps), is denom the token’s base denom or symbol denom? Assuming symbol for now"

Problem Definition

Robert: "we need to add more comments to the proto."

Proposal

Add comments

For Admin Use

• [ ] Not duplicate issue
• [ ] Appropriate labels applied
• [ ] Appropriate contributors tagged
• [ ] Contributor assigned/self-assigned

Summary

In Cosmos SDK 0.47 we already moved away from the Route dependency of LegacyMsg interface. We should remove all Route method from our messages.

To be done once we will integrate 0.47

For Admin Use

• [ ] Not duplicate issue
• [ ] Appropriate labels applied
• [ ] Appropriate contributors tagged
• [ ] Contributor assigned/self-assigned

    how expensive this is? Should not be merged if we don't have a benchmark. Can be commented out and done later.

Originally posted by @robert-zaremba in https://github.com/umee-network/umee/pull/1580#discussion_r1024624616