PR for #14

You shouldn't accept this PR as is, I wanted to show two different options and discuss about which version would be better.

In obs_websocket.gd I added a new if conditional if json_response.has("error") in the _on_data_received function.

You could just send a generic signal with the error and let the client handle it, or you could make a huge match statement with common errors if you want to handle it yourself.

As it is now, the obs_websocket.gd is sending a generic error and the "client" obs_ui.gd is handling what to do with that information.

Found out today that obs-websocket 5 is going to break backward compatibility. See the Important Notice! section.

https://github.com/obsproject/obs-websocket/blob/master/docs/generated/protocol.md

SCRIPT ERROR: Invalid get index 'scenes' (on base: 'Dictionary')

The app halts in the debugger at obs_websocket:198 (if you hit continue it works)

The plugin shows this error in the console but does not halt.

When I start the app it looks like it is connected from the messages in the output window, but the periodic info messages are not displaying so I think it isn't. To "reset" this you have to connect then disconnect then connect again.

If you type your password in wrong, the user is not informed that there is an error nor does the "Connect" button change states.

In obs_websocket.gd we're calling establish_connection already. Currently we're only checking if it connects to the URL and _authenticate is getting information about the error ({error:Authentication Failed., message-id:3, status:error})

Websockets aren't something I'm super familiar with, so I'll play around with this for a bit, but I'm not 100% sure on how to approach this problem. Maybe handle it in _on_data_received and emit an error signal?

PR for #12

Also removed unneeded lines from _on_record_pressed()

Previously, the if condition wasn't being met and an inexplicit else was resetting is_recording back to false.

I decided to use match to read obs_data and only change states when needed.

I also removed some lines in _on_record_pressed as they won't be needed since _on_obs_updated updates the state and text anyway.

It would probably be best to change the SceneItemVisibilityChanged and TransitionEnd to a match as well, but I am not currently switching scenes in my project so I haven't tested those yet.

When the plugin attacheds to OBS it kicks off a data refresh, but this response is often. if not usually, missed becuse another packet came in before the response, this cleared the waiting_for_packet flag so the plugin doesn't process the data packet.

When you click on the switch by the source to enable/disable, it puts a Render swith in a panel above the scenes. From there you can switch the source on and off. Also clicking on a source causes the switch states to change on all. it seems like clicking on the source panel is treating all the sources like a radio button group instead of a multi-select (maybe a copy/paste error from the scene list, because that is the way the scenes are supposed to work? However, it isn't the switch shown in the source's list item that controls it. The button labeled Render that appears at the top does that, but noither is showing an accurate state initially.

Hi! Thanks for the great addon! I am already using it to great effect :) I've noticed there is a bug if I connect to obs, disconnect and tries to reconnect it fails. This line is the problem: https://github.com/you-win/obs-websocket-gd/blob/748f844d2589e04ff06b5ad99d9d32dadd41abe7/addons/obs_websocket_gd/obs_websocket.gd#L182 since the counter goes up and is not 1 anymore after that. I've solved it locally in a hacky way and thought might as well report this.