This draft-pr addresses #3 and adds the following:

• Opens basic search table on clicking <C-s>
• Naive text input option
• Shows a sorted list of symbols based on a searched string, if the string is a prefix of a key in coinIDMap and this symbol has a corresponding id for CoinGecko and CoinCap
• Allows the user to scroll through the list and select a symbol, on which it redirects to its coin page
• Shows basic error message on the incorrect query

Todo

• [ ] Add query based on the full name of the coin
• [ ] Fix blinking "full" character bug ( only exists after one successful search and redirect )

Comments

@Gituser143 Tell me if this implementation looks good, or if you something else in mind. Also, for the search based on the name of the coin, is there a list of full names of coins pulled from the API?

Description

Add functionality to be able to search for coins, either by name or symbol.

Proposed Solution

Add preferably a search window or shortcut to search for coins. Search can be done either naively, or through a regex maybe? (Unsure of how to search).

If you choose to merge this PR, then the README should probably be updated to show new make target too 😎

Also, I know there was no issue for this, but I think it makes the user's life easier. All in the interest of Hacktoberfest 😄

What's changed

• Added build step
• Modified go build flags
  • Added ldflags to strip debugging information
  • Changed goos to linux
  • Disabled cgo at compile time
• Changed final image to alpine
• Added non privileged user

Result:

• Docker image size went from 960MB to 13.9MB
• App no longer runs as root
• The image only contains the basic alpine components and the compiled static binary of cryptgo.

As mentioned in my issue, here is a fix for the docker volume permissions. I have tried many things, but in order to keep the app working as a single binary, and to keep the container rootless, this is what I have come up with.

In the dockerfile I set the HOME env to the home folder of our default user. In the run command I specified the -user flag so that the container runs with the user ID and group ID of the host system user. This way the app remains rootless, and GO recognizes and has write access to HOME. I chose not to remove "appuser" as the default user from the dockerfile for two reasons: 1) We would need to create the home folder anyway and 2) this way if the end user runs the container WITHOUT specifying a user, the app still will not run as root, but default to appuser. (Ofcourse then their changes will not be saved.)

Fixes: #24

Once the currency in which the value is displayed is changed by the user, it should be saved in the config file so that the user doesn't have to reselect the option next time the application runs.

A github action should be setup to build and publish docker images of cryptgo. This will allow cryptgo to be run directly by pulling a docker image instead of building the image locally.

In my previous Pull Request I made an oversight. Because the container is not running as root anymore, it has no rights to write to $HOME, thus no changes are being saved. Im actively working on a solution, but thought I would open an issue regardless so that people are aware of this. Will submit a PR as soon as I found the best solution.

Format in mind

Action Functionalities required

• Update portfolio holdings
• Update currency
• Navigate details table
• Details table sorting

Edit: Currently being worked on in the portfolio branch.

Edit 2: Layout of page has been modified. Top 3 graphs have been replaced a 7 day portfolio value graph.

This PR fixes #4

• Users can now view their portfolio by pressing P on either pages.
• Coins can be added/removed/edited to the portfolio by pressing e on the coin.
• Holdings can be edited from within the portfolio table too.

Fixes #5

• Add display to select the duration for viewing the percentage change
• Fetch map of Symbol to Id from coingecko
• Fetch data for all coin page from coingecko

Look at networking to work out best way to reuse the current api for easy use on gio web and native apps.

also use indexeddb for client storage / cache in gio web. Not sure what golang dB for gio native until I see the data. I suspect it’s time series data ?

Currently the following have mixed combinations of exit and return key-bindings:

• Exit from main page (q and ^C)
• Return from coin page to main page (Esc and q and ^C)
• Exit from coin page (Not Set)
• Return from widget to main page (Esc)
• Exit from widget (q and ^C)

A consistent mapping of q and ^C to quit and Esc to return could be implemented. Or maybe using all three to return to previous page and then exit from the main page.

Currently, the favourites table does not support navigation from within the coin page. It can only be navigated into from the main (all coin) page.

If navigation functionality could be added to the favourites tables from within the coin page, it would be of huge convenience to users. They would not have to return to main page just to switch to a different favourite coin.

Description

The current main page only displays 24 Hr Change %, more fine grained change, like 1 Hr, 2 Hr, 1 Week, etc. changes can be displayed on both the home and coin page.

Proposed Solution

Maybe looking into CoinGecko might be worth it. It has a Go Client too, which can be found here