Where writing a large amount of data, ExecuteRequest need to send multiple http requests. We hope that ExecuteBatchRequest can be used instead of ExecuteRequest to reduce the number of data transmissions as much as possible.

The satori UUID package causes problems with go get and vgo when building multiple database drivers in the same Go application. This is because the satori package introduced breaking API changes and has not tagged it a new version yet.

This change converts the connection ID generation to use the hashicorp UUID package which was already a dependency of this project, as it is a dependency of the gokrb package.

This has the added benefit of reducing the number of total package dependencies by 1.

Additionally, this is needed by github.com/xo/usql so that go get and vgo build both work "out of the box".

The following is a small Go program that demonstrates that the UUIDs generated will be the same format:

package main

import (
	"log"

	guuid "github.com/google/uuid"
	huuid "github.com/hashicorp/go-uuid"
	suuid "github.com/satori/go.uuid"
)

func main() {
	g, err := guuid.NewRandom()
	if err != nil {
		log.Fatal(err)
	}

	h, err := huuid.GenerateUUID()
	if err != nil {
		log.Fatal(err)
	}

	s, err := suuid.NewV4()
	if err != nil {
		log.Fatal(err)
	}

	log.Printf(
		"google: %s, hashicorp: %s, satori: %s",
		g, h, s,
	)
}

avatica sql query fails after running for a period of time on our online loki, this PR attempts to solve this "NoSuchConnectionException" problem.

level=error ts=2022-03-31T12:51:09.356233496Z caller=table_manager.go:233 msg="error syncing tables" err="An error was encountered while processing your request: NoSuchConnectionException{connectionId='Connection not found: invalid id, closed, or expired: ccd95a16-5496-7001-f99b-1ab0e5f19e05'}"

What

• adds an implementation for driver.Connector to the project.
• allows passing in arbitary infos and headers to do all kinds of auth stuff

Why

• we want to use that driver to connect to an endpoint behind an auth proxy and need to add some headers.
• Now its possible to attach other infos than the default ones to the connection to make it possible for a wrapping layer around to act accordingly

This adds the same nil checks while parsing errors as in connection.go I added a few days ago. I'm greping around to find more missing nil checks, but these are the only three related to GetMetadata() that I could find.

avatica sql query fails after running for a period of time on our online loki, this PR attempts to solve this "NoSuchConnectionException" problem.

level=error ts=2022-03-31T12:51:09.356233496Z caller=table_manager.go:233 msg="error syncing tables" err="An error was encountered while processing your request: NoSuchConnectionException{connectionId='Connection not found: invalid id, closed, or expired: ccd95a16-5496-7001-f99b-1ab0e5f19e05'}"

when i used avatica-go, i can't change the httpclient's idleConnTimeout, it is set to 90 seconds alway, in my project, i need a longer idleConnTimeout value, so i commit this pr to enable configuration some httpclient params. The params can defined in http url params like 'maxRowsTotal' as same as before. When http params is not defines this httpclient params, they also have default value same to before. One thing i confused is, i determine the min value of these params, but i'm not sure if I want to give a limit to the maximum value, and what should be the maximum limit for each value

Enables connecting to longer URLs - for example if a proxy is being used in front of PQS.

Previous behavior: take any string in the URL path as the schema

New behavior: take the string following the last / in the URL path as the schema

Currently the generic adapter in the calcite-go driver panics when it sees an unknown type.

I as a user of the driver would like to see it either just working as expected or at least see a meaningfull error.

This PR adds a default scan type in the case that the column type is not recognized.

What

• save all the query parameters from the DSN in the config object
• map these parameters to the info object of the OpenConnectionRequest message

Why

This way we can supply arbitary additional parameters for usecase specific backend behavior. Currently we are using this to specify the scope of the operation (which DB in particular)

fix index ount of bound panic. https://github.com/grafana/loki/pull/5692/ [new feature] Index: loki support apache calcite avatica index storage. #5692

I implemented the index storage plugin of apache avatic in the grafana loki community, and found that avatica-go would panic in the online environment. This PR attempts to fix this panic. Our online loki has been fixed.

panic: runtime error: index out of range [0] with length 0 
	/usr/local/go/src/runtime/panic.go:1038 +0x215
github.com/apache/calcite-avatica-go/v5.(*rows).Columns(0x4cc4b7)
	/Users/fuling/go/pkg/mod/github.com/liguozhong/calcite-avatica-go/[email protected]/rows.go:55 +0x17b
database/sql.(*Rows).nextLocked(0xc038348000)
	/usr/local/go/src/database/sql/sql.go:2964 +0xb0
database/sql.(*Rows).Next.func1()
	/usr/local/go/src/database/sql/sql.go:2945 +0x2f
database/sql.withLock({0x32a6008, 0xc038348030}, 0xc004cb76f0)
	/usr/local/go/src/database/sql/sql.go:3396 +0x8c
database/sql.(*Rows).Next(0xc038348000)
	/usr/local/go/src/database/sql/sql.go:2944 +0x6f
github.com/grafana/loki/pkg/storage/chunk/avatica.(*StorageClient).query(0xc001024ea0, {0x32d98a8, 0xc0188ef320}, {{0xc00589f300, 0x1e}, {0xc01bc60990, 0x2b}, {0x0, 0x0, 0x0}, ...}, ...)

code in loki, for rows.Next() { panic.

case query.ValueEqual != nil:
		querySQL = fmt.Sprintf("SELECT range, value FROM %s WHERE hash = ? AND value = ? ALLOW FILTERING",
			query.TableName)
		queryFunc = func() error {
			rows, err = s.readSession.QueryContext(ctx, querySQL, query.HashValue, query.ValueEqual)
			return err
		}
	}

	retries := backoff.New(ctx, s.cfg.BackoffConfig)
	err = ctx.Err()
	for retries.Ongoing() {
		err = s.queryInstrumentation(ctx, querySQL, queryFunc)
		if err == nil {
			break
		}
		retries.Wait()
	}
	if err != nil {
		level.Error(util_log.Logger).Log("msg", "avatica QUERY fail", "sql", querySQL, "err", err)
		return errors.WithStack(err)
	}
	defer rows.Close()
	for rows.Next() {
		b := &readBatch{}
		err = rows.Scan(&b.rangeValue, &b.value)
		if err != nil {
			return errors.WithStack(err)
		}
		if !callback(query, b) {
			return nil
		}
	}

func (s *StorageClient) queryInstrumentation(ctx context.Context, query string, queryFunc func() error) error {
	var start time.Time
	var end time.Time
	var err error
	sp := ot.SpanFromContext(ctx)
	sp.SetTag("sql", query)

	defer func() {
		statusCode := "200"
		if err != nil {
			level.Warn(util_log.Logger).Log("msg", "avatica query fail", "sql", query, "err", err)
			statusCode = "500"
			ext.Error.Set(sp, true)
			sp.LogFields(otlog.String("event", "error"), otlog.String("message", err.Error()))
		}
		parts := strings.SplitN(query, " ", 2)
		requestDuration.WithLabelValues(parts[0], statusCode).Observe(end.Sub(start).Seconds())
	}()
	start = time.Now()
	err = queryFunc()
	end = time.Now()
	if err != nil {
		return errors.WithStack(err)
	}
	return nil
}