I previously asked about adding support for transforming images between ICC profiles and it was suggested that suggested I make a pull request. I was able to get the vips_icc_transform function working with an ICC profile that I supplied externally. If you have a Mac, the built-in color profiles are located at /System/Library/ColorSync/Profiles/.

I was able to take an image with an embedded Display P3 color profile and transform it to both an sRGB version and a Display P3 version without breaking it.

Please let me know what you think and if you have any feedback!

This PR adds several APIs that exist already at the libvips layer but were not exposed by govips which allow us to read and write EXIF fields. For images like JPEGs which support regular EXIF data, the exif-data image field can be read out as a blob or the individual fields can be parsed via their respective field names. For images like TIFFs without direct EXIF support, you can also extract the newer XMP metadata as a blob.

Also while I was testing with TIFF images I found a bug where TIFF images always defaulted to a resolution 1.0 Pixels-Per-Millimeters (about 25PPI). The resolution doesn't really affect the image itself -- just how large it should be printed. The canonical way to change this with libvips is to copy the image changing the xres / yres fields to the desired value. I removed the strange TIFF behavior so that the original resolution (different than pixel dimensions) will be preserved and it can be set to the desired value with the new API.

We are using this benchmarking code through govips for basic operation of creating black images (https://pkg.go.dev/github.com/davidbyttow/govips/v2/vips#Black).

func BenchmarkVipsBlack(b *testing.B) {
	for n := 0; n < b.N; n++ {
		_, _ = vips.Black(100, 100)
	}
	vips.PrintCache()
	vips.PrintObjectReport("BenchmarkVipsBlack")
	vipsMemStats := &vips.MemoryStats{}
	vipsRuntimeStats := &vips.RuntimeStats{}
	vips.ReadVipsMemStats(vipsMemStats)
	vips.ReadRuntimeStats(vipsRuntimeStats)
	golog.Logger.Info(fmt.Sprintf("VIPS Runtime Stats: %+v", vipsRuntimeStats))
	golog.Logger.Info(fmt.Sprintf("VIPS Memory Stats: %+v", vipsMemStats))
}

The response for this as mentioned below -

vips live objects: BenchmarkVipsBlack...
2 objects alive:
0) VipsBlack (0x12d840e10), count=1
VipsBlack (black), make a black image, black out=((VipsImage*) 0x13900b000) width=100 height=100 -
1) VipsImage (0x13900b000), count=1
VipsImage (image), image class, 100x100 uchar, 1 band, multiband
2022/11/23 18:44:22 [govips.info] 
2022-11-23T18:44:22.566+0530    INFO    VIPS Runtime Stats: &{OperationCounts:map[]}
2022-11-23T18:44:22.566+0530    INFO    VIPS Memory Stats: &{Mem:0 MemHigh:0 Files:0 Allocs:0}
goos: darwin
goarch: amd64
pkg: irs/imagerendering
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkVipsBlack-12           Operation cache:
2022/11/23 18:44:22 [govips.info] 
=======================================
vips live objects: BenchmarkVipsBlack...
22 objects alive:
0) VipsBlack (0x139009540), count=1
VipsBlack (black), make a black image, black out=((VipsImage*) 0x13900b7d0) width=100 height=100 -
1) VipsBlack (0x10500e100), count=1
VipsBlack (black), make a black image, black out=((VipsImage*) 0x13900e340) width=100 height=100 -
2) VipsBlack (0x10500e000), count=1
VipsBlack (black), make a black image, black out=((VipsImage*) 0x13900e020) width=100 height=100 -
3) VipsBlack (0x1390096c0), count=1
VipsBlack (black), make a black image, black out=((VipsImage*) 0x13900bc80) width=100 height=100 -
4) VipsImage (0x13900be10), count=1
VipsImage (image), image class, 100x100 uchar, 1 band, multiband
5) VipsImage (0x13900e4d0), count=1
VipsImage (image), image class, 100x100 uchar, 1 band, multiband
6) VipsBlack (0x1390095c0), count=1
VipsBlack (black), make a black image, black out=((VipsImage*) 0x13900b960) width=100 height=100 -
7) VipsBlack (0x12d840e10), count=1
VipsBlack (black), make a black image, black out=((VipsImage*) 0x13900b000) width=100 height=100 -
8) VipsImage (0x13900baf0), count=1
VipsImage (image), image class, 100x100 uchar, 1 band, multiband
9) VipsImage (0x13900bc80), count=1
VipsImage (image), image class, 100x100 uchar, 1 band, multiband
10) VipsImage (0x13900e020), count=1
VipsImage (image), image class, 100x100 uchar, 1 band, multiband
11) VipsBlack (0x1390094c0), count=1
VipsBlack (black), make a black image, black out=((VipsImage*) 0x13900b640) width=100 height=100 -
12) VipsImage (0x13900b7d0), count=1
VipsImage (image), image class, 100x100 uchar, 1 band, multiband
13) VipsImage (0x13900b960), count=1
VipsImage (image), image class, 100x100 uchar, 1 band, multiband
14) VipsImage (0x13900b640), count=1
VipsImage (image), image class, 100x100 uchar, 1 band, multiband
15) VipsBlack (0x139009740), count=1
VipsBlack (black), make a black image, black out=((VipsImage*) 0x13900be10) width=100 height=100 -
16) VipsBlack (0x10500e080), count=1
VipsBlack (black), make a black image, black out=((VipsImage*) 0x13900e1b0) width=100 height=100 -
17) VipsImage (0x13900e1b0), count=1
VipsImage (image), image class, 100x100 uchar, 1 band, multiband
18) VipsBlack (0x139009640), count=1
VipsBlack (black), make a black image, black out=((VipsImage*) 0x13900baf0) width=100 height=100 -
19) VipsImage (0x13900e340), count=1
VipsImage (image), image class, 100x100 uchar, 1 band, multiband
20) VipsImage (0x13900b000), count=1
VipsImage (image), image class, 100x100 uchar, 1 band, multiband
21) VipsBlack (0x10500e180), count=1
VipsBlack (black), make a black image, black out=((VipsImage*) 0x13900e4d0) width=100 height=100 -
2022/11/23 18:44:22 [govips.info] =======================================

2022-11-23T18:44:22.568+0530    INFO    VIPS Runtime Stats: &{OperationCounts:map[]}
2022-11-23T18:44:22.568+0530    INFO    VIPS Memory Stats: &{Mem:0 MemHigh:0 Files:0 Allocs:0}
      10        111271 ns/op         891 B/op      5 allocs/op
PASS
2022-11-23T18:44:22.571+0530    INFO    vips has been shutdown
ok      irs/imagerendering      0.933s

As mentioned in the response above, 22 objects are alive. @davidbyttow is this response expected or is this an indication of some memory leak.

The above code ran for 10 iterations as mentioned in the results above.

I was trying to process some animated GIFs - which are supported by libvips - but realized that doing so requires some changes in this library: 1) passing parameters to loaders, 2) extracting some additional metadata from images (e.g. the number of pages), and 3) supporting the magick writer.

I started taking a stab at (1), the only parameter that's missing is the "background" for PDF (I may add it - didn't want to figure out how it works just yet). While I was at it I also added the ability to use magick as loader.

I'll add tests of course, but I wanted to see if this PR may be accepted and agree on design first.

govips produces 20% - 40% larger image file sizes than sharp (node equivalent) does for the same image dimensions and the same Lanczos3 kernel.

Please check if govips is producing the optimal file size since both are using the same libvips backend.

Thanks.

Inspired by: https://github.com/davidbyttow/govips/pull/155

However, this doesn't use libvips options yet. My intent is to likely switch to using VImage options (rather than C vararg functions) for import and export parameters, but I wanted to get this exposed and working first.

Related to https://github.com/davidbyttow/govips/issues/147

I created ImportParams struct with fields:

• Fail
• AutoRotate
• Shrink

All of them is optional and by default don't set on ...load_buffer call. By the same way can be added any other optional field.

I am having a memory leak with govips. Any suggestions how to solve this?

after several images

Allocated Memory = 104 MiB	Total Allocated Memory = 144 MiB	System Memory = 134 MiB	Number of GC = 7
VIPS Allocated Memory = 114 MiB	VIPS Total Allocated Memory = 121 MiB	VIPS Memory Allocations = 2 

Allocated Memory = 104 MiB	Total Allocated Memory = 288 MiB	System Memory = 134 MiB	Number of GC = 15
VIPS Allocated Memory = 171 MiB	VIPS Total Allocated Memory = 178 MiB	VIPS Memory Allocations = 3 

Originally posted by @evanoberholster in https://github.com/davidbyttow/govips/issues/44#issuecomment-435683155

jcupitt explains the mozjpeg parameters in this comment: https://github.com/libvips/libvips/issues/1422#issuecomment-530032329

Additionally, look for references to mozjpeg in the documentation for vips_jpegsave(): https://libvips.github.io/libvips/API/current/VipsForeignSave.html#VipsForeignJpegSubsample

These changes improved jpeg compression for my test image, especially with the addition of overshoot_deringing when compressing a screenshot that includes text.

Hi there,

import "bytes"
import "image"
import "image/color"
import "image/png"
import "image/draw"

im := image.NewRGBA(image.Rect(0, 0, 100, 100))
draw.Draw(im, im.Bounds(), image.NewUniform(color.NRGBA{255, 0, 0, 255}), image.ZP, draw.Src)
var buff bytes.Buffer
err := png.Encode(&buff, im)

vipsImage, err := vips.NewImageFromBuffer(buff.Bytes())

[govips.info] failed to understand image format size=26149

Any suggestions how to solve this?

Back in February, John helped me add support for loading and saving 8/10/12 bit HEIC and AVIF files to libvips here: https://github.com/libvips/libvips/pull/2596

Now with the release of iOS 16 / MacOS Ventura which support AVIF images natively, I want to add support for them to my app.

I asked about this a while ago here: https://github.com/davidbyttow/govips/issues/313 and finally had some time to implement it myself.

The changes in this PR are as follows:

• I cleaned up the HEIF / AVIF export parameters so they both now take a Bitdepth parameter like PNGs. Also libvips has renamed "speed" to "effort" so I migrated us to use that parameter name with backwards support for the speed parameter for code that used it.
• I added golden image tests for 8bit AVIF and encoding a 16bit TIF to a 12bit AVIF.
• The files I touched got auto formatted by gofmt so we should probably just commit those changes to avoid annoying future PR authors.

I tried to add support for vips_hist_find() which seems to have worked. I wanted to add vips_max (or something like maxpos) as well but I don't really understand the C API in the first place.

This is more a feature request then I guess ;-)

Hi, Is there an option to build it with a static flag?

That's my Dockerfile and it core-dumps on me or throws linker error `FROM golang:alpine as builder

RUN apk add musl-dev vips-dev gcc

WORKDIR /src COPY . .

RUN go build -o /bin/app --ldflags '-linkmode external -extldflags=-static' . `

This config option allows the caller to specify a preexisting temporary directory instead of relying on the ability to create one at runtime. This can be important in setups where a shell or mkdir are unavailable at runtime.

We have a use-case where we would like to create a new image based off raw RGB data. Vips does have support for this via the new_from_memory function (or better yet new_from_memory_copy), e.g.:

vips::VImage out = vips::VImage::new_from_memory (data, length, width, height, 3, VIPS_FORMAT_UCHAR);

Hello all, Do you think exposing the fallback input ICC profile would make sense?

Currently, the TransformICCProfile() function takes only one parameter - the output profile. The input profile is a hardcoded sRGB one.

While this is a clean solution and would cover 98% of all use cases, it does not permit to deal with some "broken" images like CMYK images without ICC profiles. And there is no control over color transformations on any images without embedded profiles.

I would expect that such an addition would also provide a solution to this issue (https://github.com/davidbyttow/govips/issues/275).

Alternatively, someting can be done for OptimizeICCProfile()? Again, nothing can do any good for CMYK images without ICC profiles.

I would appreciate your input.

Im trying to create a empty transparent canvas that i can add images on.

right now i am resorting to

	c := image.NewNRGBA(rectangle)
	buf := &bytes.Buffer{}
	if err := png.Encode(buf, c); err != nil {
		panic(err)
	}
	canvas, err := vips.NewImageFromBuffer(buf.Bytes())
	if err != nil {
		panic(err)
	}

which feels toaly backwards.

I have tried using vips.Black() but it only gives me a black image and when i try to draw using img.Insert(), the whole image is still just black

if i do canvas := &vips.ImageRef{} i cannot propagate all fields needed for it to work

Any smart things i've missed in the lib?

Cheers and thanks!