this is required to allow go-couchbase to write to buckets other than default

all the changes from "dustin" to "mschoch" are unfortunate, but i didn't see a good way around that to easily test my changes and eventually send a pull request. perhaps you can suggest a better workflow.

also, this is my first go.

Hi,

First thanks for this piece of code (and for memcache). You seems to be the only go memcache binary client out there!

I'm just wondering if i should use only one connection (memcached.Connect) and use it in every goroutine (are connections goroutine safe?) or should i use one connection per goroutine or ...

Also is the readme still accurate (There is currently no work at all in making the thing perform (there are specific areas I know need work). This is just my attempt to learn the language somewhat.)?

Are you or other people succesfully using it "in production"?

Thanks in advance

Normally CAS isn't checked in the success cases, except when waiting on data to be persisted. Peviously the library failed to update the CAS value on success causing WriteUpdate calls with the Index/Persist flags set to always fail with ErrOverwritten.

These were false errors, as the library was always using the pre-modification CAS value as input into the observe function instead of the post-modification CAS value.

https://github.com/dustin/gomemcached/blob/master/client/mc.go#L389

Why is this done? It appears to ignore the expiry value passed in and reset it to 0.

In our system, this leads to updated keys never expiring. The fix is easy, but wondering why this was done in the first place?

When installing go-couchbase, it installs this package as well and it fails saying this.

# github.com/dustin/gomemcached/client
/usr/lib/go/src/pkg/github.com/dustin/gomemcached/client/mc.go:339: function ends without a return statement
/usr/lib/go/src/pkg/github.com/dustin/gomemcached/client/tap_feed.go:110: function ends without a return statement

Right now, all commands return "unknown command". It should be trivial to implement a new module that dispatches based on opcode lookup in a map or even array.

Hi! What about license for the code? Please, add one. I think BSD-style license is a good choise. Go (http://golang.org/LICENSE) and a lot of go libraries use it.

Saw this crash:

github.com/dustin/gomemcached/client.(*Client).Transmit(0x0, 0xf8401c52d0, 0xf8401bf740, 0x1e0000001e, 0xf8402bb610, ...)
        /Users/dustin/go/src/github.com/dustin/gomemcached/client/mc.go:68 +0x29
github.com/dustin/gomemcached/client.(*Client).GetBulk(0x0, 0x3d9, 0xf8402c9000, 0x100000001, 0x0, ...)
        /Users/dustin/go/src/github.com/dustin/gomemcached/client/mc.go:231 +0x349
github.com/couchbaselabs/go-couchbase.(*Bucket).doBulkGet(0xf8400fd500, 0xf8401003d9, 0xf8402c9000, 0x100000001, 0xf84014e5a0, ...)
        /Users/dustin/go/src/github.com/couchbaselabs/go-couchbase/client.go:179 +0x171
created by github.com/couchbaselabs/go-couchbase.(*Bucket).GetBulk
        /Users/dustin/go/src/github.com/couchbaselabs/go-couchbase/client.go:210 +0x2fb

Hi, Dustin: First of all, please forgive me for not being good in English. Memcached binary protocol: Increment, Decrement, version have response:

• MUST NOT have extras.
• MUST NOT have key.
• MUST have value.

This bug causes the body bytes not to be read. version doc

In MCRequest.Receive, a new buffer is allocated for every receive for the body of the request:

buf := make([]byte, klen+elen+bodyLen)

It would be great if this function could instead accept a buffer as an argument so that buffers could be re-used across requests. The code could use cap(buf) to ensure that the buffer is long enough, and buf = buf[:klen+elen+bodyLen] to limit its length. Only if it buf is too small should it allocate its own (and potentially warn the caller that the buffer was not used).

This is the error message:

MCResponse status=UNKNOWN_COMMAND, opcode=SASL_LIST_MECHS,
 opaque=0, msg: Unknown command

This is the code:

func Memcache() {
    client, err := memcached.Connect("tcp", "127.0.0.1:11211")
    if err != nil {
        log.Fatalf("Error connecting: %v", err)
    }

    resp, err := client.Auth("memcache", "password")
    if err != nil {
        log.Fatalf("auth error: %v", err)
    }
    log.Printf("Auth response = %v", resp)
}