The AddChangeIfNeeded of TxBuilder calls tx.build() inside which does a transaction signing. Calling tx.Build() at this stage is an awkward way of verifying transaction, especially when the build function mostly does transaction signing.

Note that after AddChangeIfNeeded is called, we still need to build the transaction again and therefore do the signing twice. In general, we should only do transaction signing once when all data is available.

Can we remove tx.build() in AddChangeIfNeeded ?

I think this min value calculation for multiasset transaction is incorrect:

func (tb *TxBuilder) MinCoinsForTxOut(txOut *TxOutput) Coin {
	var size uint
	if txOut.Amount.OnlyCoin() {
		size = 1
	} else {
		numAssets := txOut.Amount.MultiAsset.numAssets()
		assetsLength := txOut.Amount.MultiAsset.assetsLength()
		numPIDs := txOut.Amount.MultiAsset.numPIDs()

		size = 6 + uint(math.Floor(
			float64(numAssets*12+assetsLength+numPIDs*28+7)/8,
		))
	}
	return Coin(utxoEntrySizeWithoutVal+size) * tb.protocol.CoinsPerUTXOWord
}

I have a multi-asset input and my values are as follow:

numAssets = 1, assetsLength = 8, numPIDs = 1, utxoEntrySizeWithoutVal = 27, tb.protocol.CoinsPerUTXOWord
 = 4310

Total coin amount = 168090 (or 0.16809 ADA)

This number is clearly smaller than min 1.3 ADA required to transfer multiasset. I got BabbageOutputTooSmallUTxO error when submitting this. Please check this function again for multi-asset

This closes #37 This closes #38

This will add some minimal (opinionated) helper functions regarding bech32 (also exposing these) and stake address management. The core of this proposal is the tx builder improvement to be able to set in advance a number of expected witness aiming for the correct fee calculation, allowing us to build a tx that is partially signed.

In my case I am using it to build a tx that include a stake delegation cert, and the only "payment" input is owned by someone that is not the owner of the stake key. In this way I prepare in the backend the tx (paying the delegation tx fee) and propose the 3rd part to sign the tx w/o spending nothing.

I guess the code is more clear that my explanation.

This unit test is setting transaction body inputs to empty https://github.com/echovl/cardano-go/blob/fd832fe8c7114cf9ea81b549b562bdfaab50aeb8/tx_test.go#L84? Any problem with serializing/deserializing for the map in cbor?

Hello,

We are trying to sign transactions using the library and we came across an issue with signatures:

Given the following private key (only has 5 testnet ADA):

bc4070aa2ac9883c1f61a46e8f9e06bb7a432211f3689125c3d6e8c136b270e8

Using the following procedure, we try to sign the hash of the transaction:

  var psk crypto.PrvKey
  var ssk crypto.PrvKey

  psk, _ = hex.DecodeString(paymentSkey[4:])
  ssk, _ = hex.DecodeString(stakeSkey[4:])

  var tx cardano.Tx

  bytes, err := hex.DecodeString(transactionCBOR)

  if err != nil {
    log.Fatal(err)
  }

  cbor.Unmarshal(bytes, tx)

  txHash, err := tx.Hash()

  fmt.Println("SKEY: ", paymentSkey[4:])
  fmt.Println("TXHASH: ", hex.EncodeToString(txHash))
  fmt.Println("PUBKEY: ", hex.EncodeToString(psk.PubKey()))

This results in:

SKEY:  bc4070aa2ac9883c1f61a46e8f9e06bb7a432211f3689125c3d6e8c136b270e8
TXHASH:  0f1b6d09c85eaec039f086c96c5dfc05adc4ca413e2886bd08e72a8c2cafc03f
PUBKEY:  18be1cd172326473a80b085008101b999d85f1f3610f297cd36268ee064d6082
PKH:  8afcd22c9c898f6c1e244419ba52f4b1ed91c1cfbbcfff6eaf1a769c

a1008282582018be1cd172326473a80b085008101b999d85f1f3610f297cd36268ee064d608258405c30ce7ceb5f358cae1055aaaf0d09cec17ec8c39bdf2e23f05f1b405dc3cb71df263408038f8546b5b33d4c2c22046e6ffd594c6edb094c67bfcfc0c0a8310f825820baa5f44a3de96cf55d0cfa0b6a2ad4df94b37d88fa9dbad0111af2cc68cd31f15840fcb1ba2be3778f1bf5410dfa95a3a9b5221a245646146fc6d35931d24ba0efb33cd6426142cd8784e8aa856da44b603ea74ff0e9dc3002085645807313a2b30c

Transaction signing is not working for me right now using that.

However, another library pycardano produces the following:

Python 3.9.13 (main, May 24 2022, 21:13:51) 
[Clang 13.1.6 (clang-1316.0.21.2)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from pycardano import *
>>> psk = PaymentSigningKey.from_cbor("5820bc4070aa2ac9883c1f61a46e8f9e06bb7a432211f3689125c3d6e8c136b270e8") # 5820 prefix is just CBOR for 'bytes'
>>> psk.to_verification_key().to_primitive().hex()
'448601922876ffa826afebc1dbd2cc1affa4fd6efc65056f9db6dfb958fe1803'
>>> tx_hash = b'0f1b6d09c85eaec039f086c96c5dfc05adc4ca413e2886bd08e72a8c2cafc03f'
>>> psk.sign(tx_hash).hex()
'dd9276eb0f51ec1f3a2c0d764b797ef8423b376e8ee43ac8016c9de6613cde61692d16d38589b8e62471e015f13df1c362c3a369a41719ea1aca43342e2c9601'
>>> 

What am I missing?

it seems generate not the same as the bussiness Haskell one ,if the mnemonic is 12 words

the payment address its not the same with https://github.com/input-output-hk/cardano-addresses generate , which use the same mnemonic

We can't just ignore the policy id here. When two assets with different policies have the same name (eg default values like "Asset 1" or empty, this overwrites previously set values and returns wrong results)

This repo currently only supports old testnet. We need to add support for preprod.

I can create a PR for this repo as I already has the PR in my forked version

hey every one i charge my testnet address that generated by this package wallet but when i call balance method i get 0 . i guess that it's because of socket path that not set in variable 'CARDANO_NODE_SOCKET_PATH'

how we should do that ?

This PR add new network type preprod for testnet. The blockfrost API server does not have preprod type yet, so we have to hardcode the blockfrost API URL for preprod.

This could be extended to support Testnet Preview

Close https://github.com/echovl/cardano-go/issues/35

@echovl

Fixes #31

Two points aren't fixed:

• Calculation doesn't care about dataHashSize (see min-utxo-alonzo)
• Calculation after alonzo-era is missing (see pycardano and cardano-ledger)

I suggest to close this issue and open another one as feature.

This PR includes:

• Deprecate Wallet.Addresses() and replace it with Wallet.EnterpriseAddresses()
• Deprecate Wallet.Keys() and replace it with Wallet.PrvKeys()
• New Wallet.BaseAddresses()
• StakeAddress support for Address and Wallet
• Add PoolCost in poolRegistration struct

closes #45 closes #20

• allow to set additional witnesses for partially signed tx preparation
• change calculateMinFee to consider additional witnesses that will increase the tx length. It is still not clear how to precisely calculate the bytes for witnesses, in this implementation for each additional witnesses there will be an additional 100 bytes, (32 public key, 64 signature, 4 index/key in cbor). Those are not actually enough so we are considering 1 additional byte for each additional witness after the first.

I would like to be able to create a transaction that include delegation certificate for a 3rd party (the stake key owner) that will sign the tx lately. To do so the address package should be improved to facilitate the management of stake addresses (aka reward addresses), and allow the tx builder to know that the transaction will be signed by a well known number of witnesses in advance, to be able to calculate fees correctly.

Would be good to have some basic functions exposed as package that can be imported from other project, including the CIP-5 prefixes. This could be useful to eventually implement some basic "marshaling machinery" in project that are using cardano-go.