A simple server which can be used as an RPC endpoint in popular Ethereum wallets.

The current RPC endpoint doesn't go far enough in sanctioning bad people and bad addresses as this only covers one region of the world (USA). The world is much larger and we should account for possible sanctions in every corner of the globe and not just one country. This of course would be the most fair way of handling this so that one country doesn't receive undue preference.

I've made a start by adding the only current UK sanctioned address, seen here: https://docs.fcdo.gov.uk/docs/UK-Sanctions-List.html

I am willing to also add the same sanctions checking for other regions such as Russia, China, and North Korea (non-inclusive, just for example) if anyone is able to point me in the direction of their sanctions lists.

Todo:

• [x] Rename bundle-id to something better
• [ ] Test & merge #50
• [x] Add maximum number of 15 tx per key (using ltrim)
• [x] Intercept eth_getBalance and return 1 ETH
• [x] Add a method for users to retrieve the cached keys (simple REST API?)
• [x] Add e2e tests
• [x] Test on staging

https://rpc.flashbots.net/fast txn fail after 25 blocks, then mined 90 minutes later. ( No any changes made at my side after the 25 blocks , no matter gas or endpoint)

Miner is Ethermine.

As per https://protect.flashbots.net/

• fastMode":true,"seenInMempool":false,"simError":"MaxFeePerGasTooLow"}

maxBlockNumber xxxxxx Which is far less than the actual block number.

It's not 1st time that Ethermine mined my failed txns after 25 blocks drop in fastmode , it happened twice in last 8 hours , is this a bug or something else?

( my Txns were always failed at flashbot normal mode , so all of my 50 + Txns were through fast mode up to now)

Thanks

1. Handle parallel batch request
2. Divide RPCRequest as RpcRequestHandler & RpcRequest
3. Introudce waitgroup & go routine to handle the batch request in parallel

I'm not sure if this is the correct repo for this issue but it seemed the most fitting out of the exisiting flashbots repos, please redirect me to the right repo if this is not the place for it.

As per the title, when sending bundles to https://relay-goerli.flashbots.net, calling flashbots_getBundleStats returns the below error:

RelayError(
  ResponseSerdeJson {
    err: Error("data did not match any variant of untagged enum ResponseData", line: 1, column: 55),
    text: "{\"id\":6,\"result\":{\"isSimulated\":false},\"jsonrpc\":\"2.0\"}",
  }

I tried using both bundles that aren't included and also bundles that end up being included both fail with the same above error.

Although I’m not sure yet if related, it's worth noting I'm using ethers-flashbots to perform the request.

Hi Flashbots,

I'd originally attempted to submit a PR https://github.com/flashbots/rpc-endpoint/pull/96 without first realising that the contribution guidelines stated that I must first submit an issue. Unfortunately my PR was closed without any rationale on why, nor any pathways to rectify this. While the wording was tongue-in-cheek (I acknowledge) the intent was transparent and I believe that you there is a strong case to be made for expanding the sanctions checking to nations other than the U.S.

My problems with this process so far:

• Your approach to sactions maintenance is completely undocumented.
  • effect: how was I meant to know that this PR isn't helpful? Do you only consider sanctions from the U.S. to be valid?
• Your approach to rectifying this PR is unhelpful.
  • effect: what was the issue with this PR? Why was it closed?

Despite the comments on the PR being spam-like, and brigade-like I would like to make the case to open this PR based on the following:

• AFAIK, Flashbots is an international organisation with members around the world, as noted in #92.
• This is an honest, in essence, attempt to level the playing field on the sanctions handling: I have not invented the sanction address and this is very much a real, legally binding sanction from the UK government. Nor am I attempting to conceal it's weight, it is equally as valid as that of OFAC. It just happens to not be the U.S. government.

While I'd like to be wrong, it feels disappointing to see any project hide behind contribution guidelines for discouraging conversation and to ensure that my next attempt meets all contribution guidelines I am creating this issue before re-raising the PR.

您好，我最近发现您正在添加美国审查员名单。 请添加我们的列表作为可选标志； 它禁止想要主宰我们星球的敌对人士。 这些都是坏人； 还好他们不能参与网络。

我很乐意将其视为默认标志。

这种改变对中国人和朝鲜人来说是绝对必要的。 制裁名单包括无缘无故对我们怀有敌意并想要战争的公司的地址。 它还包括乌克兰捐赠基金。

问候

Without omitempty, result field is serialized even when not populated, causing jsonrpc_core crate to fail deserializing failure response:

https://docs.rs/jsonrpc-core/latest/jsonrpc_core/types/response/struct.Failure.html (it denies deserialization if unexpected fields like result exist)

This PR adds omitempty in order to align with the general expectations.

• Improved Metamask failed tx handling
  • Added support for DEBUG_DONT_SEND_RAWTX environment variable, which will fake sending rawTransactions (returns the tx hash like on success, but doesn't forward it to relay/mempool). This triggers the Metamask failed transaction flow immediately, without needing to wait for a tx to expire.
  • Block transactions with 1e9+ nonce with an error that leads Metamask to drop a transaction immediately
  • Only triggering nonce fix on the latest transaction of a specific sender address
• Introduction of a state struct which ill be used to put state into Redis in the future
• Code cleanup: remove artifacts of legacy infra, dead codepaths, some simplifications
• Allow immediate resubmission of a tx to the relay once state is "FAILED" (don't need to wait for any additional amount of time)
• Better handle errors from the relay

Problem

Currently, both https://rpc.flashbots.net/ and https://rpc.flashbots.net/fast redirect to the same docs page although I think it's more expected to have a redirect to fast mode related page for /fast endpoint.

If it's an expected behaviour, you can close the PR 😄

Solution

➜  ~ curl -v -L localhost:9000 2>&1 | grep -i "^< location:"
< Location: https://docs.flashbots.net/flashbots-protect/rpc/quick-start/

➜  ~ curl -v -L localhost:9000/fast 2>&1 | grep -i "^< location:"
< Location: https://docs.flashbots.net/flashbots-protect/rpc/fast-mode/

The endpoint payload must currently be a single JSON-RPC request.

Infura and others also support a list of requests. Would be nice to support this in the endpoint too.

Summary

I propose that a new command line argument be added that allows users to set the sanctions list of their choosing. The default OFAC sanctions list would be removed.

Proposed usage:

go run cmd/server/main.go -redis REDIS_URL -signingKey ETH_PRIVATE_KEY -proxy PROXY_URL -blocklist BLOCKLIST_PATH_OR_URL

Example 1:

go run cmd/server/main.go -redis REDIS_URL -signingKey ETH_PRIVATE_KEY -proxy PROXY_URL -blocklist ~/sanctions.jsonc

/* filename: sanctions.jsonc */
[
    "0xdead",
    "0x1234",
    "0x0" // You get the point
]

JSON-C was used as an example, but YAML, JSON, or just a newline-separated file could also be acceptable file formats. Do whatever is easiest to develop, as long as this feature is implemented.

Example 2

go run cmd/server/main.go -redis REDIS_URL -signingKey ETH_PRIVATE_KEY -proxy PROXY_URL -blocklist https://someusgovmtwebsite.gov/blocklist.txt

URIs should be allowed as well as files.

We (the Ethereum ecosystem) are building censorship resistant software. We are not building software that censors people out of the gate. If we wanted that, we would just use the fiat banking system and accept that people all over the world are unbanked due to censorship of various governments.

If we support the OFAC blacklist, why not the equivalent Chinese or Russian blacklist? The whole point of this endeavor (Ethereum, crypto-currency, etc.) is to get away from censorship and this code just embeds it. If MEV-Boost is going to be a core part of Ethereum's infrastructure, it should be written to be censorship resistant from the ground up.

If individual relayers, proposers, or builders want to run with a blacklist then they are welcome to do that and they can choose to support the totalitarian regime of their choice. It should not be part of the codebase that you are seeking to get "blessed" by the broader Ethereum community though.

Some contracts, like 0x8fc73419de427f8a5285484a800a85509c6ea385, have a front-runnable function call with no call data. It might be better to check for "is contract" instead of "is calldata 0x".