http://gobook.io/read/github.com/go-tango/manual-zh-CN/chapter-06/ 文档中的 tg := tango.New() tg.Get("/index.html", tango.File("./public/index.html")) tg.Run() 这一部分不能正确访问到index.html

当按以下运行时，当我访问"http://localhost:8080" 会跳转到index.html页面，而没有进入getHandler tg.Get("/", new(getHandler)) tg.Use(tango.Static(tango.StaticOptions{ RootPath: "./public/html", }))

Hi, Thank you for contributing to the community.

Do you find it viable to use your authentication library? Https://github.com/go-tango/social-auth Well I see that it has been years that is not updated.

Thanks,

I'm currently preparing the next run of the the Go HTTP Routing Benchmark. Since several broken implementations were discovered already, I added a test validating the routing of each router earlier: julienschmidt/go-http-routing-benchmark@b5a1ebab84d686b0675a3c0c7d0b928a3b998d02

Unfortunately it seems like there is a problem with Tango:

    routers_test.go:78: Tango in API GitHub: 404 - Not Found; expected GET /notifications/threads/:id
    routers_test.go:78: Tango in API GitHub: 404 - Not Found; expected GET /gists/:id
    routers_test.go:78: Tango in API GitHub: 404 - Not Found; expected DELETE /gists/:id
    routers_test.go:78: Tango in API GitHub: 404 - Not Found; expected GET /repos/:owner/:repo/issues/:number
    routers_test.go:78: Tango in API GitHub: 404 - Not Found; expected GET /repos/:owner/:repo/milestones/:number
    routers_test.go:78: Tango in API GitHub: 404 - Not Found; expected GET /orgs/:org
    routers_test.go:78: Tango in API GitHub: 404 - Not Found; expected GET /teams/:id
    routers_test.go:78: Tango in API GitHub: 404 - Not Found; expected DELETE /teams/:id
    routers_test.go:78: Tango in API GitHub: 404 - Not Found; expected GET /repos/:owner/:repo/pulls/:number
    routers_test.go:78: Tango in API GitHub: 404 - Not Found; expected GET /repos/:owner/:repo
    routers_test.go:78: Tango in API GitHub: 404 - Not Found; expected DELETE /repos/:owner/:repo
    routers_test.go:78: Tango in API GitHub: 404 - Not Found; expected GET /repos/:owner/:repo/commits/:sha
    routers_test.go:78: Tango in API GitHub: 404 - Not Found; expected GET /repos/:owner/:repo/releases/:id
    routers_test.go:78: Tango in API GitHub: 404 - Not Found; expected GET /users/:user
    routers_test.go:78: Tango in API GPlus: 404 - Not Found; expected GET /people/:userId
    routers_test.go:78: Tango in API GPlus: 404 - Not Found; expected GET /activities/:activityId
    routers_test.go:78: Tango in API Parse: 404 - Not Found; expected GET /1/classes/:className

I need your help to figure out what is broken and to fix it. The current implementation for Tango is here: Tango Implementation The complete list of routes can be found here: GitHub, GPlus, Parse

Thanks in advance!

rbac中间件支持了动态权限定义之后，我在一个POST里死活读不到内容，调试了一个晚上，才发现下面这个问题。

type Action struct {
}
func (a *Action) PermTag() string {
    flag := r.Context.Form("type")
    //根据flag返回不同权限要求
    bd, _ := r.Context.Body()
    fmt.Println(string(bd))
    //紧接着马上打印body，就已经是空了
}

反过来是可以正常读取到内容的，因此可以判断是第一句清空了body

func (a *Action) PermTag() string {
    bd, _ := r.Context.Body()
    fmt.Println(string(bd))
    //此时body是有内容的
    flag := r.Context.Form("type")
    //根据flag返回不同权限要求
}

我只读取了form没有读body啊，为什么也被清空了呢？

t.Get("/", new(action.Index))
t.Get("/:param", new(action.Index))

logger.Info("AdminURL", config.DefaultAdminURL)
// output: /admin
t.Group(config.DefaultAdminURL, func(g *tango.Group) {

    g.Get("", new(master.Index))
    g.Get("/", new(master.Index))
    g.Get("/index", new(master.Index))

})

Group时为什么路由为变量时会不识别，自动默认为第一个GET了 但是把config.DefaultAdminURL改为直接定义就正常了？

在文件return.go中有这样一段：

var result = ctx.Result
if res, ok := ctx.Result.(*StatusResult); ok {
    ctx.WriteHeader(res.Code) //这里写了一次状态码
    result = res.Result
}

...

switch res := result.(type) {
case AbortError, error:
    ctx.HandleError()
case []byte:
    ctx.WriteHeader(http.StatusOK)
    ctx.Write(res)
case string:
    ctx.WriteHeader(http.StatusOK) //这里写了第二次状态码
    ctx.Write([]byte(res))
}

如果有个action 是这样写的：

func (a *Action) Get() (int, interface{}){
    return 201,"Created"
}

返回的却是200，而终端里会提示http: multiple response.WriteHeader calls。

Hi, thank you for your great work. Is there sample implementation for tango and xorm? I am looking for best framework to make CMS server, work with javascript client and json. If you have it, please let me know. Thank you.

memory leak in this case:

   24.51MB  1.77% 20.68%   327.24MB 23.58%  net/http.readRequest
  258.23MB 18.61% 39.29%   283.23MB 20.41%  net/textproto.(*Reader).ReadMIMEHeader

see more: https://github.com/gorilla/sessions see more: https://pathbox.github.io/2017/05/27/find-the-reason-memory-leak/

Important Note: If you aren't using gorilla/mux, you need to wrap your handlers with 
context.ClearHandler or else you will leak memory! An easy way to do this is to wrap the top-level mux when calling http.ListenAndServe:

http.ListenAndServe(":8080", context.ClearHandler(http.DefaultServeMux))
The ClearHandler function is provided by the gorilla/context package.

More examples are available on the Gorilla website.

Action is an interface in an middleware and context.Context is also an interface. Their are some similar feature between Action and context.Context. In tango, we use assert to get the info from Action, in context.Context, it's also a regular usage get info via assert.

func (ctx *tango.Ctx) {
     if sess, ok := ctx.Action().(Sessioner); ok {
           // do something
    }
}

func (resp http.ResponseWriter, req *http.Request) {
    if sess, ok := req.Context().(Sessioner); ok {
          // do something 
   }
}

So that maybe all the tango's middlewares could be changed slightly to apply in http.Handler.

假设有以下代码

t := tango.Classic()
g := tango.NewGroup()
g.Use(tango.Static(tango.StaticOptions{
    RootPath:   "./admin",
    Prefix:     "/",
    IndexFiles: []string{"index.html"},
}))
t.Group("/admin", g)
t.Run(":80")

运行后，无论访问http://localhost/还是http://localhost/admin/都是404。这个似乎不符合直觉。

从这个代码来说，把 tango.Static 的 Prefix 设成/admin似乎也达成目的。但我这么做的初衷是希望给 http://localhost/admin/ 做中间件，特别地控制它的权限。