Description

The ExtractPatternValuesFromString method does not allow fields to have empty string as a valid value. This PR updates the method to allow pattern values to be an empty string .

This enables us to input a search query with one of the fields as an empty string e.g now for the pod delete flow a user can input <clientset>//<pod-id> as a valid query to search for a podID in all namespaces in a particular clientset

Testing Performed

local

GitHub Issue

Fixes #

TODOs

Description

Add the option for quicklinks to the project selector, such as links to logs, grafana, etc. Note that there is a very slight issue with some of our source images - the k8s one has a slightly excessive border around it which leads to it looking slightly misaligned. However, I don't think anyone will really notice. There are also differences between the figma and reality because in figma there is differing padding due to the sizing of the icons.

I also thought about making the whole box clickable instead of the image and text but I wasn't sure if that would be confusing.

Note I messed with the padding a fair amount and tried to end up with something that looks good. If you look closely at the inspection it looks like some values are 1 or 2 pixels off but I think they look fine. The top screenshot has no top padding on the sublinks (only bottom, left and right), whereas the bottom gif has 4px padding all around.

Testing Performed

GitHub Issue

Fixes #

TODOs

Description

Adds an integration test that runs both the RTDS server and a real Envoy. Using this we write a test that validates that Envoy is properly enforcing a fault based on the RTDS configuration issued by the RTDS server.

The test simply verifies that when an experiment is active, the connected Envoy will be able to receive and enforce the fault configuration. This should allow us to validate certain interactions between the generated configuration and Envoy, and make it easier to verify that ECDS faults are working as intended.

Some refactoring is done to split out the test stores into its own package to clean up the rtds package and to make the test server used in the existing RTDS test usable from other tests.

oidc: allow users to map oidc subject & group claims

Description

Users can now configure Subject and Groups mappings via the clutch config file:

      oidc:
        issuer: ...
        client_id: ${CREDENTIALS_OIDC_CLIENT_ID}
        client_secret: ${CREDENTIALS_OIDC_CLIENT_SECRET}
        redirect_url: "${BASE_URL}/v1/authn/callback"
        subject_claim_name: email
        groups_claim_name: group
      session_secret: ${CREDENTIALS_SESSION_SECRET}

If these arguments are not set, the old mapper DefaultClaimsFromOIDCToken is used.

Testing Performed

tested locally in a private setup also added unit tests

GitHub Issue

Discussed in slack, these flags are similar to Kubernetes API Server's:

   - --oidc-groups-claim=groups
   - --oidc-username-claim=email

TODOs

Description

• PR [5/x] for ShortLinks
• No reliance on other PRs
• Modifies the Alert to have a collapsible and hover option
• Also supports a click option that can be used in place of hover

Screenshots

Closed

Open

GIF

Testing Performed

manual

Description

Setting up a file that other files will be able to reference for colors

The idea here is that this is one step in organizing colors for Clutch. Another step would be replacing various places where we use colors with references to this file instead.

I met with Derek, and he did a lot of work. We originally thought about removing exports because this area is still under construction. I also thought about just adding TODOs for the theming because it seems that no external contributors are interested in working on the theming currently.

Testing Performed

none

GitHub Issue

Fixes #

TODOs

Description

Adding the ListPullRequestsWithCommit API into the backend module's available Github APIs.

https://docs.github.com/en/rest/reference/repos#list-pull-requests-associated-with-a-commit

GET /repos/{owner}/{repo}/commits/{commit_sha}/pulls

As part of Lyft's internal extensions for Clutch, we are building a new dashboard to track k8s resources deployed for integrated testing purposes. One of the columns we'd like to surface for our users is the Github PR's branch name, hyperlinked to the Github PR's URL. This allows engineers to have a single-pane-of-glass view over their test deployments of pre-merged Github PR's. The only metadata baked into the k8s artifact is the SHA of the PR, so this API will enable us to translate that into more helpful information (HTML URL, branch name) when engineers are doing their routine maintenance/management.

Testing Performed

Added unit tests. First time contributing so seeking advice on what other testing techniques can be used for this type of change :)

GitHub Issue

n/a

TODOs

n/a at the time of this posting

Description

PR adds a "see more" action area to CardContent, which when enabled will collapse part of the CardContent if it goes beyond the set max height. Even if collapsible is enabled, if the CardContent does not go beyond the set max height, the "see more" action area won't be visible.

Testing Performed

No changes to the landing page cards which use the CardContent component as well

TODOs

In the next PR, I'll break up the core card and framework pieces into different files.

Update node.js version to 14.0 to get access to option chaining source. Currently if one tries to use optional chaining in clutch.config.js the build files:

const faults = e.scenario?.faults; // this fails

$ yarn workspace @clutch-sh/tools registerWorkflows $PWD/src
$ node workflow-registrar.js /home/runner/work/clutch-private/clutch-private/frontend/src
/home/runner/work/clutch-private/clutch-private/frontend/src/clutch.config.js:136
              const faults = e.scenario?.faults;
                                        ^
SyntaxError: Unexpected token '.'
    at wrapSafe (internal/modules/cjs/loader.js:1053:16)
    at Module._compile (internal/modules/cjs/loader.js:1101:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
    at Module.load (internal/modules/cjs/loader.js:985:32)

Complexity: S

Description

Card components in the landing page adjusted their height according to the card's description length. That caused disparity in the cards sizes. This update sets the Card height to a fixed 214px.

Before:

After:

Testing Performed

manual

Description

It was requested to split this PR https://github.com/lyft/clutch/pull/2223/files to just the protos, so here they are :)

The idea here is that there will be a "metrics" service in Clutch that can get metrics from a store, such as m3 or something else. It follows a similar pattern as the diagnostics api in private. It could potentially "fan-out" to providers, as shown in the config proto. Something discussed at a meeting was that even though not necessarily all providers will have the same fields as prometheus does, it is ok for some of the fields to be blank.

Testing Performed

none needed

GitHub Issue

Fixes #

TODOs

This PR contains the following updates:

| Package | Type | Update | Change | |---|---|---|---| | github.com/slack-go/slack | require | minor | v0.11.4 -> v0.12.1 |

Release Notes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

This PR contains the following updates:

| Package | Type | Update | Change | |---|---|---|---| | github.com/grpc-ecosystem/grpc-gateway/v2 | require | minor | v2.12.0 -> v2.15.0 |

Release Notes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Description

Some build issues from having @mui/lab added to the base package.json, which was necessary due to material-table. Removing both and seems to build fine.

Testing Performed

manual

This PR contains the following updates:

| Package | Type | Update | Change | |---|---|---|---| | github.com/go-git/go-git/v5 | require | minor | v5.4.2 -> v5.5.1 |

Release Notes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

This PR contains the following updates:

| Package | Type | Update | Change | |---|---|---|---| | github.com/go-git/go-billy/v5 | require | minor | v5.3.1 -> v5.4.0 |

Release Notes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

This PR contains the following updates:

| Package | Type | Update | Change | |---|---|---|---| | github.com/coreos/go-oidc/v3 | require | minor | v3.4.0 -> v3.5.0 |

Release Notes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.