Closes #22.

• Cleaned up parsing code. No more magic numbers and manual indexing.
• Options moved to their own package.
• Server moved to its own package.
• All tests passing.

It may be easier to explore these changes here: https://github.com/hugelgupf/dhcp6/tree/simplify-api

Requires #23. Still untested, because I don't have a DHCP server handy -- and the part that is new here is the UDP socket instead of the raw socket :)

This is so far all that we need for the u-root dhclient.

Hello, OptionVendorClass seems not respect RFC 3315, Section 22.16. Cause the EnterpriseNumber is missing.

I have fix, plz see at: https://github.com/jerome-laforge/dhcp6/commit/78927a18b545211ced8c2e832aadc36ae6ded11e

If it suitable for you, I can make PR. thx

Hello, When elapsed time values greater than the largest time value that can be represented in the Elapsed Time option, the client uses the value 0xffff.

Plz this commit https://github.com/jerome-laforge/dhcp6/commit/924665b1b681f36187f78da14256467fc0fd8fa2

If it is suitable for you, I can submit a PR

Hello InterfaceID seem not respect the RFC 3315. InterfaceID is just opaque value and not Length-Value.

Plz see this commit that fix this issue: https://github.com/jerome-laforge/dhcp6/commit/113a6bf6a8e1999dee63e32d363ffa687b36111c

Hello, In unit test of our internal injector, we use to compare expected DHCPv6 packet and actual packet with this assert.

Unfortunately, on the capacity option is not equal when when unmarshall from binary and when we create the packet from struct because capacity is not the same. So assert fails.

Here example's extract:

Diff:
--- Expected
+++ Actual
@@ -1,2 +1,2 @@
-(*dhcp6.Packet)(0xc82001b640)({
+(*dhcp6.Packet)(0xc82001b650)({
  MessageType: (dhcp6.MessageType) MessageTypeSolicit,
@@ -7,3 +7,3 @@
   (dhcp6.OptionCode) OptionClientID: ([][]uint8) (len=1 cap=1) {
-   ([]uint8) (len=10 cap=130) {
+   ([]uint8) (len=10 cap=10) {

By the way, I seems to me more consistent, that set slice's max for option's data for avoiding all corrupt data (for example with append) This commit is fixing this pb: https://github.com/jerome-laforge/dhcp6/commit/2ba8cd69e42c7988facede487423eeccb703137a

If it is suitable for you, I can make a PR.

Create a dhcp6/dhcp6test package akin to net/http/httptest, with types like Recorder and Server (test server). This will clean up some of the current tests, and make it easier to test Handler types.

This may also require throwing out some or all of mux_test.go and server_test.go, and rewriting them in package dhcp6_test instead, to avoid circular imports.

The API is bloated because of all of the available options, and it really shows in the godoc page especially. Most unusual options should be moved to another package.

Hello: As title """ p := new(dhcp6.Packet) if err := p.UnmarshalBinary(b); err != nil { return nil, err } """ When ParseRequest UnmarshalBinary a dhcpv6 relay request, because of the structure does not match, it will lead to failure.

This adds a dhcp6 client. This code is currently used in github.com/u-root.

Matt, if this seems like something you could bring in, let me know. If you have changes you want made, no problem. If you'd rather not bring it in, that's fine too.

thanks.

Signed-off-by: Ronald G. Minnich [email protected]