Signed-off-by: MUzairS15 [email protected]

Description

This PR fixes # Added end-to-end tests for cilium service mesh installation. Notes for Reviewers

Signed commits

• [x] Yes, I signed my commits.

Signed-off-by: Suryashankar Das [email protected]

Description

Notes for Reviewers

Signed commits

• [x] Yes, I signed my commits.

Current Behavior

Currently, we install Cilium using helm, but we often face problems while installing.

Expected Behavior

Install Cilium directly from the latest release https://github.com/cilium/cilium-cli/releases/tag/v0.10.2

Screenshots/Logs

kubectl get pods -A
NAMESPACE              NAME                                         READY   STATUS              RESTARTS      AGE
kube-system            cilium-operator-5986db558f-p57xs             0/1     Pending             0             17s
kube-system            cilium-operator-5986db558f-z4qgv             1/1     Running             0             17s
kube-system            cilium-tnv46                                 0/1     Error               1 (9s ago)    17s

Current State: Small updation of shields in README.md

Desired State: This is how it should look like:

updation should be done in this README.md by keeping the shield style uniform to following meshery-istio's README.md : https://github.com/meshery/meshery-istio/blob/721b78783182e65145cefde64d905dab3ca20ba1/README.md?plain=1#L13

Contributor Resources

• Meshery documentation site
• Meshery documentation source
• Instructions for contributing to documentation

Signed-off-by: MUzairS15 [email protected]

Description

This PR fixes #33

Notes for Reviewers

Signed commits

• [x] Yes, I signed my commits.

Current Behavior

➜  meshery-cilium git:(master) make
golangci-lint run
WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner.  Replaced by revive.
internal/config/config.go:24:19: ServiceMesh_CILIUM_SERVICE_MESH not declared by package smp (typecheck)
		"name":     smp.ServiceMesh_CILIUM_SERVICE_MESH.Enum().String(),
		                ^
internal/config/config.go:31:18: ServiceMesh_CILIUM_SERVICE_MESH not declared by package smp (typecheck)
		"name":    smp.ServiceMesh_CILIUM_SERVICE_MESH.Enum().String(),
		               ^
internal/config/operations.go:10:40: ServiceMesh_CILIUM_SERVICE_MESH not declared by package smp (typecheck)
	CiliumOperation = strings.ToLower(smp.ServiceMesh_CILIUM_SERVICE_MESH.Enum().String())
	                                      ^
make: *** [check] Error 1

Expected Behavior

Adapter should build and run.

Contributor Guides and Resources

• 🛠 Meshery Build & Release Strategy
• 📚 Instructions for contributing to documentation
  • Meshery documentation site and source
• 🎨 Wireframes and designs for Meshery UI in Figma
• 🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

Current Behavior

Many of places in the workflows still mention go version 1.16 yet the adapters use go version 1.17

Desired Behavior

Workflows shouls also use go version 1.17

Implementation

Acceptance Tests

Mockups

Contributor Guides and Resources

• 🛠 Meshery Build & Release Strategy
• 📚 Instructions for contributing to documentation
  • Meshery documentation site and source
• 🎨 Wireframes and designs for Meshery UI in Figma
• 🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

Current Behavior

Currently e2e tests in the adapter only run tests for vanilla service mesh installation and for addons.

Desired Behavior

The link below is of an example pattern file that should also be deployed and assertions should be made. https://github.com/service-mesh-patterns/service-mesh-patterns/blob/master/samples/minimalistiobookinfo.yaml

Implementation

Acceptance Tests

Reference:

• Meshery Build & Release Strategy

Bumps github.com/layer5io/meshkit from 0.5.32 to 0.5.35.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Description

This PR fixes the problem of HELM installations

1. Reason for fail:

• The envoy check was having problems with the ARM arch
• Especially the cilium mesh version <= 1.9.X was causing problems
• We are always installing older version (v1.9.4) of cilium mesh because of Meshkit func (as it sends the list of versions in ascending order and that doesn't matches with the rest of the implementation of the adapter)

2. Fix:

• Made sure that the latest version is selected by selecting the last element of the versions array

This PR fixes #21

Notes for Reviewers

One of the cilium-operator pods would always remain in a pending state because it gets scheduled only when we use more than one node cluster

1. Pods status

2. Cilium status (using ciliumctl)

Signed commits

• [x] Yes, I signed my commits.

Bumps github.com/layer5io/meshery-adapter-library from 0.5.9 to 0.5.10.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.