Automatically capture all potentially useful information about each executed command (as well as its output) and get powerful querying mechanism

Installed from release 0.2.1, nhi fetch shows only the creation of sessions, no commands have been logged, nor the finish of sessions. Same result from within and without tmux

$ uname -a
Linux Aostro-5468 5.14.16-arch1-1 #1 SMP PREEMPT Tue, 02 Nov 2021 22:22:59 +0000 x86_64 GNU/Linux

$ zsh --version
zsh 5.8 (x86_64-pc-linux-gnu)

Hi, This appears to be a fantastic utility.

However, following the readme, I installed nhi on ArchLinux, but it does not seem to work correctly, as the echo nhi test failed (no output).

Also, nih.bash seems to conflict with the merged_history.bash script published in http://ptspts.blogspot.com/2011/03/how-to-automatically-synchronize-shell.html to get a persistent command history, which does not work anymore if nhi.bash is sourced in .bashrc.

BPF spin locks don't support tracing programs, although according to manual this may change in the future.

EDIT: BPF maps are RCU protected so calls are mostly safe

Bug is caused by https://github.com/strang1ato/nhi/commit/e73040d0bfad0cca0f25f78f896d3043277f8204 commit

Tip: Bash outputs error via child processes that don't run execve()

Hello,

Thank you, this project is really cool!

However, my commands are not logged after running commands such as vim:

vagrant@bullseye:~$ nhi fetch {-1}
vagrant@bullseye:~$ echo test
test
vagrant@bullseye:~$ vim
vagrant@bullseye:~$ echo test
(nothing here)

This issue seems to come from here: https://github.com/strang1ato/nhi/blob/a3c65ccf4a7600d5dea264eba924afd234191e06/daemon/src/nhi.bpf.c#L393-L404

Looking in the database (at /var/nhi/db), I can see:

echo test
b'\xfftest\n'
vim
b'\xff\x1b[?1000h\xff\x1b[34h\x1b[?25h\x00\x00\x00\x00\x00\x00\x00\x00'
echo test
b''

The last 8 bytes are set to \x00 which should mean that omit_write is set to zero, but I do not understand why it still refuses to log the next commands.

On another note, it would be nice to remove the null bytes and the rest of what was logged (\x1b[?1000h\xff\x1b[34h\x1b[?25h), it messes up my terminal after executing nhi fetch (which makes me have to execute reset to clean my terminal).

Not really an issue (probably because I haven't used nhi that much), but I saw this in the kernel messages:

[  +0.000004] nhid[3381461]: segfault at 0 ip 00007fed21d1f515 sp 00007ffd5ca83e38 error 4 in libc-2.33.so[7fed21be5000+14b000]
[  +0.000010] Code: 00 00 0f 1f 00 31 c0 c5 f8 77 c3 66 2e 0f 1f 84 00 00 00 00 00 f3 0f 1e fa 89 f9 48 89 fa c5 f9 ef c0 83 e1 3f 83 f9 20 77 2b <c5> fd 74 0f c5 fd d7 c1 85 c0 0f 85 eb 00 00 00 48 83 c7 20 83 e1

I don't know why there isn't a coredump generated, but it happens inside tmux and with my .zshrc (haven't tested other conditions yet). Again, not a urgent problem for me, just something for you to look into