Hello! This is my first attempt at contributing to an open source project. I attempted to address many of the areas identified in regards to the graph visualization. I'm happy with the outcome, but I did make a lot of changes to the core graph logic. It's all backwards compatible as far as I can tell, aside from the actual visualization. It could be made to work with the old force-graph, but I chose to implement cytoscape.js both for handling the graph data in core and the visualization in the webview. I don't know how fast this is. I don't know how to test for that. The highlights:

• ~~reworked foam-core/graph by implementing cytoscape.js to handle all of the graph data~~
• implemented a basic gui and filtering in the data visualization (dat.gui made filtering kind of weird, should a panel be used instead?)
• ~~implemented a command to expose the graph json (I'm fairly certain I put this in the wrong place)~~
• add color: "red" to yaml frontmatter to change node colors easily. Accepts these formats: "red" / "#ff0000" / rgb(255,0,0)
• highlight nodes based on text search (todo: use regex instead of simple string matching)
• folder hierarchy view
• visualize tags on graph
• filter by tagged nodes (todo: implement filtering by specific tags)
• limit graph view to selected nodes (Hold shift or ctrl to add nodes to selection, or use box select. Note: this doesn't play well with any of the other filters. I need update the gui to disable the other parameters when this is selected.)

I'm still working on the styling, but it is still customizable. The formatting is different though so try something like this to test it out:

"foam.graph.style" : { "styles": [{
      "selector": "node[type = 'note']",
      "style": {
        "background-color": "cyan",
      }
    }, {
      "selector": "node[type = 'tag']",
      "style": {
        "background-color": "purple",
      }
    }, {
      "selector": "node[type = 'placeholder']",
      "style": {
        "background-color": "pink",
      }
    }
  ]}

Hopefully this works out and can be used as a basis for further improvements. I'm very new to typescript and vscode extensions, so I'm sure there is room for improvement. Let me know and I'll try to get things fixed as soon as I can.

Describe the bug

As soon as I open the Foam Graph two electron processes starts hogging a questionable high amount of CPU performance. On a workspace with around a dozen notes(i.e. nodes in the graph) they are both between 10% and 15% while on a workspace with ~330 notes one is at roughly 65-75% and the other at a quite stable ~24-26%. Numbers according to htop and on an AMD Ryzen 5 3600

This is without any interaction with the graph and even if VS Code is on a workspace that isn't even being displayed

To Reproduce

1. Check a process manager like htop for the current list of processes requiring the most CPU performance
2. Open VS Code with your Foam Workspace (which should not yet show a CPU load spike)
3. Open the Foam Graph and probably observe two new processes hogging roughly an entire CPU core between them

Expected behavior

Not hog an absurdly high amount of CPU performance. The Markdown Links graph requires a similar amount of CPU when opening it and occasionally during panning, but this returns to baseline shortly after again.

Additional Notes

I assume this is something with the interactivity and live update feature. Potentially this could be deactivated via an option until the exact cause of this issue is found.

It would be great if we had a GitHub Action which ran on "merge pull request" and then opened a new pull request to add a person to the all-contributors table in the README. It wouldn't solve all the use cases for adding contributors to the table, but a majority of them.

Happy to help guide/mentor someone if they want to pick this up.

@riccardoferretti I'm not sure how do you regenerate yarn.lock so I've only changed package.json.

I decided to leave the slug term as it's used in many places, I think it has a legitimate meaning. Regarding the references used to find resources in the workspace, one could say a reference is:

• An URI
• Or a slug (string) which can be:
  • Absolute
  • Relative
  • An identifier

AFAICS the current code is consistent with this terminology.

I've added a refactor label since I expect to send a few more purely-refactoring PRs, but feel free to delete or rename it.

This pr resolves #653 , the suggestion adds the functionality to create a new note for a piece of selected text. It will use the functionalities as introduced by @movermeyer to create a new note from the default template or select a template. I've added a configuration to configure foam to always select a note template if desired. Setting it false means it will use the default template.

To keep behaviour similar to the other two new note command I am reusing that code as much as possible. It simply adds some additional text and view behaviour to the existing methods. This should keep the user interaction consistent and will reduce maintenance work. I need to add tests and do some more manual testing, but first want to validate the approach with @movermeyer and @riccardoferretti. You are welcome to leave your suggestions and comments.

• Foam version: v0.15.2
• Platform: macOS Big Sur
• Issue occur on the foam template repo: Yes

Summary

Steps to reproduce

1. Create a directory d with files a.md and b.md
2. Add [[d/b]] to a.md
3. Follow that link: it will offer to create b and the fail because b already exists.

https://user-images.githubusercontent.com/2845433/139410901-3630da90-297c-4d15-8e14-09901a1c4add.mov

Fixes #488

On Windows, the uri util file contains a compare relative paths with posix functions. The drive letters might not match on Windows (unique problem on win32 platform).

This fix introduces a small utility that is only relevant to Windows platform that would normalize drive letters in paths.

• Foam version: v0.10.0
• Platform: Mac (Big Sur 11.2.1)
• Issue occur on the foam template repo: Yes

Summary Foam Graph shows two entries for same note. One entry is shown orphan which is active. The actual link is shown as inactive.

Steps to reproduce

1. I created a daily journal entry, and types a wiki link to create it
2. Click on the wiki link to create the desired page
3. As the page got created in same journal folder I moved it to root folder

Additional information I have attached a demo project with only the actions I have taken and the foam graph has that issue The project started from Foam Template and I have added some extension suggestions which I am already using

foam-graph-test.zip

To Reproduce Reload VSCode and use Foam: Show Graph command.

Screenshots There are some files in my repository but foam did't show these nodes.

Supplement Sometimes after linking a file to another, and reuse the command, both the two files' nodes will appear. Or type any words in a file, and reuse the command, the file's node will also appear. But if you reload VSCode and reuse the command, all the nodes will disappear again. It's not stable and I'm not sure when and why this bug will appear, as if it will only show the nodes which has been modifed. Once VSCode is reloaded, all the files will be regarded as "not modified". By the way, all the links in my repository are regular markdown links, not wikilinks.

This is the contrast between Foam: Show Graph command (left) and Markdown Links: Show Graph command (right) :

Test Environment Windows 10 version 1909 Plugin version 0.7.0

• [ ] improve extension manifest (see https://code.visualstudio.com/api/references/extension-manifest#marketplace-presentation-tips)
• [x] update the docs/ directory to separate ideas/features/thoughts/...
• [x] update README to become entry point into structured documentation for existing features
• [ ] test the presentation of the newly released extension in the marketplace (e.g. title, icon, readme, links to repo/bugs/..)

• Foam version: v0.9.1
• Platform: Windows
• Issue occur on the foam template repo: Not sure

Summary

The Windows path is very weird. It's not at all portable because it is not a relative path.

Steps to reproduce

1. Add a link to todo.md by [[todo]]
2. Ctrl + S

Additional information

Feel free to attach any of the following that might help with debugging the issue:

• screenshots
• a zip with a minimal repo to reproduce the issue
• the Foam log in VsCode (see instructions)

Describe the bug

The tag explorer does not properly handle tags more than two levels. For instance #bydate/2022/11/30, #bydate/2022/12/11, #bydate/2022/12/12 should nest properly like the filesystem view but don't. All of the tags after the first slash are just treated as a single node so the tag hiearchy looks like "bydate > 2022/12/12" instead of "bydate > 2022 > 12 > 12".

Small Reproducible Example

No response

Steps to Reproduce the Bug or Issue

Create tags in a node or nodes: #bydate/2022/11/30 #bydate/2022/12/11 #bydate/2022/12/12

Expected behavior

As a user, I expect the tag explorer to present a hierarchical filesystem view of tags that treats each tag separated by slashes as an expandable node in a hierarchy.

Screenshots or Videos

Operating System Version

Windows

Visual Studio Code Version

1.74.2

Additional context

No response

Bumps json5 from 1.0.1 to 1.0.2.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Is your feature request related to a problem? Please describe.

Currently Foam supports only .md files as notes, and will always create .md files when clicking on a link (well, unless differently instructed by the template being used)

Describe the solution you'd like

As a user, I expect to be able to configure the list of extensions to be considered notes, e.g. txt, mdx, qmd, ...

There are really two issues here:

1. support for multiple file extensions to be included as notes - this would need to be a setting, similar to what we have for foam.files.attachmentExtensions

2. support for the creation of non-.md files. Here I can see two approaches: a. use note templates - this requires no further changes and is the current workaround b. use the first extension from the setting above as the default extension for new notes

Describe alternatives you've considered

No workarounds are available at the moment for including non-.md files in the graph.

To create non-.md files the current workaround would be to use the filepath property in templates.

Screenshots or Videos

No response

Describe the bug

foam navigates to somedir/.md instead of somedir/readme.md

Small Reproducible Example

No response

Steps to Reproduce the Bug or Issue

lets say i have this markdown file

# asdf

[somedir/](somedir/)

then Control-Click on [somedir/](somedir/) navigates to somedir/.md

Expected behavior

foam should use somedir/readme.md as the index file of the somedir/ folder

... or show a directory listing, if there is no index file

my goal is a "buildless" wiki on the github blob api so readme.md is the default index file, and i can use only markdown links

Screenshots or Videos

No response

Operating System Version

x

Visual Studio Code Version

x

Additional context

No response

I started on enabling Foam for https://vscode.dev, the online version of VSCode. I decided to work in public to make this a broader effort. It's not an easy task and could use any help and knowledge.

Right now I have been able to get the webpack compilation going and enable a local test environment. It's not loading Foam currently. So tackling that one to see what remaining tasks are left.

    So I think I found a good solution for this issue, and I have committed it. It will come out with the 0.20.1

Originally posted by @riccardoferretti in https://github.com/foambubble/foam/issues/1073#issuecomment-1263969563

This solved it for multiple workspace folders. But it still happens for me when I change the "name" value of a workspace folder e.g. to "my notes" instead of "notes" like in the path value it creates a "my notes/journal/" subfolder in notes.

{
  "folders": [
    {
      "name": "test of folder1",
      "path": "./folder1"
    },
    {
      "name": "test of folder2",
      "path": "./folder2"
    }
  ],
  "settings": {
    "foam.openDailyNote.directory": "journal"
  },
  "extensions": {
    "recommendations": [
      "foam.foam-vscode"
    ]		]
  }
}

creates:

./folder1/test of folder1/2022-12-24.md

"foam.openDailyNote.directory": "./folder1/journal"

creates

./folder1/test of folder1/folder1/journal/2022-12-24.md

"foam.openDailyNote.directory": "~/tmp/folder1/journal"

creates

./folder1/test of folder1/~/tmp/folder1/journal/2022-12-24.md

Changing "name": "test of folder1", to "name": "folder1" resolves the issue for the moment.