my source code is in a sub directory of my git repo which called src, so when i run golangci-lint run --new-from-rev=HEAD~ , would the option --new-from-rev works well ?

i think the option --new-form-rev may read the .git to tell which is the newest commits , but when i tried golangci-lint run src/ it would showed like cannot import absolute path , what should i do

I am using go modules and getting the following error.

$ GOLANGCI_COM_RUN=1 golangci-lint run --out-format=json --issues-exit-code=0 --deadline=5m --new=false --new-from-rev= --new-from-patch=
    Running error: context loading failed: failed to load program with go/packages: go [list -e -json -compiled -test=false -export=false -deps=true -find=false -- ./...]: exit status 2: # github.com/mailchain/mailchain/vendor/github.com/ethereum/go-ethereum/crypto/secp256k1
    vendor/github.com/ethereum/go-ethereum/crypto/secp256k1/curve.go:42:44: fatal error: libsecp256k1/include/secp256k1.h: No such file or directory
     #include "libsecp256k1/include/secp256k1.h"
                                                ^
    compilation terminated.
Error: failed to load program with go/packages

The prepare repo gets the repos but fails checking dependencies.

    Synced deps
    Checking deps...
    internal/pkg/crypto/keys/secp256k1/private.go:1: vendor/github.com/ethereum/go-ethereum/crypto/secp256k1/curve.go:45:8: could not import C (no metadata for C) (typecheck)
    // Copyright 2019 Finobo
    internal/pkg/mailbox/pubkey.go:1: vendor/github.com/ethereum/go-ethereum/crypto/secp256k1/curve.go:45:8: could not import C (no metadata for C) (typecheck)
    // Copyright 2019 Finobo
    internal/pkg/clients/etherscan/api.go:1: vendor/github.com/ethereum/go-ethereum/crypto/secp256k1/curve.go:45:8: could not import C (no metadata for C) (typecheck)
    // Copyright 2019 Finobo
    Deps checking: bad: internal/pkg/crypto/keys/secp256k1/private.go:1: vendor/github.com/ethereum/go-ethereum/crypto/secp256k1/curve.go:45:8: could not import c (no metadata for c) (typecheck)
    Checking deps...
    internal/pkg/crypto/keys/secp256k1/private.go:1: vendor/github.com/ethereum/go-ethereum/crypto/secp256k1/curve.go:45:8: could not import C (no metadata for C) (typecheck)
    // Copyright 2019 Finobo
    internal/pkg/mailbox/pubkey.go:1: vendor/github.com/ethereum/go-ethereum/crypto/secp256k1/curve.go:45:8: could not import C (no metadata for C) (typecheck)
    // Copyright 2019 Finobo
    internal/pkg/clients/etherscan/api.go:1: vendor/github.com/ethereum/go-ethereum/crypto/secp256k1/curve.go:45:8: could not import C (no metadata for C) (typecheck)
    // Copyright 2019 Finobo
    Deps checking: bad: internal/pkg/crypto/keys/secp256k1/private.go:1: vendor/github.com/ethereum/go-ethereum/crypto/secp256k1/curve.go:45:8: could not import c (no metadata for c) (typecheck)
    [WARN] Failed to sync deps
    [WARN] Failed to fetch dependecies

Do you know how to resolve this?

Hi there Getting weird errors all of a sudden at https://golangci.com/r/github.com/orbs-network/orbs-network-go Used to work up until a few days ago

Error
Failed to load program with go/packages: go [list -e -json -compiled -test=false -export=false -deps=true -tags mytag -- ./...]: exit status 1: go build github.com/orbs-network/orbs-spec/types/go/primitives: no Go files in 
go build github.com/pkg/errors: no Go files in 
go build github.com/VividCortex/ewma: no Go files in 
go build github.com/codahale/hdrhistogram: no Go files in 
go build github.com/orbs-network/membuffers/go: no Go files in 
go build github.com/orbs-network/orbs-spec/types/go/protocol: no Go files in 
go build github.com/orbs-network/orbs-spec/types/go/services: no Go files in 
go build golang.org/x/crypto/ed25519: no Go files in 
go build github.com/orbs-network/orbs-spec/types/go/protocol/consensus: no Go files in 
go build github.com/orbs-network/orbs-spec/types/go/protocol/client: no Go files in 
go build github.com/orbs-network/go-mock: no Go files in 
go build github.com/google/go-cmp/cmp: no Go files in 
go build github.com/orbs-network/orbs-spec/types/go/services/gossiptopics: no Go files in 
go build github.com/stretchr/testify/require: no Go files in 
go build github.com/orbs-network/orbs-spec/types/go/services/handlers: no Go files in 
go build github.com/stretchr/testify/assert: no Go files in 
go build github.com/orbs-network/lean-helix-go: no Go files in 
go build github.com/orbs-network/orbs-spec/types/go/protocol/gossipmessages: no Go files in 
go build github.com/orbs-network/lean-helix-go/primitives: no Go files in 
go build golang.org/x/crypto/ripemd160: no Go files in 
go build github.com/orbs-network/orbs-contract-sdk/go/sdk: no Go files in 
"

Warning in prepare repo
Fetch deps: sync deps: deps check failed: level=warning msg="[runner] can't process result by autogenerated_exclude processor: can't filter issue result.issue{fromlinter:"typecheck", text:"services/blockstorage/sync/harness.go:5:2: cannot find package \"github.com/orbs-network/go-mock\" in any of:\
\ /tmp/tmp.3tcquuiwte/src/github.com/orbs-network/orbs-network-go/vendor/github.com/orbs-network/go-mock (vendor tree)\
\ /usr/local/go/src/github.com/orbs-network/go-mock (from $goroot)\
\ /tmp/tmp.3tcquuiwte/src/github.com/orbs-network/go-mock (from $gopath)", pos:token.position{filename:"", offset:0, line:0, column:0}, linerange:(*result.range)(nil), hunkpos:0, sourcelines:[]string(nil)}: can't parse file : read /tmp/tmp.3tcquuiwte/src/github.com/orbs-network/orbs-network-go: is a directory"

Feature request from @xcoulon: it's needed e.g. for https://github.com/fabric8-services/fabric8-auth. It will prevent compilation errors because generated files aren't commited.

1. Maybe we should guess needed commands by analyzing Makefile
2. We must make one-time isolated containers to safely execute any commands.
3. We should allow to specify build, deps, etc commands in .golangci.yml

Hey golangci team, I'm working with the go-swagger team to enable golangci on their repo; however, after we turned it on and sent in a PR full of junk, golangCI says its A-OK :(

Is there a service level issue? or did we configure something wrong?

See the pile-o-junk PR here: https://github.com/go-swagger/go-swagger/pull/1580

Seems currently golangci is not supporting the latest version. We rely on this change to support golang 1.13, so we were forced to upgrade but now we aren't getting the great PR feedback. Would be great for this to be supported as well.

Error messages are like Failed to setup workspace: goenvbuild internal error: setup golangci-lint failed: no available minor version 18, see build log

At https://golangci.com/r/github.com/gonum/gonum/pulls/1129 we see "Can't run golangci-lint: invalid output json, see build log", but as the subject says, there is not useful information in the build log. The only JSON that is shown in the build log is indeed valid.

Something broken in the backend?

Since friday, we have met failures on several PRs on our repos: the GolangCI engine seems unhappy resolving go 11 dependencies with modules.

Typical messages are:

ErrorFailed to load program with go/packages: go [list -e -json -compiled -test=true -export=false -deps=true -- ./...]: exit status 1: go build github.com/go-openapi/analysis: no Go files in
go build github.com/go-openapi/spec: no Go files in
go build github.com/go-openapi/swag: no Go files in
"

And:

Warning in prepare repoFetch deps: go mod: command failed: go: finding github.com/pmezard/go-difflib v1.0.0
go: finding github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578
go: finding github.com/PuerkitoBio/purell v1.1.0
go: finding github.com/stretchr/testify v1.2.2
go: finding github.com/globalsign/mgo v0.0.0-20180905125535-1ca0a4f7cbcb
go: finding github.com/go-openapi/swag v0.17.0
go: finding github.com/go-openapi/errors v0.17.0
go: finding github.com/davecgh/go-spew v1.1.1
go: finding golang.org/x/text v0.3.0
go: finding gopkg.in/yaml.v2 v2.2.1
go: finding github.com/mailru/easyjson v0.0.0-20180823135443-60711f1a8329
go: finding github.com/go-openapi/analysis v0.0.0-20180825180245-b006789cd277
go: finding github.com/go-openapi/jsonreference v0.17.0
go: verifying github.com/go-openapi/[email protected]/go.mod: checksum mismatch
downloaded: h1:AByQ+nYG6gQg71GINrmuDXCPWdL640yX49/kXLo40Tg=
go.sum: h1:DXUve3Dpr1UfpPtxFw+EFuQ41HhCWZfha5jSVRG7C7I=
: exit status 1

This blocks several PRs: https://github.com/go-openapi/analysis/pull/40 https://github.com/go-openapi/loads/pull/20 https://github.com/go-openapi/loads/pull/21 https://github.com/go-openapi/spec/pull/85

I'm working on a project with multiple developers. I have connected @golangci to our repos and when I create a PR golangci is doing its review. But when someone else is opens a PR there is no review done. Is that a permission issue or do I have to connect golangci in a special way to our repos?

Hey! This seems like a cool project so I wanted to try it out. I'm trying to setup adamdecaf/cert-manage with this, but running into an issue.

I'm using my bot account (@adamdecaf-bot) and getting "Can't activate repo" when clicking "Connect". I assume this is due to permissions on my bot account and repo?

I searched the code a bit and found the error message, but it looks like the underlying error isn't reported to the user.

Our integrations in GolangCI fail using latest Docker image with error message:

$ GOLANGCI_COM_RUN=1 golangci-lint run --out-format=json --issues-exit-code=0 --timeout=5m --new=false --new-from-rev= --new-from-patch=../changes.patch
    Can't get config for command line: can't parse args: unknown flag: --timeout

I suspect this is due to deprecation of --deadline switch in favour of --timeout, however the version we request via config (1.18.0) does not support --timeout.

With the https://golangci.com/ service shutting down, I wonder if it's possible to host our own golangci bot to leave comments on pull requests? My project already runs golangci-lint as part of our CI system, but we also use https://golangci.com mostly to get the PR comments and suggestions. We previously used https://github.com/jenkinsci/violation-comments-to-github-plugin to do this, but prefer the golangci-lint bot because it makes suggestions.

Problem: GolangCI reports an error:

SA5008: duplicate struct tag "choice" Method string short:"m" long:"method" choice:"get" choice:"put" description:"HTTP method that needs to be presigned" default:"get"

This is the code line that it complains about:

Method string `short:"m" long:"method" choice:"get" choice:"put" description:"HTTP method that needs to be presigned" default:"get"`

Here the choice tag used multiple times here. However, according to the documentation for go-flags package, this is the right way to use it: https://godoc.org/github.com/jessevdk/go-flags

Here is the code snippet:

var opts struct {
	Bucket string `short:"b" long:"bucket" description:"S3 bucket" env:"S3_BUCKET" required:"true"`
	Path   string `short:"p" long:"path" description:"S3 path" env:"S3_PATH" required:"true"`
	Method string `short:"m" long:"method" choice:"get" choice:"put" description:"HTTP method that needs to be presigned" default:"get"`
	Expiry int64  `short:"e" long:"expiry" description:"Expiration time for the url in seconds" default:"7200"`
}

func main() {
	parser := flags.NewParser(&opts, flags.Default)

	if _, err := parser.Parse(); err != nil {
		os.Exit(1)
	}
}

Expected behaviour: golangCI should not mark it as Failure

https://golangci.com/repos/github only works sometimes for me (@docwhat).

Usually it will return "Internal Server Error" with HTTP code 500.

I have a lot of repositories and am linked to a bunch or really big orgs. I've had issue because of that with other GitHub linked services. 😜

I cannot add an organization repo (public), or at least I don't find a way to do so.

The repo I would like to add is https://github.com/gojisvm/gojis, which was moved from https://github.com/TimSatke/gojis, where I've used golangci successfully.

I cannot use golangci by editing the webhook, by trying to enter the repo url in the search field manually, or by selecting the repo from the list of my repositories (because it doesn't show up).

Is there any kind of workaround?