The Istanbul release of Ethereum from last December had a number of important changes, including a new opcode (chainid) that is used by our contracts for layer 2 fork protection (though the net gas metering change is also really important for a lot of contracts now, and the adjustments to the various other costs make some use cases much more viable, including zkp and rollups). Is there any hope of getting geth upgraded to a newer version? (I am not a Go developer myself, but it looks like you might not have made any real extensive changes to geth, other than to systematically change the all of import paths to your GitHub organization?)

https://medium.com/mycrypto/ethereums-istanbul-fork-technical-explanation-48a3aef718b0

(I was asked by @danlaine to bring this issue, which I noted a few days ago and which has been coming up occasionally both from myself and from someone else I don't know who was looking at the economics of running their DEX on Avalanche, from Discord to GitHub.)

The gas price on the various Avalanche EVM chains (C-chain, Athereum, etc.) is hardcoded; and I see #39, but in addition to only applying to other subnets, this is still just letting the subnet select a different genesis-hardcoded price, not resulting in a change of model. What makes this extremely problematic is that it means the transaction price of your network is thereby tied to your token price's volatility--which could fluctuate based on things like speculation and news/political cycles--as opposed to being any reasonable indicator of the cost of computation or bandwidth. In contrast, on Ethereum, if the price of ETH doubles, the cost of gas should quickly halve. With Avalanche, if the price of AVAX doubles, so does the cost of using the network, which has literally meant that I'm rooting for the value of the token to crash and stay depressed, so that the network is more usable... "awkward" ;P.

To provide what is hopefully a useless example of the kind of discussion surrounding this, I work on a project (Orchid) that sells bandwidth, and having this hardcoded gas price concept would be akin to the naive assumption many people seem to have about our product: that bandwidth costs are somehow fixed in OXT at like, 1 OXT / GB, and so people then ask us "how will the volatility of your token affect the viability of payments" and the answer is "it won't, as this is all based on market economics: if the token goes up the price of bandwidth as measured in that token will go down, as in some real sense the price of bandwidth is fundamentally measured in something like the price of bread and other staples; the amount of value from the user required to get bandwidth should only change if the price of networking in the world changes". Only, for Avalanche, this naive model is in fact how it works and is in fact going to be a problem.

As this value is currently hardcoded at 470 (a very recent change from 47 in https://github.com/ava-labs/coreth/commit/dd6b0315849e2383e715e9c0ade50aaca68435f0), the price of transactions on Avalanche are only 1/14.5th the cost of Ethereum right now; and it must be noted that the spread is actually only this high because the value of AVAX has been falling... if the value of AVAX were still closer to $6 (as it was for a while right after launch) the cost would be only around 1/9th. If the value of your token (awkwardly, "heaven forbid") goes up, that means that the usefulness of it over Ethereum will actually decline--and possibly quite quickly--if anyone deploys anything important that actually uses it (as opposed to merely encouraging people to start staking and running validators before you even have users, which is what you have been doing ;P).

I mean, already, the prices of Avalanche are kind of ridiculous for a system claiming to be so much fundamentally more economically viable than Ethereum, as while <10x is still better than nothing--and I appreciate that a key property of Avalanche is that it will (supposedly) scale to a lot more users and keep that same price--the price of Ethereum is and was already way too high for a lot of people, so merely being more scalable but not actually being drastically cheaper is, at least in the short term, kind of a massive let down: there are numerous other systems out there that have been in production longer with real users and which are also Ethereum compatible but which are offering prices that are already 10-100x lower than Avalanche, and that's with so-far zero usage of Avalanche (as the C-chain hasn't actually launched yet) and a falling token price.

FWIW, EIP-1559 has a mechanism proposed for Ethereum which is in many ways similar to the gas model used by Avalanche, which has people burning their fees rather than paying it to miners. In it, Vitalik et al discuss a model of shifting this fee based on the "percentage of the previous block" that is used. Now, I appreciate that Avalanche doesn't have blocks that work like this, but if you re-model gas target as "gas used per time" instead of "gas used per block" then you can probably use very a very similar algorithm to the one from EIP-1559 to auto-calibrate your gas price over time. (Not saying this is what you should do; I'm actually more a fan of the recently-released EIP-2593, which happens to be almost identical to the solution we had come up with for our layer 2 nanopayments--interestingly, ours is also in terms of time, while theirs is in terms of blocks ;P--but the current hardcoded concept and specific value are both unreasonable/concerning).

https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1559.md

I've downloaded and built avalanchego and coreth. I'm having trouble figuring out how to get avalanchego to use my local build of coreth - I've searched the avalanche docs and the docs for the two repos but haven't found instructions.

How do I get a local build of avalanchego to use a local build of coreth? Do I have to place the coreth binary under avalanchego/build/plugins? If so, does the binary need to have a specific name?

backends.SimulatedBackend doesn't implement ethclient.Client interface

To Reproduce:

var _ ethclient.Client = (*backends.SimulatedBackend)(nil)

Expected behavior No compiler error.

Using the default settings, eth_gasPrice crashes with the following trace

ERROR[12-10|16:40:35.051] RPC method eth_gasPrice crashed: runtime error: invalid memory address or nil pointer dereference
goroutine 139 [running]:
github.com/ava-labs/coreth/rpc.(*callback).call.func1(0xc0015e0790, 0xc, 0xc001565cc0)
        /home/ubuntu/install/avalanche/go/pkg/mod/github.com/ava-labs/[email protected]/rpc/service.go:210 +0xbd
panic(0xf3c840, 0x18b2c00)
        /home/ubuntu/install/go1.16.8/src/runtime/panic.go:965 +0x1b9
math/big.(*Int).Cmp(0xc0015a2300, 0x0, 0xc001636440)
        /home/ubuntu/install/go1.16.8/src/math/big/int.go:328 +0x44
github.com/ethereum/go-ethereum/common/math.BigMin(...)
        /home/ubuntu/install/avalanche/go/pkg/mod/github.com/ethereum/[email protected]/common/math/big.go:148
github.com/ava-labs/coreth/eth/gasprice.(*Oracle).SuggestPrice(0xc00014c6c0, 0x1327c78, 0xc001636440, 0xc0012d58d0, 0x4c6e8b, 0xf6ba80)
        /home/ubuntu/install/avalanche/go/pkg/mod/github.com/ava-labs/[email protected]/eth/gasprice/gasprice.go:224 +0x1d1
github.com/ava-labs/coreth/eth.(*EthAPIBackend).SuggestPrice(0xc001480558, 0x1327c78, 0xc001636440, 0x30, 0x7f11b380d5b8, 0x30)
        /home/ubuntu/install/avalanche/go/pkg/mod/github.com/ava-labs/[email protected]/eth/api_backend.go:357 +0x45
github.com/ava-labs/coreth/internal/ethapi.(*PublicEthereumAPI).GasPrice(0xc0010fe910, 0x1327c78, 0xc001636440, 0x0, 0x0, 0x0)
        /home/ubuntu/install/avalanche/go/pkg/mod/github.com/ava-labs/[email protected]/internal/ethapi/api.go:71 +0x4e
reflect.Value.call(0xc0014fe2a0, 0xc00009f850, 0x13, 0x1082042, 0x4, 0xc001654b70, 0x2, 0x2, 0xc0012d5b58, 0x46a08c, ...)
        /home/ubuntu/install/go1.16.8/src/reflect/value.go:476 +0x8e7
reflect.Value.Call(0xc0014fe2a0, 0xc00009f850, 0x13, 0xc001654b70, 0x2, 0x2, 0x1312100, 0xc000032080, 0xc002420000)
        /home/ubuntu/install/go1.16.8/src/reflect/value.go:337 +0xb9
github.com/ava-labs/coreth/rpc.(*callback).call(0xc0014fe420, 0x1327c78, 0xc001636440, 0xc0015e0790, 0xc, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /home/ubuntu/install/avalanche/go/pkg/mod/github.com/ava-labs/[email protected]/rpc/service.go:216 +0x2c5
github.com/ava-labs/coreth/rpc.(*handler).runMethod(0xc00055e640, 0x1327c78, 0xc001636440, 0xc0004f7260, 0xc0014fe420, 0x0, 0x0, 0x0, 0x0)
        /home/ubuntu/install/avalanche/go/pkg/mod/github.com/ava-labs/[email protected]/rpc/handler.go:486 +0x8a
github.com/ava-labs/coreth/rpc.(*handler).handleCall(0xc00055e640, 0xc0015eb680, 0xc0004f7260, 0x1000000426d9b)
        /home/ubuntu/install/avalanche/go/pkg/mod/github.com/ava-labs/[email protected]/rpc/handler.go:434 +0x265
github.com/ava-labs/coreth/rpc.(*handler).handleCallMsg(0xc00055e640, 0xc0015eb680, 0xc0004f7260, 0xc0015eb680)
        /home/ubuntu/install/avalanche/go/pkg/mod/github.com/ava-labs/[email protected]/rpc/handler.go:395 +0x212
github.com/ava-labs/coreth/rpc.(*handler).handleMsg.func1(0xc0015eb680)
        /home/ubuntu/install/avalanche/go/pkg/mod/github.com/ava-labs/[email protected]/rpc/handler.go:167 +0x46
github.com/ava-labs/coreth/rpc.(*handler).startCallProc.func1()
        /home/ubuntu/install/avalanche/go/pkg/mod/github.com/ava-labs/[email protected]/rpc/handler.go:307 +0x1e2
created by github.com/ava-labs/coreth/rpc.(*handler).startCallProc
        /home/ubuntu/install/avalanche/go/pkg/mod/github.com/ava-labs/[email protected]/rpc/handler.go:311 +0xa5

WARN [12-10|16:40:35.051] Served eth_gasPrice                      reqid=1 execTime="165.863µs" procTime="166.486µs" totalTime="166.77µs" err="method handler crashed"

Issue

I am unable to call debug_getModifiedAccountsByNumber. The response is always

{
    "jsonrpc": "2.0",
    "id": 1,
    "error": {
        "code": -32000,
        "message": "no preimage found for hash 5a9331cb1d584bc0703e5252f4fccf19b3887d5a12e7edad074d585640a7ff57"
    }
}

Likely related to commit 5095d5b45a74781949329e120b7a9fb934438bc0

+       Preimages bool // Whether to store preimage of trie key to the disk

Version

# avalanchego --version
avalanche/1.4.12 [database=v1.4.5, commit=cae93d95c1bcdc02e1370d38ed1c9d87f1c8c814]

Steps to Reproduce

See: https://github.com/stevekunk/avalanche-testnet#issue-no-preimage-found-for-hash

You should be able to docker-compose up and then ./curls/debug_getModifiedAccountsByNumber.sh to reproduce the issue

Version: v0.4.2

NewLevelDBDatabaseWithFreezer

is broken. It initialises function

leveldb.New(file, cache, handles, namespace)

but it expects

leveldb.New(file, cache, handles, namespace, false) // 5th parameter is missing

and in NewDatabaseWithCache

return &cachingDB{
		db:            trie.NewDatabaseWithCache(db, cache, journal),
		codeSizeCache: csc,
		codeCache:     fastcache.New(codeCacheSize),
	}

trie.NewDatabaseWithCache is missing

Our gas limit logic fails because eth_gasPrice goes from its initial 225000000000 down to 0 after a block is produced, but the pool gas tip cap stays at 225000000000. The local test logic multiplies the supposed gas price by 2 and gets 0, which in the following transaction results in transaction underpriced: address 0x3Cd0A705a2DC65e5b1E1205896BaA2be8A07c6e0 have gas tip cap (0) \u003c pool gas tip cap (225000000000). I added on a commit to https://github.com/AaronKutch/avalanchego_block_bug to exhibit this, run with bash run.sh. The logs have

INFO [07-07|01:12:34.021] <C Chain> github.com/ava-labs/coreth/internal/ethapi/api.go:1745: Submitted transaction hash=0x1f9e4098f9a4717a9352b401ed1c220d56aba742fba319feeeff5771f49d9504 from=0x3Cd0A705a2DC65e5b1E1205896BaA2be8A07c6e0 nonce=0 recipient=0x798d4Ba9baf0064Ec19eB4F0a1a45785ae9D6DFc value=1 type=0 gasFeeCap=321,000,000,000 gasTipCap=321,000,000,000 gasPrice=321,000,000,000
INFO [07-07|01:12:34.031] <C Chain> github.com/ava-labs/coreth/internal/ethapi/api.go:1745: Submitted transaction hash=0x33fc41add96dba33bfd645c8fb473a649a6767c01437ea48a87e9b2d29277053 from=0x3Cd0A705a2DC65e5b1E1205896BaA2be8A07c6e0 nonce=1 recipient=0x798d4Ba9baf0064Ec19eB4F0a1a45785ae9D6DFc value=1 type=0 gasFeeCap=321,000,000,000 gasTipCap=321,000,000,000 gasPrice=321,000,000,000
INFO [07-07|01:12:37.023] <C Chain> github.com/ava-labs/coreth/miner/worker.go:343: Commit new mining work number=1 hash=3d5189..ef3b83 uncles=0 txs=2 gas=42000 fees=0.013482 elapsed="362.313µs"
[07-07|01:12:37.023] INFO <C Chain> proposervm/pre_fork_block.go:163 built block U1JLTWLesCiRAKd9BL4waz2pmTSDK4eHXE4JtkiGxTBj5Mv2R - parent timestamp 1970-01-01 00:00:00 +0000 UTC
WARN [07-07|01:12:41.042] <C Chain> github.com/ava-labs/coreth/rpc/handler.go:404: Served eth_sendRawTransaction conn=127.0.0.1:33074 reqid=0 execTime="479.554µs" procTime="505.093µs" totalTime="505.433µs" err="transaction underpriced: address 0x3Cd0A705a2DC65e5b1E1205896BaA2be8A07c6e0 have gas tip cap (0) < pool gas tip cap (225000000000)"

and the curl responses are

{"jsonrpc":"2.0","id":0,"result":"0x34630b8a00"} // gas price
{"jsonrpc":"2.0","id":0,"result":"0x1f9e4098f9a4717a9352b401ed1c220d56aba742fba319feeeff5771f49d9504"}
{"jsonrpc":"2.0","id":0,"result":"0x34630b8a00"}
{"jsonrpc":"2.0","id":0,"result":"0x33fc41add96dba33bfd645c8fb473a649a6767c01437ea48a87e9b2d29277053"}
{"jsonrpc":"2.0","id":0,"result":"0x0"} // gas price is now zero after a block has been processed
{"jsonrpc":"2.0","id":0,"error":{"code":-32000,"message":"transaction underpriced: address 0x3Cd0A705a2DC65e5b1E1205896BaA2be8A07c6e0 have gas tip cap (0) \u003c pool gas tip cap (225000000000)"}}

The C-Chain runs in a separate process from the main AvalancheGo process and communicates with it over a local gRPC connection.

Where exactly in the Avalanche codebase does the gRPC communication happen between Avalanche and EVM?

Basically i was spamming the network with transactions and a few hundred of them were processed successfully but then suddenly that error start pop up and i had to restart the node. (edited) It's a random error, I'm having 2 more machines next to me running without any issues for couple hours already (edited)

9/15/2020, 10:35:36 AM error: Send transaction error : {"reason":"missing response","code":"SERVER_ERROR","requestBody":"{\"method\":\"eth_getTransactionReceipt\",\"params\":[\"0x7fcef903203585d6e3386539ab083724b1177acc7bd77366d5aa36b9770f5a87\"],\"id\":34151,\"jsonrpc\":\"2.0\"}","requestMethod":"POST","serverError":{"errno":"EADDRINUSE","code":"EADDRINUSE","syscall":"connect","address":"127.0.0.1","port":9650},"url":"http://127.0.0.1:9650/ext/bc/C/rpc"}

I have a repro here https://github.com/AaronKutch/avalanchego_block_bug . Run bash run.sh. What this does is start avalanchego with a genesis file that prefunds a 0xBf... account, and I want to make a transaction to send some of the funds fo a 0xb3 account. The log file has as its last line

INFO [06-29|03:59:07.594] <C Chain> github.com/ava-labs/coreth/internal/ethapi/api.go:1745: Submitted transaction hash=0xc0ea83c5c1b2ba2b2d1ae9d3748b87625044acd4f562ae79bf02f49f77e0a763 from=0xBf660843528035a5A4921534E156a27e64B231fE nonce=0 recipient=0xb3d82b1367D362DE99aB59A658165AFf520CBd4d value=10,000,000,000,000,000,000,000,000 type=0 gasFeeCap=30,000,000,000 gasTipCap=30,000,000,000 gasPrice=30,000,000,000

I expect that a block should be produced almost immediately to include the transaction, but the chain just sits there. After 20 seconds we check the account funds and block number and see that nothing has changed. Strangely, I do get blocks if contracts are submitted.

Bumps github.com/urfave/cli/v2 from 2.10.2 to 2.23.7.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps github.com/hashicorp/go-bexpr from 0.1.10 to 0.1.11.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps github.com/google/uuid from 1.2.0 to 1.3.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps github.com/cespare/cp from 0.1.0 to 1.1.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps github.com/tyler-smith/go-bip39 from 1.0.2 to 1.1.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Hi there!

Coreth uses outdated version of github.com/google/uuid, which causes conflicts with other dependencies which depends on new uuid version. This PR updates github.com/google/uuid dependency from v1.1.5 to v1.3.0