[mirror] This is a linter for Go source code.

Hi everyone 👋

golint is great but sometimes you want all the rules except one and it would be wonderful to specify it somewhere. Other modern linters like ESLint support it, would be good to have it supported in golint as well.

Unable to fetch golang/lint because of unexpected module path error.

go get -u golang.org/x/lint
go: finding golang.org/x/lint latest
go: finding golang.org/x/sync latest
go: finding google.golang.org/genproto latest
go: finding golang.org/x/net latest
go: finding github.com/golang/glog latest
go: finding golang.org/x/tools latest
go: finding github.com/golang/lint latest
go: github.com/golang/[email protected]: parsing go.mod: unexpected module path "golang.org/x/lint"
go: finding golang.org/x/exp latest
go: finding golang.org/x/oauth2 latest
go: finding honnef.co/go/tools latest
go: finding golang.org/x/sys latest
go get: error loading module requirements

I've just started learning Golang and while I do want to follow best practises and follow this linter, I'm not sure how to fix these warnings. When I put some random comment above some function or a type nothing really happens.

For instance, if I put a comment above "type Saturation struct" I get another warning message :

comment on exported type Salutation should be of the form "Salutation ..." (with optional leading article)

Please if you can, guide me on how to comment my code properly so I can avoid these warnings, they are freaking me out like hell.

As a build step it's often useful to run a linter over your whole project and see what needs linting. I added the command line option -recursive to set recursive scanning and also added the requisite stuff for dealing with directories.

should omit type uint32 from declaration of var flags; it will be inferred from the right-hand side

This is technically incorrect, as type inference assumes int.

This is similar to #7.

The line in question is this ugly bit of code:

var flags uint32 = syscall.IN_MOVED_TO | syscall.IN_MOVED_FROM |
    syscall.IN_CREATE | syscall.IN_ATTRIB | syscall.IN_MODIFY |
    syscall.IN_MOVE_SELF | syscall.IN_DELETE | syscall.IN_DELETE_SELF

Note: I updated to latest to confirm that this is still an issue, ae65d273b9f43866a987aed78633d2c9ff1966ce.

When using errors.New(fmt.Sprintf(...)), lint will alert that you should use fmt.Errorf(...).

Before this patch, this alert was also displayed when using a custom errors-package. There are valid use cases to use errors.New(fmt.Sprintf(...)) in a custom errors-package context.

This patch avoids the "false positive" alert when a custom errors-package is imported in the current file.

Fixes golang/lint#350

I'd like to continue from #303. All credits go to @dvyukov's work.

This PR will ignore /vendor/ by default when linting. But golint ./vendor/... will still lint that vendor directory normally.

This'll fix #320 and fix #151.

$ go get -u golang.org/x/lint/golint
package golang.org/x/lint/golint: unrecognized import path "golang.org/x/lint/golint" (parse https://golang.org/x/lint/golint?go-get=1: no go-import meta tags ())

Seeing this locally and from our ci server.

└> go get -u golang.org/x/lint/golint
# golang.org/x/tools/go/internal/gcimporter
Projects/Go/src/golang.org/x/tools/go/internal/gcimporter/bimport.go:541:8: undefined: types.NewInterface2
Projects/Go/src/golang.org/x/tools/go/internal/gcimporter/iimport.go:540:10: undefined: types.NewInterface2

Please delete the message should have comment or be unexported . This message will hurt my nerve in vscode and I'm not endearing these messages in my code yet.

Whenever necessary, I add to my comment code and do not need to display this message. What is the reason why you decide for me and make sure you comment on the code?

Fixes golang/lint#381

This change analyses all files in the package upfront. It reports a single error if no valid package comment was found and at least one non-test file is present.

Malformed package comments will still produce per-file errors, whether the missing package comment error is generated or not.

Because this largely eliminates false positives, the confidence has been bumped to golint's default value of 0.8.