Hello,

thanks for this neat utility, I mostly use it to rotate AWS access-keys. To that effect, would it be possible to add flags to the rotate-keys command to allow for deactivation/deletion of the previous, now rotated keys?

Thanks.

Correctly show instances.

This pull-request closes #21 by correctly iterating over instances, quite how this ever worked (without the -json flag) is a mystery to me.

Having an unset hostname was a red-herring.

Receiving an error with empty instances here:

% AWS_SDK_LOAD_CONFIG=1 aws-utils  instances   

errors running instance dump
error invoking callback: error rendering template template: output:2:2: executing "output" at <.InstanceName>: can't evaluate field InstanceName in type []instances.InstanceOutput
Steve.Kemp@Steves-MacBook-Pro .aws % 

This closes #19, by making it possible to remove the orphaned keys that might remain after generating a new one.

If there are two keys present before things start then one will be removed as part of the generation of the new one - in that case we'll see an errors when we try to remove that a second time, but that is harmless.

This pull-request will close #17, by allowing more flexible output generation:

• The default text/template which is used by the instances subcommand can be replaced by the user.
• The csv-instances sub-command will accept a format-string showing which fields to output.

In both cases the default(s) remain largely as-is, but this will allow increased flexibility for the user.

Today I was asked to provide a mapping of "name + IPv4" address for a bunch of accounts. This would have been easier if I could run:

  $ aws-utils csv-instances --fields="name,ipv4"

Of course once I realize this I can also say that the instances and csv-instances are very very similar (which they definitely are). Merging the two commands into one almost makes sense, but I use them for different purposes and it would be nice to keep the simple nature alone.

To close this issue:

• Remove the duplication between the two commands, with regard to getting the data at least.
• Allow the user to specify different fields for the CSV instnace, at least.
  • Ideally a template for the instances subcommand too.

No changes to the default behaviour from the end-user perspective though, even if they gain the ability to change the formatting/templates.

Update the stacks command such that we report stacks correctly.

It was possible if a stack had been deleted, then a new stack created with the same name, that we'd fail to show it as being present (unless -all was added).

This is because the ordering of the AWS output was random an we only maintained a map of name => state, rather than name => []state.

This closes #13.

When a stack is present in multiple states it might get excluded.

• Imagine you create a stack, then delete it.
• Later you create a stack with the same name.

This results in two stacks in the list-stack output :

• One in DELETE_COMPLETE state
• One in CREATE_COMPLETE state

Depending on the random ordering this might get excluded. We need to build/maintain a list of the stack-stats not a simple key=>value hash, which will overwrite the stack-details.

This configuration file is fine:

wc41 ~ $ cat ~/.aws/credentials 
[default]
aws_access_key_id=1234...
aws_secret_access_key=abc...

But the moment you have other profiles present as well things break:

 $ cat ~/.aws/credentials 
[default]
aws_access_key_id=1234..
aws_secret_access_key=abc..

[tmp]
aws_secret_access_key=124.
aws_access_key_id=blah
aws_session_token=secret

Specifically the values of all the keys get updated, not just the first one.

I guess we just replace the first value, not all the values, and that will solve this.

This pull-request closes #9, by moving towards a callback-based solution.

We use a helper to define a callback function, and that is either invoked once for the single (default) AWS account, or called once for each role specified in the role-file.

Several of our commands now operate either on the main AWS account, or a set of roles assumed from it:

• csv-instances
• instances
• sg-grep

Rather than duplicating all the code create a helper which does that once, and triggers a callback into the sub-command for the handling.